Skip to content

Exceptions on events not calling server-side UnhandledException infrastructure #8611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rynowak opened this issue Mar 18, 2019 · 2 comments
Closed
Assignees
Labels
area-blazor Includes: Blazor, Razor Components enhancement This issue represents an ask for new feature or an enhancement to an existing one

Comments

@rynowak
Copy link
Member

rynowak commented Mar 18, 2019

Exceptions thrown as a result of an event handler or JS Interop call don't call the server-side UnhandledException handler. Circuits and the sync context have their own unhandled exception events, and they don't fire for JS interop.

Is this right? I suppose the idea is that the exception is handled by the JS side. One piece of this that we need to be careful about is the fact that our exceptions aren't all going through a single path. For instance we don't have any hooks in place to sanitize these exceptions in production.

@rynowak rynowak added area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates area-blazor Includes: Blazor, Razor Components labels Mar 18, 2019
@mkArtakMSFT
Copy link
Member

Goal:

  • exceptions from calls from events should be logged on the server
  • exceptions from calls from JSInterop should be handled on the client

@mkArtakMSFT mkArtakMSFT added this to the 3.0.0-preview4 milestone Mar 19, 2019
@mkArtakMSFT mkArtakMSFT added enhancement This issue represents an ask for new feature or an enhancement to an existing one 1 - Ready labels Mar 19, 2019
@mkArtakMSFT mkArtakMSFT removed area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates labels May 9, 2019
@mkArtakMSFT mkArtakMSFT assigned javiercn and unassigned rynowak Jun 25, 2019
@mkArtakMSFT
Copy link
Member

Closing as there has been covered by the work @javiercn has done.

@ghost ghost locked as resolved and limited conversation to collaborators Dec 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-blazor Includes: Blazor, Razor Components enhancement This issue represents an ask for new feature or an enhancement to an existing one
Projects
None yet
Development

No branches or pull requests

4 participants