Skip to content

Resolve potential conflicts between CORS and HTTP method metadata #9127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rynowak opened this issue Apr 5, 2019 · 1 comment
Closed

Resolve potential conflicts between CORS and HTTP method metadata #9127

rynowak opened this issue Apr 5, 2019 · 1 comment
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates
Milestone
3.0.0-preview7

Comments

@rynowak
Copy link
Member

rynowak commented Apr 5, 2019

See here: #9099 (comment)

MVC is smart enough to figure this out, but it's not incredibly obvious. The HttpMethod metadata contains a setting that says whether the endpoint is CORS aware or not. It's not clear how you could use a convention to correctly enable CORS for a random endpoint.
@rynowak rynowak added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Apr 5, 2019
@rynowak rynowak added this to the 3.0.0-preview6 milestone Apr 5, 2019
@rynowak rynowak mentioned this issue Apr 5, 2019
Merged
@mkArtakMSFT
Copy link
Contributor

Closing as we won't find time doing this.

@ghost ghost locked as resolved and limited conversation to collaborators Dec 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates
Projects
None yet
Milestone
3.0.0-preview7
Development

No branches or pull requests
2 participants
@rynowak @mkArtakMSFT