Skip to content

Clean up baseline reference suppression #9473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
natemcmaster opened this issue Apr 17, 2019 · 6 comments
Closed

Clean up baseline reference suppression #9473

natemcmaster opened this issue Apr 17, 2019 · 6 comments
Assignees
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework severity-minor This label is used by an internal tool
Milestone

Comments

@natemcmaster
Copy link
Contributor

As a part of #9405, I added a way to tell the build system when breaking changes to <References> are intentional and can be ignored. This is done by adding a <SuppressBaselineReference> item to the .csproj file.

After 3.0 is complete, we will update our baseline files, but we should also remove all baseline suppressions to make sure 3.1 is consistent with 3.0.

@natemcmaster natemcmaster added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Apr 17, 2019
@natemcmaster natemcmaster added this to the 3.1.0 milestone Apr 17, 2019
@Pilchie
Copy link
Member

Pilchie commented Nov 18, 2019

@aspnet/build Should this still be in the 3.1.0 milestone?

@dougbu
Copy link
Contributor

dougbu commented Nov 18, 2019

@Pilchie not 3.1.0 but soon I hope. We partially fixed things up after 3.0.0 but #14630 blocks removing all suppressions. My hope is @wtgodbe or @JunTaoLuo will have some time to fix that bug next week or one of the three of us could do it the week after.

@pranavkm pranavkm modified the milestones: 3.1.0, 3.1.x Dec 9, 2019
@JunTaoLuo JunTaoLuo modified the milestones: 3.1.x, 6.0-preview1 Dec 10, 2020
@JunTaoLuo JunTaoLuo added severity-nice-to-have This label is used by an internal tool severity-minor This label is used by an internal tool and removed severity-nice-to-have This label is used by an internal tool labels Dec 10, 2020
@dougbu
Copy link
Contributor

dougbu commented Jan 22, 2021

@wtgodbe and @JunTaoLuo isn't this work done❔ I'm not sure what's missing now that #14630 work is complete

@wtgodbe
Copy link
Member

wtgodbe commented Jan 22, 2021

I believe it's about seeing what happens when we remove all of these, to make sure 6.0 is consistent with 5.0: https://github.com/dotnet/aspnetcore/search?q=SuppressBaselineReference. Probably an exercise we should do after every release

@dougbu
Copy link
Contributor

dougbu commented Jan 22, 2021

an exercise we should do after every release

Ah, good point. When you have a chance, could you see if the baseline suppressions can all be removed❔

@wtgodbe
Copy link
Member

wtgodbe commented Apr 5, 2021

Done by #29934

@wtgodbe wtgodbe closed this as completed Apr 5, 2021
@ghost ghost locked as resolved and limited conversation to collaborators May 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework severity-minor This label is used by an internal tool
Projects
None yet
Development

No branches or pull requests

6 participants