-
Notifications
You must be signed in to change notification settings - Fork 10.3k
Clean up baseline reference suppression #9473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@aspnet/build Should this still be in the |
@Pilchie not |
@wtgodbe and @JunTaoLuo isn't this work done❔ I'm not sure what's missing now that #14630 work is complete |
I believe it's about seeing what happens when we remove all of these, to make sure 6.0 is consistent with 5.0: https://github.com/dotnet/aspnetcore/search?q=SuppressBaselineReference. Probably an exercise we should do after every release |
Ah, good point. When you have a chance, could you see if the baseline suppressions can all be removed❔ |
Done by #29934 |
As a part of #9405, I added a way to tell the build system when breaking changes to
<References>
are intentional and can be ignored. This is done by adding a<SuppressBaselineReference>
item to the .csproj file.After 3.0 is complete, we will update our baseline files, but we should also remove all baseline suppressions to make sure 3.1 is consistent with 3.0.
The text was updated successfully, but these errors were encountered: