Skip to content

Produce reference assemblies for Microsoft.AspNetCore.App #9479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Eilon opened this issue Apr 17, 2019 · 3 comments
Closed

Produce reference assemblies for Microsoft.AspNetCore.App #9479

Eilon opened this issue Apr 17, 2019 · 3 comments
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Milestone

Comments

@Eilon
Copy link
Contributor

Eilon commented Apr 17, 2019

This issue is a follow-up to #3610 for remaining work.

From @natemcmaster :

Work remaining: ensure these requirements are met (they are not currently). This will require a combination of writing tests and changing some MSbuild goop.

  • Reference assemblies must not change assembly version in patch updates. They remain constant at "Version=3.0.0.0" for the lifetime of netcoreapp3.0.
  • Implementation binaries must satisfy the API surface of the reference assembly
  • API breaking changes to any assembly in Microsoft.AspNetCore.App are not allowed after 3.0.0
@Eilon Eilon added the feature-platform Deprecated: Cross-cutting issues related to ASP.NET Core as a platform label Apr 17, 2019
@natemcmaster natemcmaster added this to the 3.0.0 milestone May 28, 2019
@natemcmaster
Copy link
Contributor

@Pilchie this one will definitely affect servicing 3.0.x and would be good to review before RTM.

@analogrelay
Copy link
Contributor

  • Reference assemblies must not change assembly version in patch updates. They remain constant at "Version=3.0.0.0" for the lifetime of netcoreapp3.0.

We do this for all assemblies already, so I don't think ref assemblies will need anything special here.

  • Implementation binaries must satisfy the API surface of the reference assembly

Essentially this is saying that the ref folder contents for a given branch must not change after the release ship. We could have some automation in place to ensure that.

  • API breaking changes to any assembly in Microsoft.AspNetCore.App are not allowed after 3.0.0

My thinking is that this will fall out of the previous item (ensuring binaries satisify the reference assembly). Even today, API breaking changes show up in code check. We would effectively be forbidding regeneration of ref asms (the current way to "fix" ref asm conflicts).

@dougbu
Copy link
Contributor

dougbu commented Aug 30, 2019

We could have some automation in place to ensure that.

This part is a dupe of what we do in Code Check as well as #4259.

@dougbu dougbu closed this as completed Aug 30, 2019
@ghost ghost locked as resolved and limited conversation to collaborators Dec 3, 2019
@JunTaoLuo JunTaoLuo added area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework and removed feature-platform Deprecated: Cross-cutting issues related to ASP.NET Core as a platform labels Jan 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Development

No branches or pull requests

5 participants