Skip to content

Improve performance of ASP.NET Core with logging on #9594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
davidfowl opened this issue Apr 20, 2019 · 0 comments
Open

Improve performance of ASP.NET Core with logging on #9594

davidfowl opened this issue Apr 20, 2019 · 0 comments
Labels
affected-medium This issue impacts approximately half of our customers area-hosting Includes Hosting area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions enhancement This issue represents an ask for new feature or an enhancement to an existing one Perf severity-minor This label is used by an internal tool
Milestone
Backlog

Comments

@davidfowl
Copy link
Member

davidfowl commented Apr 20, 2019 •
edited
Loading

With the default settings and a hello world middleware, we go from 0 allocations to ~12 (some objects are pretty large as well). The following is a memory profile of 10,000 requests with logging turned on at the "Warning" level:

image

cc @benaadams @noahfalk
@davidfowl davidfowl mentioned this issue Apr 20, 2019
Merged
This was referenced Apr 24, 2019
Merged
Merged
@benaadams benaadams mentioned this issue May 10, 2019
Merged
This was referenced Jun 9, 2019
Merged
Merged
@analogrelay analogrelay added this to the Backlog milestone Jun 27, 2019
@Tratcher Tratcher added affected-medium This issue impacts approximately half of our customers enhancement This issue represents an ask for new feature or an enhancement to an existing one severity-minor This label is used by an internal tool labels Nov 9, 2020 — with ASP.NET Core Issue Ranking
@amcasey amcasey added area-hosting Includes Hosting and removed feature-hosting labels Jun 1, 2023
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affected-medium This issue impacts approximately half of our customers area-hosting Includes Hosting area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions enhancement This issue represents an ask for new feature or an enhancement to an existing one Perf severity-minor This label is used by an internal tool
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
5 participants
@analogrelay @davidfowl @Tratcher @JunTaoLuo @amcasey