From d148de81129b66407a9cd9b8d8e2d2516ded7c74 Mon Sep 17 00:00:00 2001 From: Tanay Parikh Date: Fri, 25 Jun 2021 13:05:40 -0700 Subject: [PATCH 1/2] Quarantine RedisEndToEnd Tests `HubConnectionCanSendAndReceiveGroupMessages` & `CanSendAndReceiveUserMessagesWhenOneConnectionWithUserDisconnects` --- src/SignalR/server/StackExchangeRedis/test/RedisEndToEnd.cs | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/SignalR/server/StackExchangeRedis/test/RedisEndToEnd.cs b/src/SignalR/server/StackExchangeRedis/test/RedisEndToEnd.cs index 24ae992907bf..eb71f62d4f73 100644 --- a/src/SignalR/server/StackExchangeRedis/test/RedisEndToEnd.cs +++ b/src/SignalR/server/StackExchangeRedis/test/RedisEndToEnd.cs @@ -60,6 +60,7 @@ public async Task HubConnectionCanSendAndReceiveMessages(HttpTransportType trans [ConditionalTheory] [SkipIfDockerNotPresent] [MemberData(nameof(TransportTypesAndProtocolTypes))] + [QuarantineTest("https://github.com/dotnet/aspnetcore/issues/33851")] public async Task HubConnectionCanSendAndReceiveGroupMessages(HttpTransportType transportType, string protocolName) { using (StartVerifiableLog()) @@ -121,6 +122,7 @@ public async Task CanSendAndReceiveUserMessagesFromMultipleConnectionsWithSameUs [ConditionalTheory] [SkipIfDockerNotPresent] [MemberData(nameof(TransportTypesAndProtocolTypes))] + [QuarantineTest("https://github.com/dotnet/aspnetcore/issues/33851")] public async Task CanSendAndReceiveUserMessagesWhenOneConnectionWithUserDisconnects(HttpTransportType transportType, string protocolName) { // Regression test: From 6bb9712427285ee18ab252b41741523f8a6ffcf0 Mon Sep 17 00:00:00 2001 From: Tanay Parikh Date: Fri, 25 Jun 2021 13:38:39 -0700 Subject: [PATCH 2/2] Update RedisEndToEnd.cs --- src/SignalR/server/StackExchangeRedis/test/RedisEndToEnd.cs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/SignalR/server/StackExchangeRedis/test/RedisEndToEnd.cs b/src/SignalR/server/StackExchangeRedis/test/RedisEndToEnd.cs index eb71f62d4f73..0cf7878f4f4c 100644 --- a/src/SignalR/server/StackExchangeRedis/test/RedisEndToEnd.cs +++ b/src/SignalR/server/StackExchangeRedis/test/RedisEndToEnd.cs @@ -60,7 +60,7 @@ public async Task HubConnectionCanSendAndReceiveMessages(HttpTransportType trans [ConditionalTheory] [SkipIfDockerNotPresent] [MemberData(nameof(TransportTypesAndProtocolTypes))] - [QuarantineTest("https://github.com/dotnet/aspnetcore/issues/33851")] + [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/33851")] public async Task HubConnectionCanSendAndReceiveGroupMessages(HttpTransportType transportType, string protocolName) { using (StartVerifiableLog()) @@ -122,7 +122,7 @@ public async Task CanSendAndReceiveUserMessagesFromMultipleConnectionsWithSameUs [ConditionalTheory] [SkipIfDockerNotPresent] [MemberData(nameof(TransportTypesAndProtocolTypes))] - [QuarantineTest("https://github.com/dotnet/aspnetcore/issues/33851")] + [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/33851")] public async Task CanSendAndReceiveUserMessagesWhenOneConnectionWithUserDisconnects(HttpTransportType transportType, string protocolName) { // Regression test: