diff --git a/.azure/pipelines/ci.yml b/.azure/pipelines/ci.yml
index c5d4873ddd96..86073811670e 100644
--- a/.azure/pipelines/ci.yml
+++ b/.azure/pipelines/ci.yml
@@ -673,35 +673,6 @@ stages:
publishOnError: true
includeForks: true
- - template: jobs/default-build.yml
- parameters:
- condition: ne(variables['SkipTests'], 'true')
- jobName: Windows_Templates_Test
- jobDisplayName: "Test: Templates - Windows Server 2016 x64"
- agentOs: Windows
- isTestingJob: true
- testRunTitle: Templates-$(AgentOsName)-$(BuildConfiguration)
- steps:
- - script: ./eng/build.cmd -ci -nobl -all -pack $(_InternalRuntimeDownloadArgs)
- displayName: Build Repo
- - script: ./src/ProjectTemplates/build.cmd -ci -nobl -noBuildRepoTasks -pack -NoRestore -noBuildNative -NoBuilddeps "/p:RunTemplateTests=true"
- displayName: Pack Templates
- - script: ./src/ProjectTemplates/build.cmd -ci -nobl -noBuildRepoTasks -test -NoRestore -NoBuild -NoBuilddeps "/p:RunTemplateTests=true"
- displayName: Test Templates
- artifacts:
- - name: Windows_Test_Templates_Dumps
- path: artifacts/dumps/
- publishOnError: true
- includeForks: true
- - name: Windows_Test_Templates_Logs
- path: artifacts/log/
- publishOnError: true
- includeForks: true
- - name: Windows_Test_Templates_Results
- path: artifacts/TestResults/
- publishOnError: true
- includeForks: true
-
- template: jobs/default-build.yml
parameters:
condition: ne(variables['SkipTests'], 'true')
diff --git a/.azure/pipelines/quarantined-pr.yml b/.azure/pipelines/quarantined-pr.yml
index fe4ba54c818c..7f3b9c9d650e 100644
--- a/.azure/pipelines/quarantined-pr.yml
+++ b/.azure/pipelines/quarantined-pr.yml
@@ -86,10 +86,7 @@ jobs:
steps:
- powershell: "& ./eng/build.ps1 -CI -nobl -all -pack -NoBuildJava"
displayName: Build
- # The templates part can be removed when the Blazor Templates run on Helix
- - script: ./src/ProjectTemplates/build.cmd -ci -nobl -pack -NoRestore -NoBuildNative -NoBuilddeps "/p:RunTemplateTests=true"
- displayName: Pack Templates
- - script: ./eng/build.cmd -ci -nobl -test -NoRestore -NoBuild -NoBuilddeps "/p:RunTemplateTests=true /p:RunQuarantinedTests=true /p:SkipHelixReadyTests=true"
+ - script: ./eng/build.cmd -ci -nobl -test -NoRestore -NoBuild -NoBuilddeps "/p:RunQuarantinedTests=true /p:SkipHelixReadyTests=true"
displayName: Run Quarantined Tests
continueOnError: true
- task: PublishTestResults@2
diff --git a/eng/tools/RepoTasks/CreateFrameworkListFile.cs b/eng/tools/RepoTasks/CreateFrameworkListFile.cs
index 8005f81f65fe..5015bf4d5f7c 100644
--- a/eng/tools/RepoTasks/CreateFrameworkListFile.cs
+++ b/eng/tools/RepoTasks/CreateFrameworkListFile.cs
@@ -50,7 +50,7 @@ public override bool Execute()
FileVersion = FileUtilities.GetFileVersion(item.ItemSpec),
IsNative = item.GetMetadata("IsNativeImage") == "true",
IsSymbolFile = item.GetMetadata("IsSymbolFile") == "true",
- PackagePath = item.GetMetadata("PackagePath")
+ PackagePath = GetPackagePath(item)
})
.Where(f =>
!f.IsSymbolFile &&
@@ -125,5 +125,17 @@ public override bool Execute()
return !Log.HasLoggedErrors;
}
+ private static string GetPackagePath(ITaskItem item)
+ {
+ string packagePath = item.GetMetadata("PackagePath");
+
+ // replicate the logic used by PackTask https://github.com/NuGet/NuGet.Client/blob/f24bad0668193ce21a1db8cabd1ce95ba509c7f0/src/NuGet.Core/NuGet.Build.Tasks.Pack/PackTaskLogic.cs#L644-L647
+ string recursiveDir = item.GetMetadata("RecursiveDir");
+ recursiveDir = string.IsNullOrEmpty(recursiveDir) ? item.GetMetadata("NuGetRecursiveDir") : recursiveDir;
+
+ return string.IsNullOrEmpty(recursiveDir) ? packagePath :
+ Path.Combine(packagePath, recursiveDir);
+ }
}
+
}
diff --git a/src/Framework/App.Ref/src/Microsoft.AspNetCore.App.Ref.csproj b/src/Framework/App.Ref/src/Microsoft.AspNetCore.App.Ref.csproj
index 43eba091547f..d9585ae55428 100644
--- a/src/Framework/App.Ref/src/Microsoft.AspNetCore.App.Ref.csproj
+++ b/src/Framework/App.Ref/src/Microsoft.AspNetCore.App.Ref.csproj
@@ -164,8 +164,7 @@ This package is an internal implementation of the .NET Core SDK and is not meant
Include="@(AspNetCoreReferenceAssemblyPath->WithMetadataValue('ExternallyResolved', 'true')->'%(RootDir)%(Directory)%(Filename).xml')"
Condition="Exists('%(RootDir)%(Directory)%(Filename).xml')" />
- <_AnalyzerContent Include="$(PkgMicrosoft_AspNetCore_Internal_Transport)\$(AnalyzersPackagePath)**\*.*" />
-
+
@@ -204,9 +203,9 @@ This package is an internal implementation of the .NET Core SDK and is not meant
+ Outputs="@(RefPackContent->'$(LayoutTargetDir)%(PackagePath)%(RecursiveDir)%(FileName)%(Extension)')">
@@ -219,9 +218,9 @@ This package is an internal implementation of the .NET Core SDK and is not meant
+ Outputs="@(RefPackContent->'$(LocalInstallationOutputPath)%(PackagePath)%(RecursiveDir)%(FileName)%(Extension)')">
diff --git a/src/Framework/test/TargetingPackTests.cs b/src/Framework/test/TargetingPackTests.cs
index 7c372f62173a..99b43ca08ee3 100644
--- a/src/Framework/test/TargetingPackTests.cs
+++ b/src/Framework/test/TargetingPackTests.cs
@@ -366,7 +366,7 @@ void CompareFrameworkElements(HashSet expectedAssemblyNames, IEnumerable
});
}
- [Fact(Skip = "Skip until layout issues are resolved. See https://github.com/dotnet/aspnetcore/pull/34033")]
+ [Fact]
public void FrameworkListListsContainsCorrectPaths()
{
if (!_isTargetingPackBuilding || string.IsNullOrEmpty(Environment.GetEnvironmentVariable("helix")))
diff --git a/src/ProjectTemplates/test/ProjectTemplates.Tests.csproj b/src/ProjectTemplates/test/ProjectTemplates.Tests.csproj
index a03ad776e2ac..4566ee824a61 100644
--- a/src/ProjectTemplates/test/ProjectTemplates.Tests.csproj
+++ b/src/ProjectTemplates/test/ProjectTemplates.Tests.csproj
@@ -10,7 +10,6 @@
true
true
- false