diff --git a/src/Mvc/Mvc.Core/src/ModelBinding/FormValueHelper.cs b/src/Mvc/Mvc.Core/src/ModelBinding/FormValueHelper.cs new file mode 100644 index 000000000000..b556aa221570 --- /dev/null +++ b/src/Mvc/Mvc.Core/src/ModelBinding/FormValueHelper.cs @@ -0,0 +1,9 @@ +// Licensed to the .NET Foundation under one or more agreements. +// The .NET Foundation licenses this file to you under the MIT license. + +namespace Microsoft.AspNetCore.Mvc.ModelBinding; + +internal static class FormValueHelper +{ + public const string CultureInvariantFieldName = "__Invariant"; +} diff --git a/src/Mvc/Mvc.Core/src/ModelBinding/FormValueProvider.cs b/src/Mvc/Mvc.Core/src/ModelBinding/FormValueProvider.cs index 1c9c1cfde5d7..6c1d91854974 100644 --- a/src/Mvc/Mvc.Core/src/ModelBinding/FormValueProvider.cs +++ b/src/Mvc/Mvc.Core/src/ModelBinding/FormValueProvider.cs @@ -13,8 +13,6 @@ namespace Microsoft.AspNetCore.Mvc.ModelBinding; /// public class FormValueProvider : BindingSourceValueProvider, IEnumerableValueProvider { - internal const string CultureInvariantFieldName = "__Invariant"; - private readonly IFormCollection _values; private readonly HashSet? _invariantValueKeys; private PrefixContainer? _prefixContainer; @@ -43,7 +41,7 @@ public FormValueProvider( _values = values; - if (_values.TryGetValue(CultureInvariantFieldName, out var invariantKeys) && invariantKeys.Count > 0) + if (_values.TryGetValue(FormValueHelper.CultureInvariantFieldName, out var invariantKeys) && invariantKeys.Count > 0) { _invariantValueKeys = new(invariantKeys, StringComparer.OrdinalIgnoreCase); } diff --git a/src/Mvc/Mvc.Core/src/ModelBinding/JQueryFormValueProvider.cs b/src/Mvc/Mvc.Core/src/ModelBinding/JQueryFormValueProvider.cs index a86584e3f4f4..875b67e2b3b4 100644 --- a/src/Mvc/Mvc.Core/src/ModelBinding/JQueryFormValueProvider.cs +++ b/src/Mvc/Mvc.Core/src/ModelBinding/JQueryFormValueProvider.cs @@ -27,7 +27,7 @@ public JQueryFormValueProvider( CultureInfo? culture) : base(bindingSource, values, culture) { - if (values.TryGetValue(FormValueProvider.CultureInvariantFieldName, out var invariantKeys) && invariantKeys.Count > 0) + if (values.TryGetValue(FormValueHelper.CultureInvariantFieldName, out var invariantKeys) && invariantKeys.Count > 0) { _invariantValueKeys = new(invariantKeys, StringComparer.OrdinalIgnoreCase); } diff --git a/src/Mvc/Mvc.Core/test/ModelBinding/FormValueProviderTest.cs b/src/Mvc/Mvc.Core/test/ModelBinding/FormValueProviderTest.cs index abf0619f48cc..d025c4c96376 100644 --- a/src/Mvc/Mvc.Core/test/ModelBinding/FormValueProviderTest.cs +++ b/src/Mvc/Mvc.Core/test/ModelBinding/FormValueProviderTest.cs @@ -18,7 +18,7 @@ public void GetValue_ReturnsInvariantCulture_IfInvariantEntryExists() var currentCultureKey = "some"; var values = new Dictionary(BackingStore) { - { FormValueProvider.CultureInvariantFieldName, new(invariantCultureKey) }, + { FormValueHelper.CultureInvariantFieldName, new(invariantCultureKey) }, }; var valueProvider = GetEnumerableValueProvider(BindingSource.Query, values, culture); diff --git a/src/Mvc/Mvc.Core/test/ModelBinding/JQueryFormValueProviderTest.cs b/src/Mvc/Mvc.Core/test/ModelBinding/JQueryFormValueProviderTest.cs index 29d285500695..0add14a6dfc9 100644 --- a/src/Mvc/Mvc.Core/test/ModelBinding/JQueryFormValueProviderTest.cs +++ b/src/Mvc/Mvc.Core/test/ModelBinding/JQueryFormValueProviderTest.cs @@ -56,7 +56,7 @@ public void GetValue_ReturnsInvariantCulture_IfInvariantEntryExists() var currentCultureKey = "some"; var values = new Dictionary(BackingStore) { - { FormValueProvider.CultureInvariantFieldName, new(invariantCultureKey) }, + { FormValueHelper.CultureInvariantFieldName, new(invariantCultureKey) }, }; var valueProvider = GetEnumerableValueProvider(BindingSource.Query, values, culture); diff --git a/src/Mvc/Mvc.TagHelpers/src/InputTagHelper.cs b/src/Mvc/Mvc.TagHelpers/src/InputTagHelper.cs index 3e985f447290..2c975e7b9410 100644 --- a/src/Mvc/Mvc.TagHelpers/src/InputTagHelper.cs +++ b/src/Mvc/Mvc.TagHelpers/src/InputTagHelper.cs @@ -423,7 +423,7 @@ private TagBuilder GenerateTextBox( private static void GenerateInvariantCultureMetadata(string propertyName, TagHelperContent builder) => builder .AppendHtml(""); diff --git a/src/Mvc/Mvc.ViewFeatures/src/DefaultHtmlGenerator.cs b/src/Mvc/Mvc.ViewFeatures/src/DefaultHtmlGenerator.cs index caabe80c567e..f1ebb42a3d82 100644 --- a/src/Mvc/Mvc.ViewFeatures/src/DefaultHtmlGenerator.cs +++ b/src/Mvc/Mvc.ViewFeatures/src/DefaultHtmlGenerator.cs @@ -1351,13 +1351,12 @@ protected virtual TagBuilder GenerateInput( string.Equals(suppliedTypeString, "image", StringComparison.OrdinalIgnoreCase)) { // 'value' attribute is not needed for 'file' and 'image' input types. + break; } - else - { - var attributeValue = (string)GetModelStateValue(viewContext, fullName, typeof(string)); - attributeValue ??= useViewData ? EvalString(viewContext, expression, format) : valueParameter; - tagBuilder.MergeAttribute("value", attributeValue, replaceExisting: isExplicitValue); - } + + var attributeValue = (string)GetModelStateValue(viewContext, fullName, typeof(string)); + attributeValue ??= useViewData ? EvalString(viewContext, expression, format) : valueParameter; + tagBuilder.MergeAttribute("value", attributeValue, replaceExisting: isExplicitValue); break; }