-
Notifications
You must be signed in to change notification settings - Fork 10.4k
Navigation Exception: Introduce Clear Message #56644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 3 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
d8ba47b
Added NavigationException constructor with overload & NavigationRedir…
spdebeer d300f23
Updated NavigationException references to use NavigationRedirectHelper
spdebeer 610db50
Merge branch 'main' into navigation-exception-message
spdebeer 1d46c0d
Merge branch 'main' into navigation-exception-message
spdebeer 47797e2
Removed 2nd NavigationException Constructor, NavigationRedirectHelper…
spdebeer 6b667ba
Merge branch 'main' into navigation-exception-message
spdebeer 692618e
Merge branch 'main' into navigation-exception-message
spdebeer 44ca30e
Merge branch 'main' into navigation-exception-message
spdebeer 0bf32aa
Merge branch 'main' into navigation-exception-message
spdebeer a89a20a
Merge branch 'main' into navigation-exception-message
spdebeer 03dfcce
Updated Version
spdebeer 474fa26
Revert "Updated Version"
spdebeer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
// Licensed to the .NET Foundation under one or more agreements. | ||
// The .NET Foundation licenses this file to you under the MIT license. | ||
|
||
using System.Diagnostics.CodeAnalysis; | ||
|
||
namespace Microsoft.AspNetCore.Components; | ||
|
||
/// <summary> | ||
/// Helper class to throw a <see cref="NavigationException"/>. | ||
/// </summary> | ||
public static class NavigationRedirectHelper | ||
{ | ||
private const string RedirectExceptionMessage = | ||
"A navigation was initiated during static rendering. " + | ||
"This exception is not an error, but instead signals to the framework that a redirect should occur. " + | ||
"It should not be caught by application code."; | ||
|
||
/// <summary> | ||
/// Creates an absolute URI and throws a new <see cref="NavigationException"/>. | ||
/// </summary> | ||
|
||
[DoesNotReturn] | ||
public static void ThrowNavigationExceptionForRedirect(NavigationManager navigationManager, string uri) | ||
{ | ||
var absoluteUriString = navigationManager.ToAbsoluteUri(uri).AbsoluteUri; | ||
throw new NavigationException(absoluteUriString, RedirectExceptionMessage); | ||
} | ||
} | ||
spdebeer marked this conversation as resolved.
Show resolved
Hide resolved
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.