Skip to content

Commit ec990d5

Browse files
kripkenradekdoulik
authored andcommitted
JS Bindings: Use stringToUTF8OnStack instead of deprecated allocateUTF8OnStack (WebAssembly#6324)
This avoids a warning on recent Emscripten.
1 parent 557e4de commit ec990d5

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

CMakeLists.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -464,7 +464,7 @@ if(EMSCRIPTEN)
464464
target_link_libraries(binaryen_wasm "-sEXPORT_NAME=Binaryen")
465465
target_link_libraries(binaryen_wasm "-sNODERAWFS=0")
466466
target_link_libraries(binaryen_wasm "-sEXPORT_ES6")
467-
target_link_libraries(binaryen_wasm "-sEXPORTED_RUNTIME_METHODS=allocateUTF8OnStack,stringToAscii")
467+
target_link_libraries(binaryen_wasm "-sEXPORTED_RUNTIME_METHODS=stringToUTF8OnStack,stringToAscii")
468468
target_link_libraries(binaryen_wasm "-sEXPORTED_FUNCTIONS=_malloc,_free")
469469
target_link_libraries(binaryen_wasm "--post-js=${CMAKE_CURRENT_SOURCE_DIR}/src/js/binaryen.js-post.js")
470470
target_link_libraries(binaryen_wasm "-msign-ext")
@@ -502,7 +502,7 @@ if(EMSCRIPTEN)
502502
else()
503503
target_link_libraries(binaryen_js "-sEXPORT_ES6=1")
504504
endif()
505-
target_link_libraries(binaryen_js "-sEXPORTED_RUNTIME_METHODS=allocateUTF8OnStack,stringToAscii")
505+
target_link_libraries(binaryen_js "-sEXPORTED_RUNTIME_METHODS=stringToUTF8OnStack,stringToAscii")
506506
target_link_libraries(binaryen_js "-sEXPORTED_FUNCTIONS=_malloc,_free")
507507
target_link_libraries(binaryen_js "--post-js=${CMAKE_CURRENT_SOURCE_DIR}/src/js/binaryen.js-post.js")
508508
# js_of_ocaml needs a specified variable with special comment to provide the library to consumers

src/js/binaryen.js-post.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ function preserveStack(func) {
99
}
1010

1111
function strToStack(str) {
12-
return str ? allocateUTF8OnStack(str) : 0;
12+
return str ? stringToUTF8OnStack(str) : 0;
1313
}
1414

1515
function i32sToStack(i32s) {

0 commit comments

Comments
 (0)