Skip to content

PostpublishScript target shouldn't be there after migration #7088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
barrytang opened this issue Nov 4, 2016 · 4 comments
Closed

PostpublishScript target shouldn't be there after migration #7088

barrytang opened this issue Nov 4, 2016 · 4 comments
Assignees

Comments

@barrytang
Copy link

Steps to reproduce

  1. Create a xproj web project in Dev14
  2. Open it in Dev15

Expected behavior

PostpublishScript target not there

Actual behavior

  <Target Name="PostpublishScript" AfterTargets="Publish" Condition=" '$(IsCrossTargetingBuild)' != 'true' ">
    <Exec Command="dotnet publish-iis --publish-folder $(TargetDir) --framework $(TargetFrameworkIdentifier),Version=$(TargetFrameworkVersion)" />
  </Target>
@livarcocc
Copy link
Contributor

The right thing here is that we should not have a dontet publish-iis script anymore, since that tool does not exist in msbuild world.

@guardrex
Copy link
Contributor

guardrex commented Nov 17, 2016

that tool does not exist in msbuild world.

@livarcocc I also asked @natemcmaster over in aspnet/IISIntegration#299 (comment) before I saw this issue.

Are we just going back to a handmade web.config and something like ...

<Content Include="web.config">
  <CopyToPublishDirectory>PreserveNewest</CopyToPublishDirectory>
</Content>

... to get it into published output?

[EDIT] Answer: Microsoft.NET.Sdk.Web takes care of this now.

@livarcocc
Copy link
Contributor

@mlorbetske Can you answer @guardrex's question about web.config? Is this something that the Web.Sdk is handling?

@guardrex
Copy link
Contributor

guardrex commented Dec 1, 2016

@livarcocc Thanks ... I'm good. Vijay got me straight on that.

@msftgits msftgits transferred this issue from dotnet/cli Jan 31, 2020
@msftgits msftgits added this to the 1.0.0-preview4 milestone Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants