Skip to content

CLI should be buildable using 2.1.300 as stage0 in commits used in ProdCon 2.1.1 #9479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dagood opened this issue Jun 8, 2018 · 2 comments
Assignees
Milestone

Comments

@dagood
Copy link
Member

dagood commented Jun 8, 2018

Steps to reproduce

  1. Update the stage0 from 2.2.0-preview1-007799 to 2.1.300:
    https://github.com/dotnet/cli/blob/a8396b53e16ca5ab2098fe0f2e8b6dac1d435262/run-build.sh#L165
  2. Run ./build.sh. (I use Fedora 28.)

Expected behavior

Build completes without errors.

Actual behavior

Build fails, 15 errors--a few repeats of this:

"/home/dagood/git/cli/build.proj" (default target) (1) ->
"/home/dagood/git/cli/src/redist/redist.csproj" (Publish target) (2) ->
"/home/dagood/git/cli/build/BundledDotnetTools.proj" (default target) (12:5) ->
  /home/dagood/git/cli/build/templates/templates.csproj : error NU1202: Package dotnet-watch 2.1.0 is not compatible with netcoreapp2.1 (.NETCoreApp,Version=v2.1). Package dotnet-watch 2.1.0 supports: netcoreapp2.1 (.NETCoreApp,Version=v2.1) / any [/home/dagood/git/cli/build/BundledDotnetTools.proj]
  /home/dagood/git/cli/build/templates/templates.csproj : error NU1212: Invalid project-package combination for dotnet-watch 2.1.0. DotnetToolReference project style can only contain references of the DotnetTool type [/home/dagood/git/cli/build/BundledDotnetTools.proj]
  /home/dagood/git/cli/build/templates/templates.csproj : error NU1212: Invalid project-package combination for dotnet-watch 2.1.0. DotnetToolReference project style can only contain references of the DotnetTool type [/home/dagood/git/cli/build/BundledDotnetTools.proj]
Full error list
Build FAILED.

       "/home/dagood/git/cli/build.proj" (default target) (1) ->
       "/home/dagood/git/cli/src/redist/redist.csproj" (Publish target) (2) ->
       (CrossgenPublishDir target) ->
         CROSSGEN : warning : Method not found: 'Void Microsoft.DiaSymReader.ISymUnmanagedWriter8._VtblGap1_33()'. while resolving 0x60007b8 - Microsoft.DiaSymReader.ISymUnmanagedWriter8._VtblGap1_33. [/home/dagood/git/cli/src/redist/redist.csproj]


       "/home/dagood/git/cli/build.proj" (default target) (1) ->
       "/home/dagood/git/cli/src/redist/redist.csproj" (Publish target) (2) ->
         CROSSGEN : warning : Method not found: 'Void Microsoft.Cci.ISymUnmanagedWriter7._VtblGap1_33()'. while resolving 0x60004d1 - Microsoft.Cci.ISymUnmanagedWriter7._VtblGap1_33. [/home/dagood/git/cli/src/redist/redist.csproj]


       "/home/dagood/git/cli/build.proj" (default target) (1) ->
       "/home/dagood/git/cli/src/redist/redist.csproj" (Publish target) (2) ->
       "/home/dagood/git/cli/build/BundledDotnetTools.proj" (default target) (12) ->
       (EnsureDotnetToolsRestored target) ->
         /home/dagood/git/cli/build/templates/templates.csproj : error NU1202: Package dotnet-dev-certs 2.1.0 is not compatible with netcoreapp2.1 (.NETCoreApp,Version=v2.1). Package dotnet-dev-certs 2.1.0 supports: netcoreapp2.1 (.NETCoreApp,Version=v2.1) / any [/home/dagood/git/cli/build/BundledDotnetTools.proj]
         /home/dagood/git/cli/build/templates/templates.csproj : error NU1212: Invalid project-package combination for dotnet-dev-certs 2.1.0. DotnetToolReference project style can only contain references of the DotnetTool type [/home/dagood/git/cli/build/BundledDotnetTools.proj]
         /home/dagood/git/cli/build/templates/templates.csproj : error NU1212: Invalid project-package combination for dotnet-dev-certs 2.1.0. DotnetToolReference project style can only contain references of the DotnetTool type [/home/dagood/git/cli/build/BundledDotnetTools.proj]


       "/home/dagood/git/cli/build.proj" (default target) (1) ->
       "/home/dagood/git/cli/src/redist/redist.csproj" (Publish target) (2) ->
       "/home/dagood/git/cli/build/BundledDotnetTools.proj" (default target) (12:2) ->
         /home/dagood/git/cli/build/templates/templates.csproj : error NU1202: Package dotnet-ef 2.1.1-rtm-30818 is not compatible with netcoreapp2.1 (.NETCoreApp,Version=v2.1). Package dotnet-ef 2.1.1-rtm-30818 supports: netcoreapp2.1 (.NETCoreApp,Version=v2.1) / any [/home/dagood/git/cli/build/BundledDotnetTools.proj]
         /home/dagood/git/cli/build/templates/templates.csproj : error NU1212: Invalid project-package combination for dotnet-ef 2.1.1-rtm-30818. DotnetToolReference project style can only contain references of the DotnetTool type [/home/dagood/git/cli/build/BundledDotnetTools.proj]
         /home/dagood/git/cli/build/templates/templates.csproj : error NU1212: Invalid project-package combination for dotnet-ef 2.1.1-rtm-30818. DotnetToolReference project style can only contain references of the DotnetTool type [/home/dagood/git/cli/build/BundledDotnetTools.proj]


       "/home/dagood/git/cli/build.proj" (default target) (1) ->
       "/home/dagood/git/cli/src/redist/redist.csproj" (Publish target) (2) ->
       "/home/dagood/git/cli/build/BundledDotnetTools.proj" (default target) (12:3) ->
         /home/dagood/git/cli/build/templates/templates.csproj : error NU1202: Package dotnet-sql-cache 2.1.0 is not compatible with netcoreapp2.1 (.NETCoreApp,Version=v2.1). Package dotnet-sql-cache 2.1.0 supports: netcoreapp2.1 (.NETCoreApp,Version=v2.1) / any [/home/dagood/git/cli/build/BundledDotnetTools.proj]
         /home/dagood/git/cli/build/templates/templates.csproj : error NU1212: Invalid project-package combination for dotnet-sql-cache 2.1.0. DotnetToolReference project style can only contain references of the DotnetTool type [/home/dagood/git/cli/build/BundledDotnetTools.proj]
         /home/dagood/git/cli/build/templates/templates.csproj : error NU1212: Invalid project-package combination for dotnet-sql-cache 2.1.0. DotnetToolReference project style can only contain references of the DotnetTool type [/home/dagood/git/cli/build/BundledDotnetTools.proj]


       "/home/dagood/git/cli/build.proj" (default target) (1) ->
       "/home/dagood/git/cli/src/redist/redist.csproj" (Publish target) (2) ->
       "/home/dagood/git/cli/build/BundledDotnetTools.proj" (default target) (12:4) ->
         /home/dagood/git/cli/build/templates/templates.csproj : error NU1202: Package dotnet-user-secrets 2.1.0 is not compatible with netcoreapp2.1 (.NETCoreApp,Version=v2.1). Package dotnet-user-secrets 2.1.0 supports: netcoreapp2.1 (.NETCoreApp,Version=v2.1) / any [/home/dagood/git/cli/build/BundledDotnetTools.proj]
         /home/dagood/git/cli/build/templates/templates.csproj : error NU1212: Invalid project-package combination for dotnet-user-secrets 2.1.0. DotnetToolReference project style can only contain references of the DotnetTool type [/home/dagood/git/cli/build/BundledDotnetTools.proj]
         /home/dagood/git/cli/build/templates/templates.csproj : error NU1212: Invalid project-package combination for dotnet-user-secrets 2.1.0. DotnetToolReference project style can only contain references of the DotnetTool type [/home/dagood/git/cli/build/BundledDotnetTools.proj]


       "/home/dagood/git/cli/build.proj" (default target) (1) ->
       "/home/dagood/git/cli/src/redist/redist.csproj" (Publish target) (2) ->
       "/home/dagood/git/cli/build/BundledDotnetTools.proj" (default target) (12:5) ->
         /home/dagood/git/cli/build/templates/templates.csproj : error NU1202: Package dotnet-watch 2.1.0 is not compatible with netcoreapp2.1 (.NETCoreApp,Version=v2.1). Package dotnet-watch 2.1.0 supports: netcoreapp2.1 (.NETCoreApp,Version=v2.1) / any [/home/dagood/git/cli/build/BundledDotnetTools.proj]
         /home/dagood/git/cli/build/templates/templates.csproj : error NU1212: Invalid project-package combination for dotnet-watch 2.1.0. DotnetToolReference project style can only contain references of the DotnetTool type [/home/dagood/git/cli/build/BundledDotnetTools.proj]
         /home/dagood/git/cli/build/templates/templates.csproj : error NU1212: Invalid project-package combination for dotnet-watch 2.1.0. DotnetToolReference project style can only contain references of the DotnetTool type [/home/dagood/git/cli/build/BundledDotnetTools.proj]

    2 Warning(s)
    15 Error(s)

We will be using CLI 2.1.300 to build 2.1.1 source-build. The stage0 doesn't necessarily have to be changed to 2.1.300 in this repo, but the commits that 2.1.1 ProdCon picks up do need to be buildable using a 2.1.300 stage0 to work in source-build.

When building 2.1.0 source-build, we hit a different NU5104 error trying to use a 2.1.300 rc stage0: dotnet/source-build#569. This might show up after resolving the NU1202/NU1212s above.

/cc @livarcocc @dseefeld @dleeapho

@livarcocc
Copy link
Contributor

I believe I have a fix for this already. Will have a PR out in a bit.

@livarcocc livarcocc self-assigned this Jun 8, 2018
@dagood
Copy link
Member Author

dagood commented Jun 11, 2018

Sweet, thanks Livar!

@msftgits msftgits transferred this issue from dotnet/cli Jan 31, 2020
@msftgits msftgits added this to the 2.1.3xx milestone Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants