Skip to content
This repository was archived by the owner on Jul 12, 2022. It is now read-only.

v1.0.0-alpha release doesn't contain System.Collections.Immutable #45

Closed
davkean opened this issue Jan 29, 2015 · 6 comments
Closed

v1.0.0-alpha release doesn't contain System.Collections.Immutable #45

davkean opened this issue Jan 29, 2015 · 6 comments
Assignees

Comments

@davkean
Copy link
Member

davkean commented Jan 29, 2015

The release I downloaded from https://github.com/dotnet/codeformatter/releases/tag/v1.0.0-alpha, doesn't contain System.Collections.Immutable and hence crashes.

@jaredpar
Copy link
Member

Need to update the release anyways. I will add this collection in.

@jaredpar jaredpar self-assigned this Jan 29, 2015
@davkean
Copy link
Member Author

davkean commented Jan 29, 2015

It looks like you are relying on it being in the GAC, but VS owns that version and it might not match the version that you use.

@jaredpar
Copy link
Member

@davkean no one owns the GAC. Everyone is equally free to destroy it ;)

@jaredpar
Copy link
Member

jaredpar commented Feb 6, 2015

@davkean turns out we are not relying on it to be in the GAC. Build expected it to be copy local like all of our other references. It just turns out that something else installed it into the GAC so naturally MSBuild decided to stop putting it in the output. Because what's installed in the GAC should definitely be changing what my build outputs are.

@davkean
Copy link
Member Author

davkean commented Feb 12, 2015

Side note, we've got a bug around this against the MSBuild team.

@jaredpar
Copy link
Member

@davkean

Is it something they indicated they will fix? The behavior is actually really infectious and ends up affecting how Visual Studio projects generate reference entries in files.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants