Skip to content

GCStress: instrumented instructions only force a GC once #10189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
BruceForstall opened this issue Apr 18, 2018 · 2 comments
Closed

GCStress: instrumented instructions only force a GC once #10189

BruceForstall opened this issue Apr 18, 2018 · 2 comments
Labels
area-VM-coreclr backlog-cleanup-candidate An inactive issue that has been marked for automated closure. GCStress no-recent-activity
Milestone

Comments

@BruceForstall
Copy link
Contributor

One possible limitation of GCStress today is that each instruction is instrumented and stressed only once. After GC is run on an instrumented instruction, that instrumented instruction is replaced by its original instruction, so it never triggers a GC again. This means if a hole exists at an instruction, but isn't triggered by the first run of the instruction, we will miss it. This was potentially the case with the JIT creating illegal byrefs, fixed by dotnet/coreclr#17524.

Possibly introduce a (super slow) mode where we don't replace the instrumented instructions by their original instructions, or not immediately. Or, periodically re-instrument functions.

@msftgits msftgits transferred this issue from dotnet/coreclr Jan 31, 2020
@msftgits msftgits added this to the Future milestone Jan 31, 2020
@ghost
Copy link

ghost commented Oct 27, 2022

Due to lack of recent activity, this issue has been marked as a candidate for backlog cleanup. It will be closed if no further activity occurs within 14 more days. Any new comment (by anyone, not necessarily the author) will undo this process.

This process is part of our issue cleanup automation.

@ghost ghost added backlog-cleanup-candidate An inactive issue that has been marked for automated closure. no-recent-activity labels Oct 27, 2022
@ghost
Copy link

ghost commented Nov 10, 2022

This issue will now be closed since it had been marked no-recent-activity but received no further activity in the past 14 days. It is still possible to reopen or comment on the issue, but please note that the issue will be locked if it remains inactive for another 30 days.

@ghost ghost closed this as completed Nov 10, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Dec 10, 2022
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-VM-coreclr backlog-cleanup-candidate An inactive issue that has been marked for automated closure. GCStress no-recent-activity
Projects
None yet
Development

No branches or pull requests

2 participants