Make ConnectHelper.ConnectAsync return ValueTask<Stream> (#24244)

stephentoub · web-flow · commit c45e6b3d58af · 2017-09-26T10:30:44.000-04:00
Minor optimization via playing a bit better perf-wise with changes being made in coreclr.
diff --git a/src/System.Net.Http/src/System/Net/Http/Managed/ConnectHelper.cs b/src/System.Net.Http/src/System/Net/Http/Managed/ConnectHelper.cs
@@ -2,14 +2,15 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for more information.
 
+using System.IO;
 using System.Net.Sockets;
 using System.Threading.Tasks;
 
 namespace System.Net.Http
 {
     internal static class ConnectHelper
     {
-        public static async ValueTask<NetworkStream> ConnectAsync(string host, int port)
+        public static async ValueTask<Stream> ConnectAsync(string host, int port)
         {
             var socket = new Socket(SocketType.Stream, ProtocolType.Tcp) { NoDelay = true };
             try

Original file line number	Diff line number	Diff line change
`@@ -2,14 +2,15 @@`
`2`	`2`	`// The .NET Foundation licenses this file to you under the MIT license.`
`3`	`3`	`// See the LICENSE file in the project root for more information.`
`4`	`4`
	`5`	`+using System.IO;`
`5`	`6`	`using System.Net.Sockets;`
`6`	`7`	`using System.Threading.Tasks;`
`7`	`8`
`8`	`9`	`namespace System.Net.Http`
`9`	`10`	`{`
`10`	`11`	`internal static class ConnectHelper`
`11`	`12`	`{`
`12`		`- public static async ValueTask<NetworkStream> ConnectAsync(string host, int port)`
	`13`	`+ public static async ValueTask<Stream> ConnectAsync(string host, int port)`
`13`	`14`	`{`
`14`	`15`	`var socket = new Socket(SocketType.Stream, ProtocolType.Tcp) { NoDelay = true };`
`15`	`16`	`try`