Skip to content

Remove IDisposable from IDuplexPipe #25050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
davidfowl opened this issue Feb 15, 2018 · 1 comment
Closed

Remove IDisposable from IDuplexPipe #25050

davidfowl opened this issue Feb 15, 2018 · 1 comment
Labels
area-System.IO.Pipelines
Milestone
2.1.0

Comments

@davidfowl
Copy link
Member

The way you close a pipe is by completing both sides, and in the case of an IDuplexPipe, that's the input and output. There should be no dispose on the interface.

/cc @pakrym
@davidfowl
Copy link
Member Author

This is already done!

@msftgits msftgits transferred this issue from dotnet/corefx Jan 31, 2020
@msftgits msftgits added this to the 2.1.0 milestone Jan 31, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-System.IO.Pipelines
Projects
None yet
Milestone
2.1.0
Development

No branches or pull requests
2 participants
@davidfowl @msftgits