Skip to content
This repository was archived by the owner on Aug 2, 2023. It is now read-only.

Re-write tests to avoid using Span in async functions #1404

Closed
ahsonkhan opened this issue Mar 30, 2017 · 1 comment
Closed

Re-write tests to avoid using Span in async functions #1404

ahsonkhan opened this issue Mar 30, 2017 · 1 comment
Assignees
Labels
Milestone

Comments

@ahsonkhan
Copy link
Contributor

From #1401

The issue is caused by the fact that the async function is creating a closure around the local span to capture them for re-entering the function when an await returns. This only happens if the span is used on both sides of an await, either directly or indirectly.

We need some documented patterns on things that work and don't work. However, you should be able to re-write these tests in a way that will allow them to work correctly without the error.

@ahsonkhan
Copy link
Contributor Author

Fixed in #1432

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants