Remove DbContextFactoryOptions

Part of #8164

Author: bricelam

src/EFCore.Design/Design/Internal/DbContextOperations.cs

@@ -110,7 +110,7 @@ where i.GetTypeInfo().IsGenericType
                     contexts.Add(
                         context,
                         () => ((IDbContextFactory<DbContext>)Activator.CreateInstance(factory.AsType())).Create(
-                            CreateFactoryOptions()));
+                            Array.Empty<string>()));
                 }
             }
 
@@ -181,7 +181,7 @@ private Func<DbContext> FindContextFactory(Type contextType)
             }
 
             return () => ((IDbContextFactory<DbContext>)Activator.CreateInstance(factory)).Create(
-                CreateFactoryOptions());
+                Array.Empty<string>());
         }
 
         private KeyValuePair<Type, Func<DbContext>> FindContextType(string name)
@@ -249,14 +249,5 @@ private static IDictionary<Type, Func<DbContext>> FilterTypes(
                          || string.Equals(t.Key.AssemblyQualifiedName, name, comparisonType))
                 .ToDictionary(t => t.Key, t => t.Value);
         }
-
-        private DbContextFactoryOptions CreateFactoryOptions()
-            => new DbContextFactoryOptions
-            {
-                ApplicationBasePath = AppContext.BaseDirectory,
-                ContentRootPath = Directory.GetCurrentDirectory(),
-                EnvironmentName = Environment.GetEnvironmentVariable("ASPNETCORE_ENVIRONMENT")
-                    ?? "Development"
-            };
     }
 }

src/EFCore/Infrastructure/DbContextFactoryOptions.cs

@@ -10,7 +10,7 @@ namespace Microsoft.EntityFrameworkCore.Infrastructure
     ///     design-time services for context types that do not have a public default constructor. At design-time,
     ///     derived <see cref="DbContext" /> instances can be created in order to enable specific design-time
     ///     experiences such as Migrations. Design-time services will automatically discover implementations of
-    ///     this interface that are in the same assembly as the derived context.
+    ///     this interface that are in the startup assembly or the same assembly as the derived context.
     /// </summary>
     /// <typeparam name="TContext">The type of the context.</typeparam>
     public interface IDbContextFactory<out TContext>
@@ -19,8 +19,8 @@ public interface IDbContextFactory<out TContext>
         /// <summary>
         ///     Creates a new instance of a derived context.
         /// </summary>
-        /// <param name="options"> Information about the environment an application is running in. </param>
+        /// <param name="args"> Arguments provided by the design-time service. </param>
         /// <returns> An instance of <typeparamref name="TContext" />. </returns>
-        TContext Create([NotNull] DbContextFactoryOptions options);
+        TContext Create([NotNull] string[] args);
     }
 }

src/EFCore/Infrastructure/IDbContextFactory.cs

@@ -504,5 +504,19 @@
     "TypeId": "public abstract class Microsoft.EntityFrameworkCore.Query.EntityQueryModelVisitor : Remotion.Linq.QueryModelVisitorBase",
     "MemberId": "public static System.Boolean IsPropertyMethod(System.Reflection.MethodInfo methodInfo)",
     "Kind": "Removal"
+  },
+  {
+    "TypeId": "public class Microsoft.EntityFrameworkCore.Infrastructure.DbContextFactoryOptions",
+    "Kind": "Removal"
+  },
+  {
+    "TypeId": "public interface Microsoft.EntityFrameworkCore.Infrastructure.IDbContextFactory<T0> where T0 : Microsoft.EntityFrameworkCore.DbContext",
+    "MemberId": "T0 Create(Microsoft.EntityFrameworkCore.Infrastructure.DbContextFactoryOptions options)",
+    "Kind": "Removal"
+  },
+  {
+    "TypeId": "public interface Microsoft.EntityFrameworkCore.Infrastructure.IDbContextFactory<T0> where T0 : Microsoft.EntityFrameworkCore.DbContext",
+    "MemberId": "T0 Create(System.String[] args)",
+    "Kind": "Addition"
   }
 ]

src/EFCore/breakingchanges.netcore.json

@@ -504,5 +504,19 @@
     "TypeId": "public abstract class Microsoft.EntityFrameworkCore.Query.EntityQueryModelVisitor : Remotion.Linq.QueryModelVisitorBase",
     "MemberId": "public static System.Boolean IsPropertyMethod(System.Reflection.MethodInfo methodInfo)",
     "Kind": "Removal"
-  }  
+  },
+  {
+    "TypeId": "public class Microsoft.EntityFrameworkCore.Infrastructure.DbContextFactoryOptions",
+    "Kind": "Removal"
+  },
+  {
+    "TypeId": "public interface Microsoft.EntityFrameworkCore.Infrastructure.IDbContextFactory<T0> where T0 : Microsoft.EntityFrameworkCore.DbContext",
+    "MemberId": "T0 Create(Microsoft.EntityFrameworkCore.Infrastructure.DbContextFactoryOptions options)",
+    "Kind": "Removal"
+  },
+  {
+    "TypeId": "public interface Microsoft.EntityFrameworkCore.Infrastructure.IDbContextFactory<T0> where T0 : Microsoft.EntityFrameworkCore.DbContext",
+    "MemberId": "T0 Create(System.String[] args)",
+    "Kind": "Addition"
+  }
 ]