Updates to ILogger, see aspnet/Logging#3

sonjakhan · sonjakhan · commit 4098d5783341 · 2014-10-07T13:42:05.000-07:00
diff --git a/src/EntityFramework.Migrations/Infrastructure/MigratorLoggerExtensions.cs b/src/EntityFramework.Migrations/Infrastructure/MigratorLoggerExtensions.cs
@@ -13,15 +13,15 @@ public static void CreatingHistoryTable([NotNull] this ILogger logger)
         {
             Check.NotNull(logger, "logger");
 
-            logger.WriteCore(TraceType.Information, MigratorLoggerEventIds.CreatingHistoryTable, null, null,
+            logger.Write(TraceType.Information, MigratorLoggerEventIds.CreatingHistoryTable, null, null,
                 (_, __) => Strings.MigratorLoggerCreatingHistoryTable);
         }
 
         public static void DroppingHistoryTable([NotNull] this ILogger logger)
         {
             Check.NotNull(logger, "logger");
 
-            logger.WriteCore(TraceType.Information, MigratorLoggerEventIds.DroppingHistoryTable, null, null,
+            logger.Write(TraceType.Information, MigratorLoggerEventIds.DroppingHistoryTable, null, null,
                 (_, __) => Strings.MigratorLoggerDroppingHistoryTable);
         }
 
@@ -30,7 +30,7 @@ public static void ApplyingMigration([NotNull] this ILogger logger, [NotNull] st
             Check.NotNull(logger, "logger");
             Check.NotEmpty(migrationId, "migrationId");
 
-            logger.WriteCore(TraceType.Information, MigratorLoggerEventIds.ApplyingMigration, migrationId, null,
+            logger.Write(TraceType.Information, MigratorLoggerEventIds.ApplyingMigration, migrationId, null,
                 (o, _) => Strings.FormatMigratorLoggerApplyingMigration(o));
         }
 
@@ -39,7 +39,7 @@ public static void RevertingMigration([NotNull] this ILogger logger, [NotNull] s
             Check.NotNull(logger, "logger");
             Check.NotEmpty(migrationId, "migrationId");
 
-            logger.WriteCore(TraceType.Information, MigratorLoggerEventIds.RevertingMigration, migrationId, null,
+            logger.Write(TraceType.Information, MigratorLoggerEventIds.RevertingMigration, migrationId, null,
                 (o, _) => Strings.FormatMigratorLoggerRevertingMigration(o));
         }
     }
diff --git a/src/EntityFramework.Relational/RelationalLoggerExtensions.cs b/src/EntityFramework.Relational/RelationalLoggerExtensions.cs
@@ -17,15 +17,15 @@ public static void WriteSql([NotNull] this ILogger logger, [NotNull] string sql)
             Check.NotNull(logger, "logger");
             Check.NotEmpty(sql, "sql");
 
-            logger.WriteCore(TraceType.Verbose, RelationalLoggingEventIds.Sql, sql, null, (o, _) => (string)o);
+            logger.Write(TraceType.Verbose, RelationalLoggingEventIds.Sql, sql, null, (o, _) => (string)o);
         }
 
         public static void CreatingDatabase([NotNull] this ILogger logger, [NotNull] string databaseName)
         {
             Check.NotNull(logger, "logger");
             Check.NotEmpty(databaseName, "databaseName");
 
-            logger.WriteCore(TraceType.Information, RelationalLoggingEventIds.CreatingDatabase, databaseName, null,
+            logger.Write(TraceType.Information, RelationalLoggingEventIds.CreatingDatabase, databaseName, null,
                 (o, _) => Strings.FormatRelationalLoggerCreatingDatabase(databaseName));
         }
 
@@ -34,7 +34,7 @@ public static void OpeningConnection([NotNull] this ILogger logger, [NotNull] st
             Check.NotNull(logger, "logger");
             Check.NotEmpty(connectionString, "connectionString");
 
-            logger.WriteCore(TraceType.Verbose, RelationalLoggingEventIds.OpeningConnection, connectionString, null,
+            logger.Write(TraceType.Verbose, RelationalLoggingEventIds.OpeningConnection, connectionString, null,
                 (o, _) => Strings.FormatRelationalLoggerOpeningConnection(o));
         }
 
@@ -43,31 +43,31 @@ public static void ClosingConnection([NotNull] this ILogger logger, [NotNull] st
             Check.NotNull(logger, "logger");
             Check.NotEmpty(connectionString, "connectionString");
 
-            logger.WriteCore(TraceType.Verbose, RelationalLoggingEventIds.ClosingConnection, connectionString, null,
+            logger.Write(TraceType.Verbose, RelationalLoggingEventIds.ClosingConnection, connectionString, null,
                 (o, _) => Strings.FormatRelationalLoggerClosingConnection(o));
         }
 
         public static void BeginningTransaction([NotNull] this ILogger logger, IsolationLevel isolationLevel)
         {
             Check.NotNull(logger, "logger");
 
-            logger.WriteCore(TraceType.Verbose, RelationalLoggingEventIds.BeginningTransaction, isolationLevel.ToString("G"), null,
+            logger.Write(TraceType.Verbose, RelationalLoggingEventIds.BeginningTransaction, isolationLevel.ToString("G"), null,
                 (o, _) => Strings.FormatRelationalLoggerBeginningTransaction(o));
         }
 
         public static void CommittingTransaction([NotNull] this ILogger logger)
         {
             Check.NotNull(logger, "logger");
 
-            logger.WriteCore(TraceType.Verbose, RelationalLoggingEventIds.CommittingTransaction, null, null,
+            logger.Write(TraceType.Verbose, RelationalLoggingEventIds.CommittingTransaction, null, null,
                 (_, __) => Strings.RelationalLoggerCommittingTransaction);
         }
 
         public static void RollingbackTransaction([NotNull] this ILogger logger)
         {
             Check.NotNull(logger, "logger");
 
-            logger.WriteCore(TraceType.Verbose, RelationalLoggingEventIds.RollingbackTransaction, null, null,
+            logger.Write(TraceType.Verbose, RelationalLoggingEventIds.RollingbackTransaction, null, null,
                 (_, __) => Strings.RelationalLoggerRollingbackTransaction);
         }
     }
diff --git a/src/EntityFramework/DbContext.cs b/src/EntityFramework/DbContext.cs
@@ -132,7 +132,7 @@ public virtual int SaveChanges()
             }
             catch (Exception ex)
             {
-                _logger.Value.WriteCore(
+                _logger.Value.Write(
                     TraceType.Error,
                     0,
                     new DataStoreErrorLogState(GetType()),
@@ -157,7 +157,7 @@ public virtual int SaveChanges()
             }
             catch (Exception ex)
             {
-                _logger.Value.WriteCore(
+                _logger.Value.Write(
                     TraceType.Error, 
                     0, 
                     new DataStoreErrorLogState(GetType()), 
diff --git a/src/EntityFramework/Query/EntityQueryExecutor.cs b/src/EntityFramework/Query/EntityQueryExecutor.cs
@@ -194,7 +194,7 @@ public bool MoveNext()
                     }
                     catch (Exception ex)
                     {
-                        _logger.Value.WriteCore(
+                        _logger.Value.Write(
                             TraceType.Error,
                             0,
                             new DataStoreErrorLogState(_context.GetType()),
@@ -262,7 +262,7 @@ public async Task<bool> MoveNext(CancellationToken cancellationToken)
                     }
                     catch (Exception ex)
                     {
-                        _logger.Value.WriteCore(
+                        _logger.Value.Write(
                            TraceType.Error,
                            0,
                            new DataStoreErrorLogState(_context.GetType()),
diff --git a/src/EntityFramework/Services/NullLoggerFactory.cs b/src/EntityFramework/Services/NullLoggerFactory.cs
@@ -26,8 +26,13 @@ private NullLogger()
         {
         }
 
-        public bool WriteCore(
+        public void Write(
             TraceType eventType, int eventId, object state, Exception exception, Func<object, Exception, string> formatter)
+        {
+            return;
+        }
+
+        public bool IsEnabled(TraceType eventType)
         {
             return false;
         }
diff --git a/src/Microsoft.AspNet.Diagnostics.Entity/DataStoreErrorLogger.cs b/src/Microsoft.AspNet.Diagnostics.Entity/DataStoreErrorLogger.cs
@@ -48,14 +48,17 @@ public virtual void StartLoggingForCurrentCallContext()
 #endif
         }
 
-        public virtual bool WriteCore(TraceType eventType, int eventId, [CanBeNull] object state, [CanBeNull] Exception exception, [CanBeNull] Func<object, Exception, string> formatter)
+        public virtual void Write(TraceType eventType, int eventId, [CanBeNull] object state, [CanBeNull] Exception exception, [CanBeNull] Func<object, Exception, string> formatter)
         {
             var errorState = state as DataStoreErrorLogState;
             if (errorState != null && exception != null && LastError != null)
             {
                 LastError.SetError(errorState.ContextType, exception);
             }
+        }
 
+        public virtual bool IsEnabled(TraceType eventType)
+        {
             return true;
         }
 
diff --git a/test/EntityFramework.FunctionalTests/DataStoreErrorLogStateTest.cs b/test/EntityFramework.FunctionalTests/DataStoreErrorLogStateTest.cs
@@ -171,7 +171,7 @@ public IDisposable BeginScope(object state)
                     return NullScope.Instance;
                 }
 
-                public bool WriteCore(TraceType eventType, int eventId, object state, Exception exception, Func<object, Exception, string> formatter)
+                public void Write(TraceType eventType, int eventId, object state, Exception exception, Func<object, Exception, string> formatter)
                 {
                     var error = state as DataStoreErrorLogState;
                     if (error != null)
@@ -180,7 +180,10 @@ public bool WriteCore(TraceType eventType, int eventId, object state, Exception
                         LastDataStoreErrorException = exception;
                         LastDataStoreErrorFormatter = formatter;
                     }
+                }
 
+                public bool IsEnabled(TraceType eventType)
+                {
                     return true;
                 }
 
diff --git a/test/EntityFramework.FunctionalTests/TestFileLogger.cs b/test/EntityFramework.FunctionalTests/TestFileLogger.cs
@@ -41,7 +41,7 @@ var logDirectory
             _logFilePath = Path.Combine(logDirectory, fileName);
         }
 
-        public bool WriteCore(
+        public void Write(
             TraceType eventType, int eventId, object state, Exception exception, Func<object, Exception, string> formatter)
         {
             if (formatter != null)
@@ -56,7 +56,10 @@ public bool WriteCore(
                     }
                 }
             }
+        }
 
+        public bool IsEnabled(TraceType eventType)
+        {
             return true;
         }
 
diff --git a/test/EntityFramework.InMemory.Tests/InMemoryDataStoreTest.cs b/test/EntityFramework.InMemory.Tests/InMemoryDataStoreTest.cs
@@ -142,7 +142,7 @@ public async Task Should_log_writes()
             await inMemoryDataStore.SaveChangesAsync(new[] { entityEntry });
 
             mockLogger.Verify(
-                l => l.WriteCore(
+                l => l.Write(
                     TraceType.Information,
                     0,
                     It.IsAny<string>(),
diff --git a/test/EntityFramework.Migrations.Tests/Infrastructure/MigratorTest.cs b/test/EntityFramework.Migrations.Tests/Infrastructure/MigratorTest.cs
@@ -1459,15 +1459,18 @@ public TestLogger(string name, StringBuilder builder)
                 _builder = builder;
             }
 
-            public bool WriteCore(TraceType eventType, int eventId, object state, Exception exception, Func<object, Exception, string> formatter)
+            public void Write(TraceType eventType, int eventId, object state, Exception exception, Func<object, Exception, string> formatter)
             {
                 _builder
                     .Append(_name)
                     .Append(" ")
                     .Append(eventType.ToString("G"))
                     .Append(" ")
                     .AppendLine(formatter(state, exception));
+            }
 
+            public bool IsEnabled(TraceType eventType)
+            {
                 return true;
             }
 
diff --git a/test/EntityFramework.Relational.FunctionalTests/TestSqlLoggerFactory.cs b/test/EntityFramework.Relational.FunctionalTests/TestSqlLoggerFactory.cs
@@ -60,7 +60,7 @@ public class SqlLogger : ILogger
 
             private CancellationTokenSource _cancellationTokenSource;
 
-            public bool WriteCore(
+            public void Write(
                 TraceType eventType,
                 int eventId,
                 object state,
@@ -79,7 +79,10 @@ public bool WriteCore(
 
                     SqlStatements.Add(sql);
                 }
+            }
 
+            public bool IsEnabled(TraceType eventType)
+            {
                 return true;
             }
 
diff --git a/test/Microsoft.AspNet.Diagnostics.Entity.FunctionalTests/Helpers/TestLoggerProvider.cs b/test/Microsoft.AspNet.Diagnostics.Entity.FunctionalTests/Helpers/TestLoggerProvider.cs
@@ -30,9 +30,13 @@ public IEnumerable<string> Messages
                 get { return _messages; }
             }
 
-            public bool WriteCore(TraceType eventType, int eventId, object state, Exception exception, Func<object, Exception, string> formatter)
+            public void Write(TraceType eventType, int eventId, object state, Exception exception, Func<object, Exception, string> formatter)
             {
                 _messages.Add(formatter(state, exception));
+            }
+            
+            public bool IsEnabled(TraceType eventType)
+            {
                 return true;
             }
 

Original file line number	Diff line number	Diff line change
`@@ -13,15 +13,15 @@ public static void CreatingHistoryTable([NotNull] this ILogger logger)`
`13`	`13`	`{`
`14`	`14`	`Check.NotNull(logger, "logger");`
`15`	`15`
`16`		`- logger.WriteCore(TraceType.Information, MigratorLoggerEventIds.CreatingHistoryTable, null, null,`
	`16`	`+ logger.Write(TraceType.Information, MigratorLoggerEventIds.CreatingHistoryTable, null, null,`
`17`	`17`	`(_, __) => Strings.MigratorLoggerCreatingHistoryTable);`
`18`	`18`	`}`
`19`	`19`
`20`	`20`	`public static void DroppingHistoryTable([NotNull] this ILogger logger)`
`21`	`21`	`{`
`22`	`22`	`Check.NotNull(logger, "logger");`
`23`	`23`
`24`		`- logger.WriteCore(TraceType.Information, MigratorLoggerEventIds.DroppingHistoryTable, null, null,`
	`24`	`+ logger.Write(TraceType.Information, MigratorLoggerEventIds.DroppingHistoryTable, null, null,`
`25`	`25`	`(_, __) => Strings.MigratorLoggerDroppingHistoryTable);`
`26`	`26`	`}`
`27`	`27`
`@@ -30,7 +30,7 @@ public static void ApplyingMigration([NotNull] this ILogger logger, [NotNull] st`
`30`	`30`	`Check.NotNull(logger, "logger");`
`31`	`31`	`Check.NotEmpty(migrationId, "migrationId");`
`32`	`32`
`33`		`- logger.WriteCore(TraceType.Information, MigratorLoggerEventIds.ApplyingMigration, migrationId, null,`
	`33`	`+ logger.Write(TraceType.Information, MigratorLoggerEventIds.ApplyingMigration, migrationId, null,`
`34`	`34`	`(o, _) => Strings.FormatMigratorLoggerApplyingMigration(o));`
`35`	`35`	`}`
`36`	`36`
`@@ -39,7 +39,7 @@ public static void RevertingMigration([NotNull] this ILogger logger, [NotNull] s`
`39`	`39`	`Check.NotNull(logger, "logger");`
`40`	`40`	`Check.NotEmpty(migrationId, "migrationId");`
`41`	`41`
`42`		`- logger.WriteCore(TraceType.Information, MigratorLoggerEventIds.RevertingMigration, migrationId, null,`
	`42`	`+ logger.Write(TraceType.Information, MigratorLoggerEventIds.RevertingMigration, migrationId, null,`
`43`	`43`	`(o, _) => Strings.FormatMigratorLoggerRevertingMigration(o));`
`44`	`44`	`}`
`45`	`45`	`}`
Original file line number	Diff line number	Diff line change
`@@ -17,15 +17,15 @@ public static void WriteSql([NotNull] this ILogger logger, [NotNull] string sql)`
`17`	`17`	`Check.NotNull(logger, "logger");`
`18`	`18`	`Check.NotEmpty(sql, "sql");`
`19`	`19`
`20`		`- logger.WriteCore(TraceType.Verbose, RelationalLoggingEventIds.Sql, sql, null, (o, _) => (string)o);`
	`20`	`+ logger.Write(TraceType.Verbose, RelationalLoggingEventIds.Sql, sql, null, (o, _) => (string)o);`
`21`	`21`	`}`
`22`	`22`
`23`	`23`	`public static void CreatingDatabase([NotNull] this ILogger logger, [NotNull] string databaseName)`
`24`	`24`	`{`
`25`	`25`	`Check.NotNull(logger, "logger");`
`26`	`26`	`Check.NotEmpty(databaseName, "databaseName");`
`27`	`27`
`28`		`- logger.WriteCore(TraceType.Information, RelationalLoggingEventIds.CreatingDatabase, databaseName, null,`
	`28`	`+ logger.Write(TraceType.Information, RelationalLoggingEventIds.CreatingDatabase, databaseName, null,`
`29`	`29`	`(o, _) => Strings.FormatRelationalLoggerCreatingDatabase(databaseName));`
`30`	`30`	`}`
`31`	`31`
`@@ -34,7 +34,7 @@ public static void OpeningConnection([NotNull] this ILogger logger, [NotNull] st`
`34`	`34`	`Check.NotNull(logger, "logger");`
`35`	`35`	`Check.NotEmpty(connectionString, "connectionString");`
`36`	`36`
`37`		`- logger.WriteCore(TraceType.Verbose, RelationalLoggingEventIds.OpeningConnection, connectionString, null,`
	`37`	`+ logger.Write(TraceType.Verbose, RelationalLoggingEventIds.OpeningConnection, connectionString, null,`
`38`	`38`	`(o, _) => Strings.FormatRelationalLoggerOpeningConnection(o));`
`39`	`39`	`}`
`40`	`40`
`@@ -43,31 +43,31 @@ public static void ClosingConnection([NotNull] this ILogger logger, [NotNull] st`
`43`	`43`	`Check.NotNull(logger, "logger");`
`44`	`44`	`Check.NotEmpty(connectionString, "connectionString");`
`45`	`45`
`46`		`- logger.WriteCore(TraceType.Verbose, RelationalLoggingEventIds.ClosingConnection, connectionString, null,`
	`46`	`+ logger.Write(TraceType.Verbose, RelationalLoggingEventIds.ClosingConnection, connectionString, null,`
`47`	`47`	`(o, _) => Strings.FormatRelationalLoggerClosingConnection(o));`
`48`	`48`	`}`
`49`	`49`
`50`	`50`	`public static void BeginningTransaction([NotNull] this ILogger logger, IsolationLevel isolationLevel)`
`51`	`51`	`{`
`52`	`52`	`Check.NotNull(logger, "logger");`
`53`	`53`
`54`		`- logger.WriteCore(TraceType.Verbose, RelationalLoggingEventIds.BeginningTransaction, isolationLevel.ToString("G"), null,`
	`54`	`+ logger.Write(TraceType.Verbose, RelationalLoggingEventIds.BeginningTransaction, isolationLevel.ToString("G"), null,`
`55`	`55`	`(o, _) => Strings.FormatRelationalLoggerBeginningTransaction(o));`
`56`	`56`	`}`
`57`	`57`
`58`	`58`	`public static void CommittingTransaction([NotNull] this ILogger logger)`
`59`	`59`	`{`
`60`	`60`	`Check.NotNull(logger, "logger");`
`61`	`61`
`62`		`- logger.WriteCore(TraceType.Verbose, RelationalLoggingEventIds.CommittingTransaction, null, null,`
	`62`	`+ logger.Write(TraceType.Verbose, RelationalLoggingEventIds.CommittingTransaction, null, null,`
`63`	`63`	`(_, __) => Strings.RelationalLoggerCommittingTransaction);`
`64`	`64`	`}`
`65`	`65`
`66`	`66`	`public static void RollingbackTransaction([NotNull] this ILogger logger)`
`67`	`67`	`{`
`68`	`68`	`Check.NotNull(logger, "logger");`
`69`	`69`
`70`		`- logger.WriteCore(TraceType.Verbose, RelationalLoggingEventIds.RollingbackTransaction, null, null,`
	`70`	`+ logger.Write(TraceType.Verbose, RelationalLoggingEventIds.RollingbackTransaction, null, null,`
`71`	`71`	`(_, __) => Strings.RelationalLoggerRollingbackTransaction);`
`72`	`72`	`}`
`73`	`73`	`}`
Original file line number	Diff line number	Diff line change
`@@ -132,7 +132,7 @@ public virtual int SaveChanges()`
`132`	`132`	`}`
`133`	`133`	`catch (Exception ex)`
`134`	`134`	`{`
`135`		`- _logger.Value.WriteCore(`
	`135`	`+ _logger.Value.Write(`
`136`	`136`	`TraceType.Error,`
`137`	`137`	`0,`
`138`	`138`	`new DataStoreErrorLogState(GetType()),`
`@@ -157,7 +157,7 @@ public virtual int SaveChanges()`
`157`	`157`	`}`
`158`	`158`	`catch (Exception ex)`
`159`	`159`	`{`
`160`		`- _logger.Value.WriteCore(`
	`160`	`+ _logger.Value.Write(`
`161`	`161`	`TraceType.Error,`
`162`	`162`	`0,`
`163`	`163`	`new DataStoreErrorLogState(GetType()),`
Original file line number	Diff line number	Diff line change
`@@ -194,7 +194,7 @@ public bool MoveNext()`
`194`	`194`	`}`
`195`	`195`	`catch (Exception ex)`
`196`	`196`	`{`
`197`		`- _logger.Value.WriteCore(`
	`197`	`+ _logger.Value.Write(`
`198`	`198`	`TraceType.Error,`
`199`	`199`	`0,`
`200`	`200`	`new DataStoreErrorLogState(_context.GetType()),`
`@@ -262,7 +262,7 @@ public async Task<bool> MoveNext(CancellationToken cancellationToken)`
`262`	`262`	`}`
`263`	`263`	`catch (Exception ex)`
`264`	`264`	`{`
`265`		`- _logger.Value.WriteCore(`
	`265`	`+ _logger.Value.Write(`
`266`	`266`	`TraceType.Error,`
`267`	`267`	`0,`
`268`	`268`	`new DataStoreErrorLogState(_context.GetType()),`
Original file line number	Diff line number	Diff line change
`@@ -26,8 +26,13 @@ private NullLogger()`
`26`	`26`	`{`
`27`	`27`	`}`
`28`	`28`
`29`		`- public bool WriteCore(`
	`29`	`+ public void Write(`
`30`	`30`	`TraceType eventType, int eventId, object state, Exception exception, Func<object, Exception, string> formatter)`
	`31`	`+ {`
	`32`	`+ return;`
	`33`	`+ }`
	`34`	`+`
	`35`	`+ public bool IsEnabled(TraceType eventType)`
`31`	`36`	`{`
`32`	`37`	`return false;`
`33`	`38`	`}`
Original file line number	Diff line number	Diff line change
`@@ -48,14 +48,17 @@ public virtual void StartLoggingForCurrentCallContext()`
`48`	`48`	`#endif`
`49`	`49`	`}`
`50`	`50`
`51`		`- public virtual bool WriteCore(TraceType eventType, int eventId, [CanBeNull] object state, [CanBeNull] Exception exception, [CanBeNull] Func<object, Exception, string> formatter)`
	`51`	`+ public virtual void Write(TraceType eventType, int eventId, [CanBeNull] object state, [CanBeNull] Exception exception, [CanBeNull] Func<object, Exception, string> formatter)`
`52`	`52`	`{`
`53`	`53`	`var errorState = state as DataStoreErrorLogState;`
`54`	`54`	`if (errorState != null && exception != null && LastError != null)`
`55`	`55`	`{`
`56`	`56`	`LastError.SetError(errorState.ContextType, exception);`
`57`	`57`	`}`
	`58`	`+ }`
`58`	`59`
	`60`	`+ public virtual bool IsEnabled(TraceType eventType)`
	`61`	`+ {`
`59`	`62`	`return true;`
`60`	`63`	`}`
`61`	`64`
Original file line number	Diff line number	Diff line change
`@@ -171,7 +171,7 @@ public IDisposable BeginScope(object state)`
`171`	`171`	`return NullScope.Instance;`
`172`	`172`	`}`
`173`	`173`
`174`		`- public bool WriteCore(TraceType eventType, int eventId, object state, Exception exception, Func<object, Exception, string> formatter)`
	`174`	`+ public void Write(TraceType eventType, int eventId, object state, Exception exception, Func<object, Exception, string> formatter)`
`175`	`175`	`{`
`176`	`176`	`var error = state as DataStoreErrorLogState;`
`177`	`177`	`if (error != null)`
`@@ -180,7 +180,10 @@ public bool WriteCore(TraceType eventType, int eventId, object state, Exception`
`180`	`180`	`LastDataStoreErrorException = exception;`
`181`	`181`	`LastDataStoreErrorFormatter = formatter;`
`182`	`182`	`}`
	`183`	`+ }`
`183`	`184`
	`185`	`+ public bool IsEnabled(TraceType eventType)`
	`186`	`+ {`
`184`	`187`	`return true;`
`185`	`188`	`}`
`186`	`189`
Original file line number	Diff line number	Diff line change
`@@ -41,7 +41,7 @@ var logDirectory`
`41`	`41`	`_logFilePath = Path.Combine(logDirectory, fileName);`
`42`	`42`	`}`
`43`	`43`
`44`		`- public bool WriteCore(`
	`44`	`+ public void Write(`
`45`	`45`	`TraceType eventType, int eventId, object state, Exception exception, Func<object, Exception, string> formatter)`
`46`	`46`	`{`
`47`	`47`	`if (formatter != null)`
`@@ -56,7 +56,10 @@ public bool WriteCore(`
`56`	`56`	`}`
`57`	`57`	`}`
`58`	`58`	`}`
	`59`	`+ }`
`59`	`60`
	`61`	`+ public bool IsEnabled(TraceType eventType)`
	`62`	`+ {`
`60`	`63`	`return true;`
`61`	`64`	`}`
`62`	`65`
Original file line number	Diff line number	Diff line change
`@@ -1459,15 +1459,18 @@ public TestLogger(string name, StringBuilder builder)`
`1459`	`1459`	`_builder = builder;`
`1460`	`1460`	`}`
`1461`	`1461`
`1462`		`- public bool WriteCore(TraceType eventType, int eventId, object state, Exception exception, Func<object, Exception, string> formatter)`
	`1462`	`+ public void Write(TraceType eventType, int eventId, object state, Exception exception, Func<object, Exception, string> formatter)`
`1463`	`1463`	`{`
`1464`	`1464`	`_builder`
`1465`	`1465`	`.Append(_name)`
`1466`	`1466`	`.Append(" ")`
`1467`	`1467`	`.Append(eventType.ToString("G"))`
`1468`	`1468`	`.Append(" ")`
`1469`	`1469`	`.AppendLine(formatter(state, exception));`
	`1470`	`+ }`
`1470`	`1471`
	`1472`	`+ public bool IsEnabled(TraceType eventType)`
	`1473`	`+ {`
`1471`	`1474`	`return true;`
`1472`	`1475`	`}`
`1473`	`1476`
Original file line number	Diff line number	Diff line change
`@@ -60,7 +60,7 @@ public class SqlLogger : ILogger`
`60`	`60`
`61`	`61`	`private CancellationTokenSource _cancellationTokenSource;`
`62`	`62`
`63`		`- public bool WriteCore(`
	`63`	`+ public void Write(`
`64`	`64`	`TraceType eventType,`
`65`	`65`	`int eventId,`
`66`	`66`	`object state,`
`@@ -79,7 +79,10 @@ public bool WriteCore(`
`79`	`79`
`80`	`80`	`SqlStatements.Add(sql);`
`81`	`81`	`}`
	`82`	`+ }`
`82`	`83`
	`84`	`+ public bool IsEnabled(TraceType eventType)`
	`85`	`+ {`
`83`	`86`	`return true;`
`84`	`87`	`}`
`85`	`88`