Add missing awaits in MigrationsInfrastructureTestBase (#35106)

roji · web-flow · commit a3c56773adea · 2024-11-14T13:50:18.000Z
diff --git a/test/EFCore.Relational.Specification.Tests/Migrations/MigrationsInfrastructureTestBase.cs b/test/EFCore.Relational.Specification.Tests/Migrations/MigrationsInfrastructureTestBase.cs
@@ -286,21 +286,21 @@ await history.GetAppliedMigrationsAsync(),
     }
 
     [ConditionalFact]
-    public virtual void Can_generate_no_migration_script()
+    public virtual async Task Can_generate_no_migration_script()
     {
         using var db = Fixture.CreateEmptyContext();
         var migrator = db.GetService<IMigrator>();
 
-        SetAndExecuteSqlAsync(migrator.GenerateScript());
+        await SetAndExecuteSqlAsync(migrator.GenerateScript());
     }
 
     [ConditionalFact]
-    public virtual void Can_generate_migration_from_initial_database_to_initial()
+    public virtual async Task Can_generate_migration_from_initial_database_to_initial()
     {
         using var db = Fixture.CreateContext();
         var migrator = db.GetService<IMigrator>();
 
-        SetAndExecuteSqlAsync(migrator.GenerateScript(fromMigration: Migration.InitialDatabase, toMigration: Migration.InitialDatabase));
+        await SetAndExecuteSqlAsync(migrator.GenerateScript(fromMigration: Migration.InitialDatabase, toMigration: Migration.InitialDatabase));
     }
 
     [ConditionalFact]
diff --git a/test/EFCore.SqlServer.FunctionalTests/Migrations/MigrationsInfrastructureSqlServerTest.cs b/test/EFCore.SqlServer.FunctionalTests/Migrations/MigrationsInfrastructureSqlServerTest.cs
@@ -29,9 +29,9 @@ public override void Can_apply_range_of_migrations()
                 Fixture.TestSqlLoggerFactory.Log.Single(l => l.Id == RelationalEventId.NonTransactionalMigrationOperationWarning).Message);
         }
 
-        public override void Can_generate_migration_from_initial_database_to_initial()
+        public override async Task Can_generate_migration_from_initial_database_to_initial()
         {
-            base.Can_generate_migration_from_initial_database_to_initial();
+            await base.Can_generate_migration_from_initial_database_to_initial();
 
             Assert.Equal(
                 """
@@ -51,9 +51,9 @@ CONSTRAINT [PK___EFMigrationsHistory] PRIMARY KEY ([MigrationId])
                 ignoreLineEndingDifferences: true);
         }
 
-        public override void Can_generate_no_migration_script()
+        public override async Task Can_generate_no_migration_script()
         {
-            base.Can_generate_no_migration_script();
+            await base.Can_generate_no_migration_script();
 
             Assert.Equal(
                 """
diff --git a/test/EFCore.Sqlite.FunctionalTests/Migrations/MigrationsInfrastructureSqliteTest.cs b/test/EFCore.Sqlite.FunctionalTests/Migrations/MigrationsInfrastructureSqliteTest.cs
@@ -12,9 +12,9 @@ namespace Microsoft.EntityFrameworkCore.Migrations
     public class MigrationsInfrastructureSqliteTest(MigrationsInfrastructureSqliteTest.MigrationsInfrastructureSqliteFixture fixture)
         : MigrationsInfrastructureTestBase<MigrationsInfrastructureSqliteTest.MigrationsInfrastructureSqliteFixture>(fixture)
     {
-        public override void Can_generate_migration_from_initial_database_to_initial()
+        public override async Task Can_generate_migration_from_initial_database_to_initial()
         {
-            base.Can_generate_migration_from_initial_database_to_initial();
+            await base.Can_generate_migration_from_initial_database_to_initial();
 
             Assert.Equal(
                 """
@@ -29,9 +29,9 @@ public override void Can_generate_migration_from_initial_database_to_initial()
                 ignoreLineEndingDifferences: true);
         }
 
-        public override void Can_generate_no_migration_script()
+        public override async Task Can_generate_no_migration_script()
         {
-            base.Can_generate_no_migration_script();
+            await base.Can_generate_no_migration_script();
 
             Assert.Equal(
                 """

Original file line number	Diff line number	Diff line change
`@@ -286,21 +286,21 @@ await history.GetAppliedMigrationsAsync(),`
`286`	`286`	`}`
`287`	`287`
`288`	`288`	`[ConditionalFact]`
`289`		`- public virtual void Can_generate_no_migration_script()`
	`289`	`+ public virtual async Task Can_generate_no_migration_script()`
`290`	`290`	`{`
`291`	`291`	`using var db = Fixture.CreateEmptyContext();`
`292`	`292`	`var migrator = db.GetService<IMigrator>();`
`293`	`293`
`294`		`- SetAndExecuteSqlAsync(migrator.GenerateScript());`
	`294`	`+ await SetAndExecuteSqlAsync(migrator.GenerateScript());`
`295`	`295`	`}`
`296`	`296`
`297`	`297`	`[ConditionalFact]`
`298`		`- public virtual void Can_generate_migration_from_initial_database_to_initial()`
	`298`	`+ public virtual async Task Can_generate_migration_from_initial_database_to_initial()`
`299`	`299`	`{`
`300`	`300`	`using var db = Fixture.CreateContext();`
`301`	`301`	`var migrator = db.GetService<IMigrator>();`
`302`	`302`
`303`		`- SetAndExecuteSqlAsync(migrator.GenerateScript(fromMigration: Migration.InitialDatabase, toMigration: Migration.InitialDatabase));`
	`303`	`+ await SetAndExecuteSqlAsync(migrator.GenerateScript(fromMigration: Migration.InitialDatabase, toMigration: Migration.InitialDatabase));`
`304`	`304`	`}`
`305`	`305`
`306`	`306`	`[ConditionalFact]`
Original file line number	Diff line number	Diff line change
`@@ -29,9 +29,9 @@ public override void Can_apply_range_of_migrations()`
`29`	`29`	`Fixture.TestSqlLoggerFactory.Log.Single(l => l.Id == RelationalEventId.NonTransactionalMigrationOperationWarning).Message);`
`30`	`30`	`}`
`31`	`31`
`32`		`- public override void Can_generate_migration_from_initial_database_to_initial()`
	`32`	`+ public override async Task Can_generate_migration_from_initial_database_to_initial()`
`33`	`33`	`{`
`34`		`- base.Can_generate_migration_from_initial_database_to_initial();`
	`34`	`+ await base.Can_generate_migration_from_initial_database_to_initial();`
`35`	`35`
`36`	`36`	`Assert.Equal(`
`37`	`37`	`"""`
`@@ -51,9 +51,9 @@ CONSTRAINT [PK___EFMigrationsHistory] PRIMARY KEY ([MigrationId])`
`51`	`51`	`ignoreLineEndingDifferences: true);`
`52`	`52`	`}`
`53`	`53`
`54`		`- public override void Can_generate_no_migration_script()`
	`54`	`+ public override async Task Can_generate_no_migration_script()`
`55`	`55`	`{`
`56`		`- base.Can_generate_no_migration_script();`
	`56`	`+ await base.Can_generate_no_migration_script();`
`57`	`57`
`58`	`58`	`Assert.Equal(`
`59`	`59`	`"""`
Original file line number	Diff line number	Diff line change
`@@ -12,9 +12,9 @@ namespace Microsoft.EntityFrameworkCore.Migrations`
`12`	`12`	`public class MigrationsInfrastructureSqliteTest(MigrationsInfrastructureSqliteTest.MigrationsInfrastructureSqliteFixture fixture)`
`13`	`13`	`: MigrationsInfrastructureTestBase<MigrationsInfrastructureSqliteTest.MigrationsInfrastructureSqliteFixture>(fixture)`
`14`	`14`	`{`
`15`		`- public override void Can_generate_migration_from_initial_database_to_initial()`
	`15`	`+ public override async Task Can_generate_migration_from_initial_database_to_initial()`
`16`	`16`	`{`
`17`		`- base.Can_generate_migration_from_initial_database_to_initial();`
	`17`	`+ await base.Can_generate_migration_from_initial_database_to_initial();`
`18`	`18`
`19`	`19`	`Assert.Equal(`
`20`	`20`	`"""`
`@@ -29,9 +29,9 @@ public override void Can_generate_migration_from_initial_database_to_initial()`
`29`	`29`	`ignoreLineEndingDifferences: true);`
`30`	`30`	`}`
`31`	`31`
`32`		`- public override void Can_generate_no_migration_script()`
	`32`	`+ public override async Task Can_generate_no_migration_script()`
`33`	`33`	`{`
`34`		`- base.Can_generate_no_migration_script();`
	`34`	`+ await base.Can_generate_no_migration_script();`
`35`	`35`
`36`	`36`	`Assert.Equal(`
`37`	`37`	`"""`