Migration to .NET 6 RC-2 from .NET 5

[MartyIX]

Hi,

I have attempted to migrate my C# solution (a set of projects) from .NET 5 to .NET 6 RC2 and I have also upgraded efcore to 6 RC2. However, now it happens that Microsoft.Extensions.DependencyInjection.Abstractions.dll is not copied to the bin\debug\net6.0 in a test project (the test project contains "exes references" (#1675))

I have asked around and @rolfbjarne adviced to use:

dotnet build /bl:msbuild.binlog # + install https://msbuildlog.com/

to compare builds on .NET 5 and .NET 6 to find out differences. I did that and I have found out that GenerateDepsFile task is in like each C# project mentioned in .NET 5 msbuild but that's not the case for .NET 6. This seems to be the difference. Is it possible that that's the reason why the Microsoft.Extensions.DependencyInjection.Abstractions.dll is not copied to the output of my test project?

Also I can see in project.deps.json (.NET 5):

"Microsoft.Extensions.DependencyInjection/5.0.2": {
  "dependencies": {
    "Microsoft.Extensions.DependencyInjection.Abstractions": "5.0.0"
  },
  "runtime": {
    "lib/net5.0/Microsoft.Extensions.DependencyInjection.dll": {
      "assemblyVersion": "5.0.0.1",
      "fileVersion": "5.0.821.31504"
    }
  }
},

and in .NET 6, I can see

"Microsoft.Extensions.DependencyInjection/6.0.0-rc.2.21480.5": {

  "dependencies": {
    "Microsoft.Extensions.DependencyInjection.Abstractions": "6.0.0-rc.2.21480.5",
    "System.Runtime.CompilerServices.Unsafe": "6.0.0-rc.2.21480.5"
  }
},

(i.e. no "runtime" here)

But still I don't really know why Microsoft.Extensions.DependencyInjection.Abstractions.dll is not copied to the output as a runtime library as my knowledge of msbuild is limited 😐

I have also tried to add <PackageReference Include="Microsoft.Extensions.DependencyInjection.Abstractions" Version="6.0.0-rc.2.21480.5" /> to my testproject.csproj file but it does not force to add the missing .dll file to the output.

I understand that nobody can really tell me what exactly is wrong because they would need a repro project (which I don't have, the solution is not trivial and I'm not even sure if I can separate out that specific issue). However, maybe you guys can tell me if there was any change that might have the consequences I'm observing. Or possibly an idea how to debug it more or how to work it around.

Thank you!

Regards,
Martin

[ErikEJ]

How does this relate to EF Core?

[MartyIX]

EF Core depends on Microsoft.Extensions.DependencyInjection.Abstractions (AFAIK). And there might have been some change on your side (?).

I don't understand the issue well enough. So I'm asking somewhat blindly. I can open the issue in a different repo if you tell me which one sounds better.

Thanks

[dsplaisted]

I've moved this to the sdk repo.

Is it possible for you to share the binlogs for us to investigate? They'll include lots of information (see https://aka.ms/binlog) including your project files and their imports, but not your C# source files.

[MartyIX]

Here is a simplified repro solution: Repro22053.zip

Scenario 1:

1. <PackageReference Include="Microsoft.AspNetCore.Authentication.Negotiate" Version="6.0.0-rc.2.21480.10" /> in SharedLibTests.csproj is NOT comment out.
2. IntegrationTests/bin/Debug/net6.0 does not contain Microsoft.Extensions.DependencyInjection.Abstractions.dll.

Scenario 2:

1. <PackageReference Include="Microsoft.AspNetCore.Authentication.Negotiate" Version="6.0.0-rc.2.21480.10" /> in SharedLibTests.csproj IS commented out.
2. IntegrationTests/bin/Debug/net6.0 contains Microsoft.Extensions.DependencyInjection.Abstractions.dll.

I don't really know why this happens.

Can anyone explain to me why this happens so that next time I know how to fix it?

[sfoslund]

@MartyIX if the dll only shows up when the package reference you mentioned above is not commented out, then I expect it's copied as part of that package's dependencies. Is there any reason you expect it to be copied when the package reference is commented out?

[MartyIX]

@sfoslund

if the dll only shows up when the package reference you mentioned above is not commented out,

This sentence seems incorrect to me so let me rephrase it. What happens in Scenario 2 is that in case I have:

<!-- <PackageReference Include="Microsoft.AspNetCore.Authentication.Negotiate" Version="6.0.0-rc.2.21480.10" /> --> in SharedLibTests.csproj.

then IntegrationTests/bin/Debug/net6.0 do constain Microsoft.Extensions.DependencyInjection.Abstractions.dll. So it's the other way around than what you said. I'm just making sure we understand each other.

And why it is important to have Microsoft.Extensions.DependencyInjection.Abstractions.dll in IntegrationTests/bin/Debug/net6.0? That's because IntegrationTests is a test project that is supposed to run Product.BoxProgram.exe as a process. So BoxProgram project should be deployed to IntegrationTests/bin/Debug/net6.0 in its entirety (with all dependencies) so that IntegrationTests/bin/Debug/net6.0/Product.BoxProgram.exe can be run.

---

Anyway, I have modified the repro to demonstrate the issue better here: Repro22053.zip. Please just compile, and run in a terminal Repro22053\IntegrationTests\bin\Debug\net6.0> .\Product.BoxProgram.exe, it should show you:

Unhandled exception. System.IO.FileNotFoundException: Could not load file or assembly 'Microsoft.Extensions.DependencyInjection.Abstractions, Version=6.0.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60'. The system cannot find the file specified.
File name: 'Microsoft.Extensions.DependencyInjection.Abstractions, Version=6.0.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60'
   at Microsoft.EntityFrameworkCore.DbContext..ctor(DbContextOptions options)
   at Microsoft.EntityFrameworkCore.DbContext..ctor()
   at WhalesSecret.SharedLib.Database.DatabaseContextBase..ctor() in C:\Repro22053\SharedLib\DatabaseContextBase.cs:line 18
   at Product.BoxProgram.Program.Main() in C:\Repro22053\BoxProgram\Class1.cs:line 14

and when you comment out <PackageReference Include="Microsoft.AspNetCore.Authentication.Negotiate" Version="6.0.0-rc.2.21480.10" /> in SharedLibTests.csproj, recompile, the exception will be gone.

[dsplaisted]

I took a look at this. What's going on is that the Microsoft.AspNetCore.Authentication.Negotiate package depends on the ASP.NET shared framework (Microsoft.AspNetCore.App). So when you reference it from the IntegrationTests project, the IntegrationTests project also depends on the shared framework.

There are some DLLs, including Microsoft.Extensions.DependencyInjection.Abstractions, that are available both as part of the ASP.NET Shared Framework as well as via NuGet packages. If a project uses the shared framework, then if those DLLs also come in via a NuGet package then they will not be included in the output, as they will be loaded from the shared framework.

So Microsoft.Extensions.DependencyInjection.Abstractions.dll isn't getting copied to the output folder of the IntegrationTests project because that API is part of the shared framework which the project references. However, the referenced BoxProgram exe doesn't depend on the shared framework, so it is not able to load the DLL.

If you can add the following to BoxProgram.csproj, that should fix the issue:

  <ItemGroup>
    <FrameworkReference Include="Microsoft.AspNetCore.App" />
  </ItemGroup>

[MartyIX]

@dsplaisted Thank you! That's very informative explanation.

How did you actually find out all this? Did you read some msbuild scripts? I ask because I can debug C# code and given enough time I can find many bugs but msbuild is very hard for me to reason about. Is there any book or recommended resource to read to understand this stuff more in depth?