@@ -12,7 +12,7 @@ namespace Microsoft.Extensions.Logging.Analyzer.Test
1212{
1313 public class FormatStringAnalyzerTests : DiagnosticVerifier
1414 {
15- [ Theory ( Skip = "https://github.com/aspnet/Extensions/issues/625" ) ]
15+ [ Theory ]
1616 [ MemberData ( nameof ( GenerateTemplateAndDefineUsages ) , @"""{0}""" , "1" ) ]
1717 public void MEL0001IsProducedForNumericFormatArgument ( string format )
1818 {
@@ -21,7 +21,7 @@ public void MEL0001IsProducedForNumericFormatArgument(string format)
2121 Assert . Equal ( "MEL0001" , diagnostic . Id ) ;
2222 }
2323
24- [ Theory ( Skip = "https://github.com/aspnet/Extensions/issues/625" ) ]
24+ [ Theory ]
2525 [ MemberData ( nameof ( GenerateTemplateAndDefineUsages ) , @"$""{string.Empty}""" , "" ) ]
2626 [ MemberData ( nameof ( GenerateTemplateAndDefineUsages ) , @"""string"" + 2" , "" ) ]
2727 public void MEL0002IsProducedForDynamicFormatArgument ( string format )
@@ -30,7 +30,7 @@ public void MEL0002IsProducedForDynamicFormatArgument(string format)
3030 Assert . Equal ( "MEL0002" , diagnostic . Id ) ;
3131 }
3232
33- [ Theory ( Skip = "https://github.com/aspnet/Extensions/issues/625" ) ]
33+ [ Theory ]
3434 [ MemberData ( nameof ( GenerateTemplateUsages ) , @"""{string}""" , "1, 2" ) ]
3535 [ MemberData ( nameof ( GenerateTemplateUsages ) , @"""{str"" + ""ing}""" , "1, 2" ) ]
3636 [ MemberData ( nameof ( GenerateTemplateUsages ) , @"""{"" + nameof(ILogger) + ""}""" , "" ) ]
@@ -41,7 +41,7 @@ public void MEL0003IsProducedForFormatArgumentCountMismatch(string format)
4141 Assert . Equal ( "MEL0003" , diagnostic . Id ) ;
4242 }
4343
44- [ Theory ( Skip = "https://github.com/aspnet/Extensions/issues/625" ) ]
44+ [ Theory ]
4545 [ InlineData ( @"LoggerMessage.Define(LogLevel.Information, 42, ""{One} {Two} {Three}"");" ) ]
4646 [ InlineData ( @"LoggerMessage.Define<int>(LogLevel.Information, 42, ""{One} {Two} {Three}"");" ) ]
4747 [ InlineData ( @"LoggerMessage.Define<int, int>(LogLevel.Information, 42, ""{One} {Two} {Three}"");" ) ]
@@ -56,7 +56,7 @@ public void MEL0003IsProducedForDefineMessageTypeParameterMismatch(string invoca
5656 Assert . Equal ( "MEL0003" , diagnostic . Id ) ;
5757 }
5858
59- [ Theory ( Skip = "https://github.com/aspnet/Extensions/issues/625" ) ]
59+ [ Theory ]
6060 [ InlineData ( "LogTrace" , @"""This is a test {Message}"", ""Foo""" ) ]
6161 [ InlineData ( "LogDebug" , @"""This is a test {Message}"", ""Foo""" ) ]
6262 [ InlineData ( "LogInformation" , @"""This is a test {Message}"", ""Foo""" ) ]
@@ -71,15 +71,15 @@ public void MEL0004IsProducedForInvocationsOfAllLoggerExtensions(string method,
7171 Assert . Equal ( $ "For improved performance, use pre-compiled log messages instead of calling '{ method } ' with a string message.", diagnostic . GetMessage ( ) ) ;
7272 }
7373
74- [ Theory ( Skip = "https://github.com/aspnet/Extensions/issues/625" ) ]
74+ [ Theory ]
7575 [ MemberData ( nameof ( GenerateTemplateAndDefineUsages ) , @"""{camelCase}""" , "1" ) ]
7676 public void MEL0005IsProducedForCamelCasedFormatArgument ( string format )
7777 {
7878 var diagnostic = Assert . Single ( GetDiagnostics ( format , "MEL0005" ) ) ;
7979 Assert . Equal ( "MEL0005" , diagnostic . Id ) ;
8080 }
8181
82- [ Theory ( Skip = "https://github.com/aspnet/Extensions/issues/625" ) ]
82+ [ Theory ]
8383 // Concat would be optimized by compiler
8484 [ MemberData ( nameof ( GenerateTemplateAndDefineUsages ) , @"nameof(ILogger) + "" string""" , "" ) ]
8585 [ MemberData ( nameof ( GenerateTemplateAndDefineUsages ) , @""" string"" + "" string""" , "" ) ]
0 commit comments