Skip failing localization tests on OSX

HaoK · HaoK · commit 9d62bf166182 · 2018-12-11T12:41:07.000-08:00
diff --git a/src/Localization/Localization/test/ResourceManagerStringLocalizerTest.cs b/src/Localization/Localization/test/ResourceManagerStringLocalizerTest.cs
@@ -17,7 +17,8 @@ namespace Microsoft.Extensions.Localization
 {
     public class ResourceManagerStringLocalizerTest
     {
-        [Fact]
+        [ConditionalFact]
+        [OSSkipCondition(OperatingSystems.MacOSX, "https://github.com/aspnet/Extensions/issues/627")]
         public void EnumeratorCachesCultureWalkForSameAssembly()
         {
             // Arrange
@@ -54,7 +55,8 @@ public void EnumeratorCachesCultureWalkForSameAssembly()
             Assert.Equal(expectedCallCount, resourceAssembly.ManifestResourceStreamCallCount);
         }
 
-        [Fact]
+        [ConditionalFact]
+        [OSSkipCondition(OperatingSystems.MacOSX, "https://github.com/aspnet/Extensions/issues/627")]
         public void EnumeratorCacheIsScopedByAssembly()
         {
             // Arrange
@@ -169,7 +171,8 @@ public void ResourceManagerStringLocalizer_GetAllStrings_ReturnsExpectedValue(bo
             Assert.Equal("TestName", value.Value);
         }
 
-        [Theory]
+        [ConditionalTheory]
+        [OSSkipCondition(OperatingSystems.MacOSX, "https://github.com/aspnet/Extensions/issues/627")]
         [InlineData(true)]
         [InlineData(false)]
         public void ResourceManagerStringLocalizer_GetAllStrings_MissingResourceThrows(bool includeParentCultures)

Original file line number	Diff line number	Diff line change
`@@ -17,7 +17,8 @@ namespace Microsoft.Extensions.Localization`
`17`	`17`	`{`
`18`	`18`	`public class ResourceManagerStringLocalizerTest`
`19`	`19`	`{`
`20`		`- [Fact]`
	`20`	`+ [ConditionalFact]`
	`21`	`+ [OSSkipCondition(OperatingSystems.MacOSX, "https://github.com/aspnet/Extensions/issues/627")]`
`21`	`22`	`public void EnumeratorCachesCultureWalkForSameAssembly()`
`22`	`23`	`{`
`23`	`24`	`// Arrange`
`@@ -54,7 +55,8 @@ public void EnumeratorCachesCultureWalkForSameAssembly()`
`54`	`55`	`Assert.Equal(expectedCallCount, resourceAssembly.ManifestResourceStreamCallCount);`
`55`	`56`	`}`
`56`	`57`
`57`		`- [Fact]`
	`58`	`+ [ConditionalFact]`
	`59`	`+ [OSSkipCondition(OperatingSystems.MacOSX, "https://github.com/aspnet/Extensions/issues/627")]`
`58`	`60`	`public void EnumeratorCacheIsScopedByAssembly()`
`59`	`61`	`{`
`60`	`62`	`// Arrange`
`@@ -169,7 +171,8 @@ public void ResourceManagerStringLocalizer_GetAllStrings_ReturnsExpectedValue(bo`
`169`	`171`	`Assert.Equal("TestName", value.Value);`
`170`	`172`	`}`
`171`	`173`
`172`		`- [Theory]`
	`174`	`+ [ConditionalTheory]`
	`175`	`+ [OSSkipCondition(OperatingSystems.MacOSX, "https://github.com/aspnet/Extensions/issues/627")]`
`173`	`176`	`[InlineData(true)]`
`174`	`177`	`[InlineData(false)]`
`175`	`178`	`public void ResourceManagerStringLocalizer_GetAllStrings_MissingResourceThrows(bool includeParentCultures)`