Skip to content

Commit f0e7c27

Browse files
committed
Fix ordering, set tfm before we account for building without arcade
1 parent 7973c7c commit f0e7c27

File tree

1 file changed

+23
-21
lines changed

1 file changed

+23
-21
lines changed

Directory.Build.props

Lines changed: 23 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,29 @@
2121
<BUILDING_USING_DOTNET>true</BUILDING_USING_DOTNET>
2222
</PropertyGroup>
2323

24+
<!-- To support source-build for the "next" version of .NET without forcing this repo to use it,
25+
we can utilize arcade's $(NetCurrent) property, and set it ourselves in the arcade-less scenarios.
26+
For FCS solution, we set it to one for current dev cycle.
27+
When used with arcade, and inserting/building for net8 branches, it will set it to net8.0,
28+
for net9 branches to net9.0 and so on -->
29+
<Choose>
30+
<!-- Once we move to OOP in VS, and major dependants of FCS will move to netcore (not netstandard),
31+
we should also support $(NetPrevious) for all releases.
32+
This will likely include FCS and FSharp.Core as well ash shipped products.
33+
Right now, it only covers producs we ship (FSC and FSI), not NuGet packages. -->
34+
<When
35+
Condition="'$(DotNetBuildFromSource)' == 'true' AND '$(DotNetBuildFromSourceFlavor)' == 'Product'">
36+
<PropertyGroup>
37+
<FSharpNetCoreProductTargetFramework>$(NetCurrent)</FSharpNetCoreProductTargetFramework>
38+
</PropertyGroup>
39+
</When>
40+
<Otherwise>
41+
<PropertyGroup>
42+
<FSharpNetCoreProductTargetFramework>net8.0</FSharpNetCoreProductTargetFramework>
43+
</PropertyGroup>
44+
</Otherwise>
45+
</Choose>
46+
2447
<Import Project="$(RepoRoot)/Directory.Build.props.user" Condition="Exists('$(RepoRoot)/Directory.Build.props.user')" />
2548

2649
<PropertyGroup Condition="'$(BUILDING_USING_DOTNET)' == 'true'">
@@ -44,26 +67,5 @@
4467
<!-- If there is a README.md next to a project file, include it (for easier access in the IDE) -->
4568
<None Include="README.md" Condition="Exists('README.md')" />
4669
</ItemGroup>
47-
48-
<!-- To support source-build for the "next" version of .NET without forcing this repo to use it,
49-
we can utilize arcade's $(NetCurrent) property, and set it ourselves in the arcade-less scenarios.
50-
For FCS solution, we set it to one for current dev cycle.
51-
When used with arcade, and inserting/building for net8 branches, it will set it to net8.0,
52-
for net9 branches to net9.0 and so on -->
53-
<Choose>
54-
<!-- Once we move to OOP in VS, and major dependants of FCS will move to netcore (not netstandard), we should also support $(NetPrevious) for all releases.
55-
This will likely include FCS and FSharp.Core as well ash shipped products.
56-
Right now, it only covers producs we ship (FSC and FSI), not NuGet packages. -->
57-
<When Condition="'$(DotNetBuildFromSource)' == 'true' AND '$(DotNetBuildFromSourceFlavor)' == 'Product'">
58-
<PropertyGroup>
59-
<FSharpNetCoreProductTargetFramework>$(NetCurrent)</FSharpNetCoreProductTargetFramework>
60-
</PropertyGroup>
61-
</When>
62-
<Otherwise>
63-
<PropertyGroup>
64-
<FSharpNetCoreProductTargetFramework>net8.0</FSharpNetCoreProductTargetFramework>
65-
</PropertyGroup>
66-
</Otherwise>
67-
</Choose>
6870

6971
</Project>

0 commit comments

Comments
 (0)