Skip to content

Resurrect compiler perf improvements PRs #16125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vzarytovskii opened this issue Oct 16, 2023 · 3 comments
Closed

Resurrect compiler perf improvements PRs #16125

vzarytovskii opened this issue Oct 16, 2023 · 3 comments

Comments

@vzarytovskii
Copy link
Member

vzarytovskii commented Oct 16, 2023

It's a shame those didn't get merged, I think we should resurrect it, they look like great changes

#5360
#5307
#5278
#5112

Going to be working on those past .NET8 release (November+)

@vzarytovskii vzarytovskii self-assigned this Oct 16, 2023
@vzarytovskii vzarytovskii converted this from a draft issue Oct 16, 2023
@github-actions github-actions bot added this to the Backlog milestone Oct 16, 2023
@charlesroddie
Copy link
Contributor

This should be done instead: fsharp/fslang-suggestions#1280 . Doesn't matter whether it is opt-in form or opt-out form: anyone who cares about performance and/or internal consistency of the language will enable it. Last 3 linked PRs are overcomplicated since they don't bite the bullet. One of them even considers using reflection as an additional workaround to the problem. At runtime? Even if not, it still runs the risk and indicates the degree of hacks involved.

@vzarytovskii
Copy link
Member Author

This should be done instead: fsharp/fslang-suggestions#1280 . Doesn't matter whether it is opt-in form or opt-out form: anyone who cares about performance and/or internal consistency of the language will enable it. Last 3 linked PRs are overcomplicated since they don't bite the bullet. One of them even considers using reflection as an additional workaround to the problem. At runtime? Even if not, it still runs the risk and indicates the degree of hacks involved.

They cover a bunch more, how equality improvements are achieved is an implementation detail. It will be decided during when work will be actually happening.

@vzarytovskii vzarytovskii removed their assignment Nov 13, 2023
@psfinaki psfinaki self-assigned this Jan 4, 2024
@psfinaki psfinaki modified the milestones: Backlog, January-2024 Jan 4, 2024
@psfinaki psfinaki moved this from New to Planned in F# Compiler and Tooling Jan 4, 2024
@psfinaki psfinaki removed their assignment Jan 4, 2024
@psfinaki psfinaki changed the title Resurrect compler perf improvements PRs Resurrect compiler perf improvements PRs Jan 4, 2024
@vzarytovskii vzarytovskii removed this from the January-2024 milestone Jan 5, 2024
@vzarytovskii
Copy link
Member Author

If anyone wants to experiment, feel free, I don't have interest in those anymore. I might reuse some parts for the fslib extended library I'm maintaining for my own projects.

@vzarytovskii vzarytovskii closed this as not planned Won't fix, can't repro, duplicate, stale May 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants