don't require IJupyterConnection to be IDiposable (#2887)

* address the feedback around requiring IJupyterConnection to always be disposable.

* fix test since API changed

Author: shibbas

src/Microsoft.DotNet.Interactive.ApiCompatibility.Tests/ApiCompatibilityTests.jupyter_api_is_not_changed.approved.txt

@@ -118,7 +118,7 @@ Microsoft.DotNet.Interactive.Jupyter
     public static System.String input(System.String prompt = )
     public static Microsoft.DotNet.Interactive.PasswordString password(System.String prompt = )
 Microsoft.DotNet.Interactive.Jupyter.Connection
-  public abstract class IJupyterConnection, System.IDisposable
+  public abstract class IJupyterConnection
     public System.Threading.Tasks.Task<IJupyterKernelConnection> CreateKernelConnectionAsync(System.String kernelSpecName)
     public System.Threading.Tasks.Task<System.Collections.Generic.IEnumerable<Microsoft.DotNet.Interactive.Jupyter.KernelSpec>> GetKernelSpecsAsync()
   public abstract class IJupyterKernelConnection, System.IDisposable

src/Microsoft.DotNet.Interactive.Jupyter.Tests/TestJupyterConnectionOptions.cs

@@ -219,7 +219,7 @@ public async Task StartAsync()
     public bool IsDisposed => _disposed;
 }
 
-public class TestJupyterConnection : IJupyterConnection
+public class TestJupyterConnection : IJupyterConnection, IDisposable
 {
     private IJupyterConnection _testJupyterConnection;
     private TestJupyterKernelConnection _testKernelConnection;
@@ -254,7 +254,7 @@ public async Task<IJupyterKernelConnection> CreateKernelConnectionAsync(string k
 
     public void Dispose()
     {
-        _testJupyterConnection?.Dispose();
+        (_testJupyterConnection as IDisposable)?.Dispose();
         _disposed = true;
     }
 

src/Microsoft.DotNet.Interactive.Jupyter/ConnectJupyterKernelCommand.cs

@@ -69,7 +69,10 @@ public override async Task<Kernel> ConnectKernelAsync(
         var localName = commandLineContext.ParseResult.GetValueForOption(KernelNameOption);
 
         var kernel = await connector?.CreateKernelAsync(localName);
-        kernel?.RegisterForDisposal(connection);
+        if (connection is IDisposable disposableConnection)
+        {
+            kernel?.RegisterForDisposal(disposableConnection);
+        }
         return kernel;
     }
 
@@ -95,8 +98,8 @@ private IEnumerable<CompletionItem> GetKernelSpecsCompletions(CompletionContext
         }
 
         IEnumerable<CompletionItem> completions;
-        using (var connection = GetJupyterConnection(ctx.ParseResult))
-        {
+        var connection = GetJupyterConnection(ctx.ParseResult);
+        using (connection as IDisposable) {
             completions = GetKernelSpecsCompletions(connection);
         }
 

src/Microsoft.DotNet.Interactive.Jupyter/Connection/IJupyterConnection.cs

@@ -7,7 +7,7 @@
 
 namespace Microsoft.DotNet.Interactive.Jupyter.Connection;
 
-public interface IJupyterConnection : IDisposable
+public interface IJupyterConnection
 {
     Task<IEnumerable<KernelSpec>> GetKernelSpecsAsync();
 

src/Microsoft.DotNet.Interactive.Jupyter/Http/JupyterHttpConnection.cs

@@ -13,7 +13,7 @@
 
 namespace Microsoft.DotNet.Interactive.Jupyter.Http;
 
-internal class JupyterHttpConnection : IJupyterConnection
+internal class JupyterHttpConnection : IJupyterConnection, IDisposable
 {
     #region JsonTypes
     private class KernelSessionInfo

src/Microsoft.DotNet.Interactive.Jupyter/ZMQ/JupyterConnection.cs

@@ -132,10 +132,6 @@ private Process CreateKernelProcess(KernelSpec spec, string connectionFilePath)
         return kernelProcess;
     }
 
-    public void Dispose()
-    {
-    }
-
     private async Task<KernelSpec> GetKernelSpecAsync(string kernelSpecName)
     {
         var installedSpecs = await _getKernelSpecs;