Skip to content

Commit 34b0fd2

Browse files
committed
remove command id from .NET code
1 parent 2ff829a commit 34b0fd2

File tree

46 files changed

+2
-127
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

46 files changed

+2
-127
lines changed

src/Microsoft.DotNet.Interactive.CSharpProject.Tests/SerializationTests.cs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,6 @@ public void Command_contract_has_not_been_broken(KernelCommand command)
9797
.UsingExtension($"{command.GetType().Name}.json")
9898
.SetInteractive(Debugger.IsAttached);
9999

100-
command.SetId("command-id");
101100
command.SetToken("the-token");
102101

103102
var json = KernelCommandEnvelope.Serialize(command);
@@ -113,7 +112,6 @@ public void Event_contract_has_not_been_broken(KernelEvent @event)
113112
.UsingExtension($"{@event.GetType().Name}.json")
114113
.SetInteractive(Debugger.IsAttached);
115114

116-
@event.Command?.SetId("command-id");
117115
@event.Command?.SetToken("the-token");
118116

119117
var json = KernelEventEnvelope.Serialize(@event);

src/Microsoft.DotNet.Interactive.Tests/Connection/SerializationTests.Command_contract_has_not_been_broken.approved.Cancel.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
{
22
"token": "the-token",
3-
"id": "command-id",
43
"commandType": "Cancel",
54
"command": {
65
"targetKernelName": "csharp",

src/Microsoft.DotNet.Interactive.Tests/Connection/SerializationTests.Command_contract_has_not_been_broken.approved.ChangeWorkingDirectory.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
{
22
"token": "the-token",
3-
"id": "command-id",
43
"commandType": "ChangeWorkingDirectory",
54
"command": {
65
"workingDirectory": "/path/to/somewhere",

src/Microsoft.DotNet.Interactive.Tests/Connection/SerializationTests.Command_contract_has_not_been_broken.approved.DisplayError.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
{
22
"token": "the-token",
3-
"id": "command-id",
43
"commandType": "DisplayError",
54
"command": {
65
"message": "oops!",

src/Microsoft.DotNet.Interactive.Tests/Connection/SerializationTests.Command_contract_has_not_been_broken.approved.DisplayValue.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
{
22
"token": "the-token",
3-
"id": "command-id",
43
"commandType": "DisplayValue",
54
"command": {
65
"formattedValue": {

src/Microsoft.DotNet.Interactive.Tests/Connection/SerializationTests.Command_contract_has_not_been_broken.approved.Quit.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
{
22
"token": "the-token",
3-
"id": "command-id",
43
"commandType": "Quit",
54
"command": {
65
"targetKernelName": null,

src/Microsoft.DotNet.Interactive.Tests/Connection/SerializationTests.Command_contract_has_not_been_broken.approved.RequestCompletions.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
{
22
"token": "the-token",
3-
"id": "command-id",
43
"commandType": "RequestCompletions",
54
"command": {
65
"code": "Cons",

src/Microsoft.DotNet.Interactive.Tests/Connection/SerializationTests.Command_contract_has_not_been_broken.approved.RequestDiagnostics.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
{
22
"token": "the-token",
3-
"id": "command-id",
43
"commandType": "RequestDiagnostics",
54
"command": {
65
"code": "the-code",

src/Microsoft.DotNet.Interactive.Tests/Connection/SerializationTests.Command_contract_has_not_been_broken.approved.RequestHoverText.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
{
22
"token": "the-token",
3-
"id": "command-id",
43
"commandType": "RequestHoverText",
54
"command": {
65
"code": "document-contents",

src/Microsoft.DotNet.Interactive.Tests/Connection/SerializationTests.Command_contract_has_not_been_broken.approved.RequestInput.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
{
22
"token": "the-token",
3-
"id": "command-id",
43
"commandType": "RequestInput",
54
"command": {
65
"prompt": "provide answer",

0 commit comments

Comments
 (0)