remove PlainTextFormatter.MaxProperties

Author: jonsequitur

docs/formatting.md

@@ -116,14 +116,6 @@ The following global settings can be set to change formatting behaviors:
 
   An optional type-specific list expansion limit
 
-* `PlainTextFormatter.MaxProperties` = 20
-
-  Indicates the maximum number of properties to show in the default plaintext display of arbitrary objects. If set to zero no properties are shown.
-
-* `HtmlFormatter.MaxProperties` = 20
-
-  Indicates the maximum number of properties to show in HTML table displays of arbitrary objects. If set to zero no properties are shown.
-
 ## HTML Formatting
 
 ### The `CSS` function

src/Microsoft.DotNet.Interactive.ApiCompatibility.Tests/ApiCompatibilityTests.Formatting_api_is_not_changed.approved.txt

@@ -151,7 +151,6 @@ Microsoft.DotNet.Interactive.Formatting
   public class JsonString : Microsoft.AspNetCore.Html.HtmlString, Microsoft.AspNetCore.Html.IHtmlContent
     .ctor(System.String json)
   public static class PlainTextFormatter
-    public static System.Int32 MaxProperties { get; set;}
     public static ITypeFormatter GetPreferredFormatterFor(System.Type type)
     public static ITypeFormatter GetPreferredFormatterFor<T>()
     public static System.Void WriteStartProperty(FormatContext context)

src/Microsoft.DotNet.Interactive.Formatting.Tests/PlainTextFormatterTests.Objects.cs

@@ -85,32 +85,6 @@ public void It_emits_a_default_maximum_number_of_properties()
     ...".ReplaceLineEndings());
         }
 
-        [Fact]
-        public void It_emits_a_configurable_maximum_number_of_properties()
-        {
-            var formatter = PlainTextFormatter.GetPreferredFormatterFor<ClassWithManyProperties>();
-            PlainTextFormatter.MaxProperties = 1;
-
-            var writer = new StringWriter();
-            formatter.Format(new ClassWithManyProperties(), writer);
-
-            var s = writer.ToString();
-            s.Should().Be($"ClassWithManyProperties{Environment.NewLine}    X1: 1{Environment.NewLine}    ...");
-        }
-
-        [Fact]
-        public void When_Zero_properties_chosen_just_ToString_is_used()
-        {
-            var formatter = PlainTextFormatter.GetPreferredFormatterFor<ClassWithManyPropertiesAndCustomToString>();
-            PlainTextFormatter.MaxProperties = 0;
-
-            var writer = new StringWriter();
-            formatter.Format(new ClassWithManyPropertiesAndCustomToString(), writer);
-
-            var s = writer.ToString();
-            s.Should().Be($"{typeof(ClassWithManyPropertiesAndCustomToString)} custom ToString value");
-        }
-
         [Fact]
         public void When_Zero_properties_available_to_choose_just_ToString_is_used()
         {

src/Microsoft.DotNet.Interactive.Formatting/PlainTextFormatter.cs

@@ -21,13 +21,6 @@ namespace Microsoft.DotNet.Interactive.Formatting;
 
 public static class PlainTextFormatter
 {
-    static PlainTextFormatter()
-    {
-        Formatter.Clearing += Initialize;
-
-        void Initialize() => MaxProperties = DefaultMaxProperties;
-    }
-
     public const string MimeType = "text/plain";
 
     public static ITypeFormatter GetPreferredFormatterFor(Type type) =>
@@ -36,14 +29,6 @@ public static ITypeFormatter GetPreferredFormatterFor(Type type) =>
     public static ITypeFormatter GetPreferredFormatterFor<T>() =>
         GetPreferredFormatterFor(typeof(T));
 
-    /// <summary>
-    ///   Indicates the maximum number of properties to show in the default plaintext display of arbitrary objects.
-    ///   If set to zero no properties are shown.
-    /// </summary>
-    public static int MaxProperties { get; set; } = DefaultMaxProperties;
-
-    private const int DefaultMaxProperties = 20;
-
     private const int NumberOfSpacesToIndent = 2;
 
     internal static ITypeFormatter GetDefaultFormatterForAnyObject(Type type, bool includeInternals = false) =>
@@ -72,10 +57,8 @@ internal static FormatDelegate<T> CreateFormatDelegate<T>(MemberInfo[] forMember
 
         bool FormatObject(T target, FormatContext context)
         {
-            var reducedAccessors = accessors.Take(Math.Max(0, MaxProperties)).ToArray();
-
             // If we haven't got any members to show, just resort to ToString()
-            if (reducedAccessors.Length == 0)
+            if (accessors.Length == 0)
             {
                 context.Writer.Write(target.ToString());
                 return true;
@@ -90,9 +73,9 @@ bool FormatObject(T target, FormatContext context)
                 context.Writer.WriteLine();
             }
 
-            for (var i = 0; i < reducedAccessors.Length; i++)
+            for (var i = 0; i < accessors.Length; i++)
             {
-                var accessor = reducedAccessors[i];
+                var accessor = accessors[i];
 
                 object value = accessor.GetValueOrException(target);
 
@@ -107,7 +90,7 @@ bool FormatObject(T target, FormatContext context)
                 }
             }
 
-            if (reducedAccessors.Length < accessors.Length)
+            if (accessors.Length < accessors.Length)
             {
                 WriteIndent(context);
                 context.Writer.Write("...");