Skip to content

Commit 8159c62

Browse files
committed
TypeScript fixes for updated documents contract
1 parent c05c48d commit 8159c62

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

src/dotnet-interactive-vscode-ads/src/notebookSerializers.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ import { Eol } from './vscode-common/interfaces';
1313
function toInteractiveDocumentElement(cell: vscode.NotebookCellData): contracts.InteractiveDocumentElement {
1414
const outputs = cell.outputs || [];
1515
return {
16+
executionOrder: cell.executionSummary?.executionOrder ?? 0,
1617
language: getSimpleLanguage(cell.languageId),
1718
contents: cell.value,
1819
outputs: outputs.map(vsCodeCellOutputToContractCellOutput)
@@ -29,7 +30,8 @@ async function deserializeNotebookByType(parserServer: NotebookParserServer, ser
2930

3031
async function serializeNotebookByType(parserServer: NotebookParserServer, serializationType: contracts.DocumentSerializationType, eol: Eol, data: vscode.NotebookData): Promise<Uint8Array> {
3132
const interactiveDocument: contracts.InteractiveDocument = {
32-
elements: data.cells.map(toInteractiveDocumentElement)
33+
elements: data.cells.map(toInteractiveDocumentElement),
34+
metadata: {}
3335
};
3436
const rawData = await parserServer.serializeNotebook(serializationType, eol, interactiveDocument);
3537
return rawData;

src/dotnet-interactive-vscode-insiders/src/notebookSerializers.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ import { Eol } from './vscode-common/interfaces';
1313
function toInteractiveDocumentElement(cell: vscode.NotebookCellData): contracts.InteractiveDocumentElement {
1414
const outputs = cell.outputs || [];
1515
return {
16+
executionOrder: cell.executionSummary?.executionOrder ?? 0,
1617
language: getSimpleLanguage(cell.languageId),
1718
contents: cell.value,
1819
outputs: outputs.map(vsCodeCellOutputToContractCellOutput)
@@ -29,7 +30,8 @@ async function deserializeNotebookByType(parserServer: NotebookParserServer, ser
2930

3031
async function serializeNotebookByType(parserServer: NotebookParserServer, serializationType: contracts.DocumentSerializationType, eol: Eol, data: vscode.NotebookData): Promise<Uint8Array> {
3132
const interactiveDocument: contracts.InteractiveDocument = {
32-
elements: data.cells.map(toInteractiveDocumentElement)
33+
elements: data.cells.map(toInteractiveDocumentElement),
34+
metadata: {}
3335
};
3436
const rawData = await parserServer.serializeNotebook(serializationType, eol, interactiveDocument);
3537
return rawData;

0 commit comments

Comments
 (0)