-
Notifications
You must be signed in to change notification settings - Fork 1.9k
FastTree does not work in UWP #2444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I believe all of these will throw PlatformNotSupportedException so one option is just to try/catch for that. ch.Trace("Working Set = {0} MB", currentProcess.WorkingSet64 / 1024 / 1024);
ch.Trace("Virtual Memory = {0} MB",
currentProcess.VirtualMemorySize64 / 1024 / 1024);
ch.Trace("Private Memory = {0} MB",
currentProcess.PrivateMemorySize64 / 1024 / 1024);
ch.Trace("Peak Working Set = {0} MB", currentProcess.PeakWorkingSet64 / 1024 / 1024);
ch.Trace("Peak Virtual Memory = {0} MB",
currentProcess.PeakVirtualMemorySize64 / 1024 / 1024); Incidentally I also see use of Process.Start to launch a URL (?) in FastTree
If that's URL I'm surprised if it works on .NET Core. In .NET Core, the default value of UseShellExecute is false. That must be true to launch the browser implicitly from a URL. If indeed that's a problem, you should explicitly set UseShellExecute to true for this launch. Further note that on UWP, if the value is true, it will throw another PlatformNotSupportedException because it doesn't support UseShellExecute=true. You could catch that, potentially. |
@eerhardt tells me the Process.Start is not an issue:
|
Any update on this, or even an ETA? |
I think this issue affects FastTree training on WebAssembly too. |
|
FastTree training on WebAssembly now works on ML.NET daily build with |
System information
Issue
FastTree is currently always attempting to
PrintMemoryStats
during training. This is an issue on some platforms (specifically UWP) because these APIs throw exceptions.We should at least have a way to disable these stats when on platforms that don't support it.
Try to train a FastTree model in a UWP app.
A
PlatformNotSupportedException
was thrown from the following method:machinelearning/src/Microsoft.ML.FastTree/FastTree.cs
Lines 458 to 483 in 6b1a0d3
I expected FastTree to work inside a UWP app.
Source code / logs
On UWP apps, you can't get certain information about local processes - it throws an exception:
The text was updated successfully, but these errors were encountered: