Skip to content

All linear trainers should be typed #2555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wschin opened this issue Feb 14, 2019 · 2 comments · Fixed by #2564
Closed

All linear trainers should be typed #2555

wschin opened this issue Feb 14, 2019 · 2 comments · Fixed by #2564
Assignees
Labels
API Issues pertaining the friendly API
Milestone

Comments

@wschin
Copy link
Member

wschin commented Feb 14, 2019

There are still some binary classification trainers to (generalized) linear models. As done in #2506, they all should be typed according to the types learned. They also should not do auto-calibration in API land.

We should also check if making other trainers typed is possible.

  • EnsembleTrainer
  • RegressionEnsembleTrainer
  • MulticlassDataPartitionEnsembleTrainer
  • MetaMulticlassTrainer
  • Ova related things
  • Stacking
  • TreeEnsembleFeaturizer
@wschin wschin added the bug Something isn't working label Feb 14, 2019
@wschin wschin self-assigned this Feb 14, 2019
@Ivanidzo4ka Ivanidzo4ka added API Issues pertaining the friendly API and removed bug Something isn't working labels Feb 14, 2019
@shauheen shauheen added this to the 0219 milestone Feb 15, 2019
@TomFinley
Copy link
Contributor

OK. The trouble with ensembling and meta-multiclass in particular is that the existing code has some provision (at least in its internals) to handle multiple types of trainers. This makes sense to me: is the type of trainer and its configuration for every class in, say, OVA, definitely going to be the same? It's not obvious to me that it must be so. So things like that I might prefer to keep as-is until we figure out a proper design. (Just so long as we aren't painting ourselves into a corner design wise to do so.)

@wschin
Copy link
Member Author

wschin commented Feb 15, 2019

Sounds good! Let's focus on linear classifiers at this stage.

@ghost ghost locked as resolved and limited conversation to collaborators Mar 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
API Issues pertaining the friendly API
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants