Skip to content

Microsoft.Data.Analysis: meaningless lines of code? #6754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nodakai opened this issue Jul 2, 2023 · 0 comments · Fixed by #6761
Closed

Microsoft.Data.Analysis: meaningless lines of code? #6754

nodakai opened this issue Jul 2, 2023 · 0 comments · Fixed by #6761

Comments

@nodakai
Copy link

nodakai commented Jul 2, 2023

machinelearning/src/Microsoft.Data.Analysis/DataFrame.IO.cs

Line 132 in 4c799ab

items[c] = items[c];

The inner loop seems to be meaningless

machinelearning/src/Microsoft.Data.Analysis/PrimitiveColumnContainer.cs

Line 36 in 4c799ab

if (Buffers.Count == 0)

Isn't the list guaranteed to be empty here within a ctor?
@ghost ghost added the untriaged New issue has not been triaged label Jul 2, 2023
@asmirnov82 asmirnov82 mentioned this issue Jul 11, 2023
Merged
@ghost ghost added the in-pr label Jul 11, 2023
@ghost ghost removed in-pr untriaged New issue has not been triaged labels Jul 11, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Aug 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Clean DataFrame meaningless code
1 participant
@nodakai