diff --git a/src/Microsoft.Data.Analysis/DataFrame.IO.cs b/src/Microsoft.Data.Analysis/DataFrame.IO.cs index 4a57397588..44448da008 100644 --- a/src/Microsoft.Data.Analysis/DataFrame.IO.cs +++ b/src/Microsoft.Data.Analysis/DataFrame.IO.cs @@ -127,10 +127,6 @@ public static DataFrame LoadFrom(IEnumerable> vals, IList<(string, foreach (var items in vals) { - for (var c = 0; c < items.Count; c++) - { - items[c] = items[c]; - } res.Append(items, inPlace: true); } diff --git a/src/Microsoft.Data.Analysis/PrimitiveColumnContainer.cs b/src/Microsoft.Data.Analysis/PrimitiveColumnContainer.cs index 745d1800e9..1e37ac2206 100644 --- a/src/Microsoft.Data.Analysis/PrimitiveColumnContainer.cs +++ b/src/Microsoft.Data.Analysis/PrimitiveColumnContainer.cs @@ -44,35 +44,6 @@ internal partial class PrimitiveColumnContainer : IEnumerable // Need a way to differentiate between columns initialized with default values and those with null values in SetValidityBit internal bool _modifyNullCountWhileIndexing = true; - public PrimitiveColumnContainer(T[] values) - { - values = values ?? throw new ArgumentNullException(nameof(values)); - long length = values.LongLength; - DataFrameBuffer curBuffer; - if (Buffers.Count == 0) - { - curBuffer = new DataFrameBuffer(); - Buffers.Add(curBuffer); - NullBitMapBuffers.Add(new DataFrameBuffer()); - } - else - { - curBuffer = (DataFrameBuffer)Buffers[Buffers.Count - 1]; - } - for (long i = 0; i < length; i++) - { - if (curBuffer.Length == ReadOnlyDataFrameBuffer.MaxCapacity) - { - curBuffer = new DataFrameBuffer(); - Buffers.Add(curBuffer); - NullBitMapBuffers.Add(new DataFrameBuffer()); - } - curBuffer.Append(values[i]); - SetValidityBit(Length, true); - Length++; - } - } - public PrimitiveColumnContainer(IEnumerable values) { values = values ?? throw new ArgumentNullException(nameof(values)); @@ -81,6 +52,7 @@ public PrimitiveColumnContainer(IEnumerable values) Append(value); } } + public PrimitiveColumnContainer(IEnumerable values) { values = values ?? throw new ArgumentNullException(nameof(values));