Skip to content

Add TargetType to Type_convert #6785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 25, 2023
Merged

Add TargetType to Type_convert #6785

merged 6 commits into from
Aug 25, 2023

Conversation

zewditu
Copy link
Contributor

@zewditu zewditu commented Aug 8, 2023

We are excited to review your PR.

So we can do the best job, please check:

  • There's a descriptive title that will make sense to other developers some time from now.
  • There's associated issues. All PR's should have issue(s) associated - unless a trivial self-evident change such as fixing a typo. You can use the format Fixes #nnnn in your description to cause GitHub to automatically close the issue(s) when your PR is merged.
  • Your change description explains what the change does, why you chose your approach, and anything else that reviewers should know.
  • You have included any necessary tests in the same PR.

zewditu
zewditu commented Aug 8, 2023
View reviewed changes
@LittleLittleCloud
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@codecov
Copy link

codecov bot commented Aug 14, 2023 •
edited
Loading

Codecov Report

Merging #6785 (a1859cd) into main (c28d5af) will decrease coverage by 0.02%.
The diff coverage is n/a.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #6785      +/-   ##
==========================================
- Coverage   69.04%   69.02%   -0.02%     
==========================================
  Files        1237     1237              
  Lines      252692   252692              
  Branches    26445    26445              
==========================================
- Hits       174461   174415      -46     
- Misses      71293    71349      +56     
+ Partials     6938     6928      -10
Flag Coverage Δ
Debug 69.02% <ø> (-0.02%) ⬇️
production 63.59% <ø> (-0.03%) ⬇️
test 88.83% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 9 files with indirect coverage changes

@JakeRadMSFT JakeRadMSFT merged commit 179f7dc into dotnet:main Aug 25, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Sep 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@LittleLittleCloud LittleLittleCloud LittleLittleCloud left review comments

@JakeRadMSFT JakeRadMSFT JakeRadMSFT approved these changes

Assignees

No one assigned

Labels

community-contribution

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zewditu @LittleLittleCloud @JakeRadMSFT