Skip to content

Commit 5cb8df4

Browse files
committed
Cleanup
1 parent 6d4e0d8 commit 5cb8df4

File tree

2 files changed

+12
-78
lines changed

2 files changed

+12
-78
lines changed

eng/pipelines/arcade/stage-device-tests.yml

Lines changed: 5 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -20,27 +20,8 @@ parameters:
2020
- name: runAsPublic
2121
type: boolean
2222
default: true
23-
- name: androidPool
24-
type: object
25-
- name: iosPool
26-
type: object
27-
- name: catalystPool
28-
type: object
29-
- name: windowsPool
30-
type: object
31-
default: 'dotnet'
32-
- name: iosVersions
33-
type: object
34-
default: [ 'latest' ]
35-
- name: iosDeviceVersions
36-
type: object
37-
default: [ '15' ]
38-
- name: androidApiLevels
39-
type: object
40-
default: [ 33 ]
41-
- name: catalystVersions
23+
- name: pool
4224
type: object
43-
default: [ 'latest' ]
4425
- name: helixProject
4526
type: string
4627
default: 'eng/helix_xharness.proj'
@@ -68,7 +49,7 @@ stages:
6849
- template: ${{ iif(eq(parameters.runAsPublic, 'true'), '/eng/common/templates/jobs/jobs.yml', '/eng/common/templates-official/jobs/jobs.yml@self') }}
6950
parameters:
7051
helixRepo: dotnet/maui
71-
pool: ${{ parameters.iosPool }}
52+
pool: ${{ parameters.pool }}
7253
enableMicrobuild: true
7354
enablePublishUsingPipelines: true
7455
enablePublishBuildAssets: true
@@ -118,8 +99,8 @@ stages:
11899
- template: ${{ iif(eq(parameters.runAsPublic, 'true'), '/eng/common/templates/jobs/jobs.yml', '/eng/common/templates-official/jobs/jobs.yml@self') }}
119100
parameters:
120101
helixRepo: dotnet/maui
121-
pool: ${{ parameters.iosPool }}
122-
enableMicrobuild: true
102+
pool: ${{ parameters.pool }}
103+
enableMicrobuild: false
123104
enablePublishUsingPipelines: true
124105
enablePublishBuildAssets: true
125106
enableTelemetry: true
@@ -128,7 +109,7 @@ stages:
128109
sourceIndexParams: ${{ parameters.sourceIndexParams }}
129110
publishAssetsImmediately: true
130111
enablePublishBuildArtifacts: true
131-
enablePublishTestResults: true
112+
enablePublishTestResults: false
132113
workspace:
133114
clean: all
134115
jobs:

eng/pipelines/device-tests.yml

Lines changed: 7 additions & 54 deletions
Original file line numberDiff line numberDiff line change
@@ -63,13 +63,6 @@ parameters:
6363
type: boolean
6464
default: false
6565

66-
- name: VM_IMAGE_HOST
67-
type: object
68-
default:
69-
name: NetCore-Public
70-
image: 1es-windows-2022
71-
os: windows
72-
7366
- name: androidPool
7467
type: object
7568
default:
@@ -112,15 +105,13 @@ parameters:
112105
stages:
113106
- ${{ each targetFrameworkVersion in parameters.targetFrameworkVersions }}:
114107

108+
# Run on dnceng-public (Helix)
115109
- ${{ if eq(variables['Build.DefinitionName'], 'maui-pr-devicetests') }}:
116110

111+
# Use Helix for iOS / Android and MacCatalyst Device Tests
117112
- template: /eng/pipelines/arcade/stage-device-tests.yml@self
118113
parameters:
119-
pool: ${{ parameters.VM_IMAGE_HOST }}
120-
androidPool: ${{ parameters.androidPool }}
121-
iosPool: ${{ parameters.iosPool }}
122-
catalystPool: ${{ parameters.catalystPool }}
123-
windowsPool: ${{ parameters.windowsPool }}
114+
pool: ${{ parameters.iosPool }}
124115
runAsPublic: true
125116
prepareSteps:
126117
- template: /eng/pipelines/common/provision.yml@self
@@ -135,61 +126,28 @@ stages:
135126
skipProvisioning: true
136127
skipXcode: true
137128

129+
# Just use the old way for Windows Device Tests
138130
- template: common/device-tests.yml
139131
parameters:
140-
androidPool: ${{ parameters.androidPool }}
141-
iosPool: ${{ parameters.iosPool }}
142-
catalystPool: ${{ parameters.catalystPool }}
143132
windowsPool: ${{ parameters.windowsPool }}
144-
agentPoolAccessToken: $(AgentPoolAccessToken)
145133
targetFrameworkVersion: ${{ targetFrameworkVersion }}
146-
${{ if or(parameters.BuildEverything, and(ne(variables['Build.Reason'], 'PullRequest'), eq(variables['System.TeamProject'], 'devdiv'))) }}:
147-
androidApiLevels: [ 33, 30, 29, 28, 27, 26, 25, 24, 23 ]
148-
iosVersions: [ 'simulator-18.0' ]
149-
catalystVersions: [ 'latest' ]
150-
windowsVersions: [ 'packaged', 'unpackaged' ]
151-
provisionatorChannel: ${{ parameters.provisionatorChannel }}
152-
skipProvisioning: ${{ or(not(parameters.UseProvisionator), false) }}
153-
${{ else }}:
154-
androidApiLevels: [ 33, 23 ]
155-
iosVersions: [ 'simulator-18.0' ]
156-
catalystVersions: [ 'latest' ]
157-
windowsVersions: [ 'packaged', 'unpackaged' ]
158-
provisionatorChannel: ${{ parameters.provisionatorChannel }}
159-
skipProvisioning: ${{ not(parameters.UseProvisionator) }}
134+
windowsVersions: [ 'packaged', 'unpackaged' ]
135+
skipProvisioning: true
160136
projects:
161137
- name: essentials
162138
desc: Essentials
163-
androidApiLevelsExclude: [ 25, 27 ] # Ignore for now API25 since the runs's are not stable
164-
androidConfiguration: 'Release'
165-
iOSConfiguration: 'Debug'
166139
windowsConfiguration: 'Debug'
167140
windowsPackageId: 'com.microsoft.maui.essentials.devicetests'
168-
android: $(System.DefaultWorkingDirectory)/src/Essentials/test/DeviceTests/Essentials.DeviceTests.csproj
169-
ios: $(System.DefaultWorkingDirectory)/src/Essentials/test/DeviceTests/Essentials.DeviceTests.csproj
170-
catalyst: $(System.DefaultWorkingDirectory)/src/Essentials/test/DeviceTests/Essentials.DeviceTests.csproj
171141
windows: $(System.DefaultWorkingDirectory)/src/Essentials/test/DeviceTests/Essentials.DeviceTests.csproj
172142
- name: graphics
173143
desc: Graphics
174-
androidApiLevelsExclude: [ 25 ] # Ignore for now API25 since the runs's are not stable
175-
androidConfiguration: 'Release'
176-
iOSConfiguration: 'Debug'
177144
windowsConfiguration: 'Debug'
178145
windowsPackageId: 'com.microsoft.maui.graphics.devicetests'
179-
android: $(System.DefaultWorkingDirectory)/src/Graphics/tests/DeviceTests/Graphics.DeviceTests.csproj
180-
ios: $(System.DefaultWorkingDirectory)/src/Graphics/tests/DeviceTests/Graphics.DeviceTests.csproj
181-
catalyst: $(System.DefaultWorkingDirectory)/src/Graphics/tests/DeviceTests/Graphics.DeviceTests.csproj
182146
windows: $(System.DefaultWorkingDirectory)/src/Graphics/tests/DeviceTests/Graphics.DeviceTests.csproj
183147
- name: core
184148
desc: Core
185-
androidApiLevelsExclude: [ 25 ] # Ignore for now API25 since the runs's are not stable
186-
androidConfiguration: 'Release'
187-
iOSConfiguration: 'Debug'
188149
windowsConfiguration: 'Debug'
189150
windowsPackageId: 'com.microsoft.maui.core.devicetests'
190-
android: $(System.DefaultWorkingDirectory)/src/Core/tests/DeviceTests/Core.DeviceTests.csproj
191-
ios: $(System.DefaultWorkingDirectory)/src/Core/tests/DeviceTests/Core.DeviceTests.csproj
192-
catalyst: $(System.DefaultWorkingDirectory)/src/Core/tests/DeviceTests/Core.DeviceTests.csproj
193151
windows: $(System.DefaultWorkingDirectory)/src/Core/tests/DeviceTests/Core.DeviceTests.csproj
194152
- name: controls
195153
desc: Controls
@@ -204,18 +162,13 @@ stages:
204162
windows: $(System.DefaultWorkingDirectory)/src/Controls/tests/DeviceTests/Controls.DeviceTests.csproj
205163
- name: blazorwebview
206164
desc: BlazorWebView
207-
androidApiLevelsExclude: [ 30, 29, 28, 27, 26, 25, 24, 23, 22, 21 ] # BlazorWebView requires a recent version of Chrome
208-
androidConfiguration: 'Release'
209-
iOSConfiguration: 'Debug'
210165
windowsConfiguration: 'Debug'
211166
windowsPackageId: 'Microsoft.Maui.MauiBlazorWebView.DeviceTests'
212-
android: $(System.DefaultWorkingDirectory)/src/BlazorWebView/tests/DeviceTests/MauiBlazorWebView.DeviceTests.csproj
213-
ios: $(System.DefaultWorkingDirectory)/src/BlazorWebView/tests/DeviceTests/MauiBlazorWebView.DeviceTests.csproj
214-
catalyst: $(System.DefaultWorkingDirectory)/src/BlazorWebView/tests/DeviceTests/MauiBlazorWebView.DeviceTests.csproj
215167
windows: $(System.DefaultWorkingDirectory)/src/BlazorWebView/tests/DeviceTests/MauiBlazorWebView.DeviceTests.csproj
216168
platforms:
217169
- windows
218170

171+
# Run on xamarin public instance
219172
- ${{ else }}:
220173

221174
- template: common/device-tests.yml

0 commit comments

Comments
 (0)