Skip to content

Commit a022c8e

Browse files
CopilotPureWeen
andcommitted
Remove Performance tracking calls from iOS ListView compatibility handlers
Co-authored-by: PureWeen <[email protected]>
1 parent 890f1ed commit a022c8e

File tree

3 files changed

+0
-20
lines changed

3 files changed

+0
-20
lines changed

src/Controls/src/Core/Compatibility/Handlers/ListView/iOS/CellRenderer.cs

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -48,8 +48,6 @@ protected override UITableViewCell CreatePlatformElement()
4848
public virtual UITableViewCell GetCell(Cell item, UITableViewCell reusableCell, UITableView tv)
4949
#pragma warning restore CS0618 // Type or member is obsolete
5050
{
51-
Performance.Start(out string reference);
52-
5351
var tvc = reusableCell as CellTableViewCell ?? new CellTableViewCell(UITableViewCellStyle.Default, item.GetType().FullName);
5452

5553
tvc.Cell = item;
@@ -68,7 +66,6 @@ public virtual UITableViewCell GetCell(Cell item, UITableViewCell reusableCell,
6866

6967
SetAccessibility(tvc, item);
7068

71-
Performance.Stop(reference);
7269
return tvc;
7370
}
7471

src/Controls/src/Core/Compatibility/Handlers/ListView/iOS/ListViewRenderer.cs

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1129,8 +1129,6 @@ public override UITableViewCell GetCell(UITableView tableView, NSIndexPath index
11291129
#pragma warning restore CS0618 // Type or member is obsolete
11301130
UITableViewCell platformCell;
11311131

1132-
Performance.Start(out string reference);
1133-
11341132
if (!_list.TryGetTarget(out var list))
11351133
return null;
11361134
var cachingStrategy = list.CachingStrategy;
@@ -1181,7 +1179,6 @@ public override UITableViewCell GetCell(UITableView tableView, NSIndexPath index
11811179
var bgColor = tableView.IndexPathForSelectedRow != null && tableView.IndexPathForSelectedRow.Equals(indexPath) ? UIColor.Clear : DefaultBackgroundColor;
11821180
SetCellBackgroundColor(platformCell, bgColor);
11831181
PreserveActivityIndicatorState(cell);
1184-
Performance.Stop(reference);
11851182

11861183
if (platformCell is ContextActionsCell contextActionsCell)
11871184
_contextActionsCells.Add(contextActionsCell);

src/Controls/src/Core/Compatibility/Handlers/ListView/iOS/ViewCellRenderer.cs

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,6 @@ public ViewCellRenderer()
2121
public override UITableViewCell GetCell(Cell item, UITableViewCell reusableCell, UITableView tv)
2222
#pragma warning restore CS0618 // Type or member is obsolete
2323
{
24-
Performance.Start(out string reference);
25-
2624
#pragma warning disable CS0618 // Type or member is obsolete
2725
var viewCell = (ViewCell)item;
2826
#pragma warning restore CS0618 // Type or member is obsolete
@@ -39,7 +37,6 @@ public override UITableViewCell GetCell(Cell item, UITableViewCell reusableCell,
3937

4038
SetAccessibility(cell, item);
4139

42-
Performance.Stop(reference);
4340
return cell;
4441
}
4542

@@ -99,8 +96,6 @@ void ViewCellPropertyChanged(object sender, PropertyChangedEventArgs e)
9996

10097
public override void LayoutSubviews()
10198
{
102-
Performance.Start(out string reference);
103-
10499
//This sets the content views frame.
105100
base.LayoutSubviews();
106101

@@ -121,14 +116,10 @@ public override void LayoutSubviews()
121116
var contentFrame = ContentView.Frame;
122117
handler.LayoutVirtualView(new RectangleF(0, 0, contentFrame.Width, contentFrame.Height));
123118
}
124-
125-
Performance.Stop(reference);
126119
}
127120

128121
public override SizeF SizeThatFits(SizeF size)
129122
{
130-
Performance.Start(out string reference);
131-
132123
if (!_rendererRef.TryGetTarget(out IPlatformViewHandler handler))
133124
return base.SizeThatFits(size);
134125

@@ -144,8 +135,6 @@ public override SizeF SizeThatFits(SizeF size)
144135
// make sure to add in the separator if needed
145136
var finalheight = (float)result.Value.Height + (SupressSeparator ? 0f : 1f) / UIScreen.MainScreen.Scale;
146137

147-
Performance.Stop(reference);
148-
149138
return new SizeF(size.Width, finalheight);
150139
}
151140

@@ -197,8 +186,6 @@ IPlatformViewHandler GetNewRenderer()
197186
void UpdateCell(ViewCell cell)
198187
#pragma warning restore CS0618 // Type or member is obsolete
199188
{
200-
Performance.Start(out string reference);
201-
202189
#pragma warning disable CS0618 // Type or member is obsolete
203190
if (ViewCell is ViewCell oldCell)
204191
{
@@ -243,7 +230,6 @@ void UpdateCell(ViewCell cell)
243230

244231
UpdateIsEnabled(cell.IsEnabled);
245232
cell.View.MeasureInvalidated += OnMeasureInvalidated;
246-
Performance.Stop(reference);
247233
}
248234

249235
void OnMeasureInvalidated(object sender, EventArgs e)

0 commit comments

Comments
 (0)