TextTransform Property Does Not Apply at Runtime When TextType="Html" Is Set on Label (#29700)

Author: kubaflo

src/Controls/src/Core/Platform/Android/Extensions/TextViewExtensions.cs

@@ -11,16 +11,17 @@ public static class TextViewExtensions
 	{
 		public static void UpdateText(this TextView textView, Label label)
 		{
+			string text = TextTransformUtilites.GetTransformedText(label.Text, label.TextTransform);
 			switch (label.TextType)
 			{
 				case TextType.Text:
 					if (label.FormattedText != null)
 						textView.TextFormatted = label.ToSpannableString();
 					else
-						textView.Text = TextTransformUtilites.GetTransformedText(label.Text, label.TextTransform);
+						textView.Text = text;
 					break;
 				case TextType.Html:
-					textView.UpdateTextHtml(label);
+					textView.UpdateTextHtml(text);
 					break;
 			}
 		}

src/Controls/src/Core/Platform/Windows/Extensions/TextBlockExtensions.cs

@@ -24,10 +24,12 @@ static void DetermineTruncatedTextWrapping(TextBlock textBlock) =>
 
 		public static void UpdateText(this TextBlock platformControl, Label label)
 		{
+			string text = TextTransformUtilites.GetTransformedText(label.Text, label.TextTransform);
+
 			switch (label.TextType)
 			{
 				case TextType.Html:
-					platformControl.UpdateTextHtml(label);
+					platformControl.UpdateTextHtml(label, text);
 					break;
 
 				default:
@@ -39,7 +41,7 @@ public static void UpdateText(this TextBlock platformControl, Label label)
 						{
 							platformControl.TextHighlighters.Clear();
 						}
-						platformControl.Text = TextTransformUtilites.GetTransformedText(label.Text, label.TextTransform);
+						platformControl.Text = text;
 					}
 					break;
 			}

src/Controls/src/Core/Platform/iOS/Extensions/LabelExtensions.cs

@@ -11,6 +11,8 @@ public static class LabelExtensions
 	{
 		public static void UpdateText(this UILabel platformLabel, Label label)
 		{
+			var text = TextTransformUtilites.GetTransformedText(label.Text, label.TextTransform);
+			
 			switch (label.TextType)
 			{
 				case TextType.Html:
@@ -21,7 +23,7 @@ public static void UpdateText(this UILabel platformLabel, Label label)
 					// will be just disappear once we switch.
 					CoreFoundation.DispatchQueue.MainQueue.DispatchAsync(() =>
 					{
-						platformLabel.UpdateTextHtml(label);
+						platformLabel.UpdateTextHtml(text);
 
 						if (label.Handler is LabelHandler labelHandler)
 							Label.MapFormatting(labelHandler, label);
@@ -42,7 +44,7 @@ public static void UpdateText(this UILabel platformLabel, Label label)
 							platformLabel.AttributedText = null;
 						}
 
-						platformLabel.Text = TextTransformUtilites.GetTransformedText(label.Text, label.TextTransform);
+						platformLabel.Text = text;
 					}
 					break;
 			}

src/Controls/tests/TestCases.HostApp/Issues/Issue29700.xaml

@@ -0,0 +1,15 @@
+<?xml version="1.0" encoding="utf-8" ?>
+<ContentPage xmlns="http://schemas.microsoft.com/dotnet/2021/maui"
+             xmlns:x="http://schemas.microsoft.com/winfx/2009/xaml"
+             x:Class="Maui.Controls.Sample.Issues.Issue29700"
+             Title="29700">
+    <VerticalStackLayout>
+        <Label Text="Hello, World"
+               AutomationId="TestLabel"
+               x:Name="TestLabel"
+               TextType="Html"/>
+        <Button Text="Change text transform"
+                AutomationId="ChangeTextTransformButton"
+                Clicked="Button_Clicked"/>
+    </VerticalStackLayout>
+</ContentPage>

src/Controls/tests/TestCases.HostApp/Issues/Issue29700.xaml.cs

@@ -0,0 +1,21 @@
+namespace Maui.Controls.Sample.Issues;
+
+[Issue(IssueTracker.Github, 29700, "TextTransform Property Does Not Apply at Runtime When TextType='Html'")]
+public partial class Issue29700 : ContentPage
+{
+	public Issue29700()
+	{
+		InitializeComponent();
+	}
+
+	private void Button_Clicked(object sender, EventArgs e)
+	{
+		if (TestLabel.TextTransform == TextTransform.Default)
+			TestLabel.TextTransform = TextTransform.Uppercase;
+		else if (TestLabel.TextTransform == TextTransform.Uppercase)
+			TestLabel.TextTransform = TextTransform.Lowercase;
+		else
+			TestLabel.TextTransform = TextTransform.None;
+	}
+
+}

src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue29700.cs

@@ -0,0 +1,29 @@
+using NUnit.Framework;
+using UITest.Appium;
+using UITest.Core;
+
+namespace Microsoft.Maui.TestCases.Tests.Issues
+{
+	public class Issue29700 : _IssuesUITest
+	{
+		public Issue29700(TestDevice testDevice) : base(testDevice)
+		{
+		}
+
+		public override string Issue => "TextTransform Property Does Not Apply at Runtime When TextType='Html'";
+
+		[Test]
+		[Category(UITestCategories.Label)]
+		public void TextTransformPropertyAppliesAtRuntime()
+		{
+			var label = App.WaitForElement("TestLabel");
+			Assert.That(label.GetText(), Is.EqualTo("Hello, World"));
+			App.Tap("ChangeTextTransformButton");
+			Assert.That(label.GetText(), Is.EqualTo("HELLO, WORLD"));
+			App.Tap("ChangeTextTransformButton");
+			Assert.That(label.GetText(), Is.EqualTo("hello, world"));
+			App.Tap("ChangeTextTransformButton");
+			Assert.That(label.GetText(), Is.EqualTo("Hello, World"));
+		}
+	}
+}

src/Core/src/Platform/Android/TextViewExtensions.cs

@@ -19,6 +19,11 @@ public static void UpdateTextPlainText(this TextView textView, IText label)
 		public static void UpdateTextHtml(this TextView textView, ILabel label)
 		{
 			var text = label.Text ?? string.Empty;
+			textView.UpdateTextHtml(text);
+		}
+
+		internal static void UpdateTextHtml(this TextView textView, string text)
+		{
 			var htmlText = WebUtility.HtmlDecode(text);
 
 			if (OperatingSystem.IsAndroidVersionAtLeast(24))

src/Core/src/Platform/Windows/TextBlockExtensions.cs

@@ -85,10 +85,8 @@ public static void UpdateVerticalTextAlignment(this TextBlock platformControl, I
 			platformControl.VerticalAlignment = label.VerticalTextAlignment.ToPlatformVerticalAlignment();
 		}
 
-		internal static void UpdateTextHtml(this TextBlock platformControl, ILabel label)
+		internal static void UpdateTextHtml(this TextBlock platformControl, ILabel label, string text)
 		{
-			var text = label.Text ?? string.Empty;
-
 			// Just in case we are not given text with elements.
 			var modifiedText = string.Format("<div>{0}</div>", text);
 			modifiedText = Regex.Replace(modifiedText, "<br>", "<br></br>", RegexOptions.IgnoreCase);

src/Core/src/Platform/iOS/LabelExtensions.cs

@@ -73,10 +73,8 @@ public static void UpdateLineHeight(this UILabel platformLabel, ILabel label)
 				platformLabel.AttributedText = modAttrText;
 		}
 
-		internal static void UpdateTextHtml(this UILabel platformLabel, ILabel label)
+		internal static void UpdateTextHtml(this UILabel platformLabel, string text)
 		{
-			string text = label.Text ?? string.Empty;
-
 			var attr = new NSAttributedStringDocumentAttributes
 			{
 				DocumentType = NSDocumentType.HTML,