Merge pull request #1325 from dotnet/dev/bartde/address_some_warnings

Address a few warnings.

Author: bartdesmet

Rx.NET/Source/src/Microsoft.Reactive.Testing/ReactiveAssert.cs

@@ -24,11 +24,11 @@ private static string Message<T>(IEnumerable<T> actual, IEnumerable<T> expected)
             sb.AppendLine();
             sb.Append("Expected: [");
             sb.Append(string.Join(", ", expected.Select(x => x.ToString()).ToArray()));
-            sb.Append("]");
+            sb.Append(']');
             sb.AppendLine();
             sb.Append("Actual..: [");
             sb.Append(string.Join(", ", actual.Select(x => x.ToString()).ToArray()));
-            sb.Append("]");
+            sb.Append(']');
             sb.AppendLine();
             return sb.ToString();
         }

Rx.NET/Source/src/System.Reactive/Concurrency/EventLoopScheduler.cs

@@ -355,7 +355,7 @@ private void Run()
                             {
                                 item.Invoke();
                             }
-                            catch (ObjectDisposedException ex) when (nameof(EventLoopScheduler).Equals(ex.ObjectName))
+                            catch (ObjectDisposedException ex) when (ex.ObjectName == nameof(EventLoopScheduler))
                             {
                                 // Since we are not inside the lock at this point
                                 // the scheduler can be disposed before the item had a chance to run

Rx.NET/Source/src/System.Reactive/Linq/QueryLanguage.Creation.cs

@@ -384,7 +384,7 @@ public virtual IObservable<TResult> Repeat<TResult>(TResult value, IScheduler sc
             return Repeat_(value, scheduler);
         }
 
-        private IObservable<TResult> Repeat_<TResult>(TResult value, IScheduler scheduler)
+        private static IObservable<TResult> Repeat_<TResult>(TResult value, IScheduler scheduler)
         {
             var longRunning = scheduler.AsLongRunning();
             if (longRunning != null)
@@ -404,7 +404,7 @@ public virtual IObservable<TResult> Repeat<TResult>(TResult value, int repeatCou
             return Repeat_(value, repeatCount, scheduler);
         }
 
-        private IObservable<TResult> Repeat_<TResult>(TResult value, int repeatCount, IScheduler scheduler)
+        private static IObservable<TResult> Repeat_<TResult>(TResult value, int repeatCount, IScheduler scheduler)
         {
             var longRunning = scheduler.AsLongRunning();
             if (longRunning != null)

Rx.NET/Source/src/System.Reactive/Platforms/UWP/Concurrency/CoreDispatcherScheduler.cs

@@ -156,7 +156,7 @@ private DispatcherQueue CreateDispatcherQueue()
         }
 
         /// <summary>
-        /// Schedules an action to be executed after <paramref name="dueTime"/> on the dispatcher, using a <see cref="DispatcherTimer"/> object.
+        /// Schedules an action to be executed after <paramref name="dueTime"/> on the dispatcher, using a <see cref="DispatcherQueueTimer"/> object.
         /// </summary>
         /// <typeparam name="TState">The type of the state passed to the scheduled action.</typeparam>
         /// <param name="state">State passed to the action to be executed.</param>
@@ -221,7 +221,7 @@ private IDisposable ScheduleSlow<TState>(TState state, TimeSpan dueTime, Func<IS
         }
 
         /// <summary>
-        /// Schedules a periodic piece of work on the dispatcher, using a <see cref="DispatcherTimer"/> object.
+        /// Schedules a periodic piece of work on the dispatcher, using a <see cref="DispatcherQueueTimer"/> object.
         /// </summary>
         /// <typeparam name="TState">The type of the state passed to the scheduled action.</typeparam>
         /// <param name="state">Initial state passed to the action upon the first iteration.</param>

Rx.NET/Source/src/System.Reactive/Subjects/AsyncSubject.cs

@@ -322,7 +322,7 @@ internal bool IsDisposed()
 
         #region IDisposable implementation
 
-        private void ThrowDisposed()
+        private static void ThrowDisposed()
         {
             throw new ObjectDisposedException(string.Empty);
         }