Skip to content

Does setting ContinuousIntegrationBuild also set Deterministic? #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AshleighAdams opened this issue Nov 5, 2021 · 5 comments
Closed

Comments

@AshleighAdams
Copy link

I'm converting a project over to use this package, and I currently have something akin to:

<PropertyGroup Condition="'$(CI)' != ''">
  <ContinuousIntegrationBuild>true</ContinuousIntegrationBuild>
  <Deterministic>true</Deterministic>
</PropertyGroup>

I suspect that setting ContinuousIntegrationBuild is going to also set Deterministic?

@wapplegate
Copy link

A little late, but it looks like it sets ContinuousIntegrationBuild to true dynamically when running in a CI environment:

https://github.com/dotnet/reproducible-builds/blob/main/src/DotNet.ReproducibleBuilds/DotNet.ReproducibleBuilds.props

You can see the props file includes conditions for multiple CI systems.

@AshleighAdams
Copy link
Author

@wapplegate Yeah, I see that, but I can't figure out if Deterministic will also be set to true as a consequence of ContinuousIntegrationBuild being set, or if I need to keep doing that one manually in my projects :(

@wapplegate
Copy link

wapplegate commented Mar 24, 2022

Yeah my bad I read that a little quick. If you remove:

<Deterministic>true</Deterministic>

Does it actually make a difference? I was under the assumption it wasn't required.

@dferretti
Copy link

IIRC Deterministic is enabled by default nowadays:
original PR way back when: dotnet/sdk#153
current SDK: https://github.com/dotnet/sdk/blob/main/src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Sdk.props#L34

from a quick search in the SDK repo I don't think the ContinuousIntegrationBuild property has anything to do with Deterministic

@AshleighAdams
Copy link
Author

Looks like that's the answer @dferretti, thanks. Will close this now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants