Extensions: rename syntax node

Author: jcouv

src/Compilers/CSharp/CSharpAnalyzerDriver/CSharpDeclarationComputer.cs

@@ -122,7 +122,7 @@ private static void ComputeDeclarations(
                         goto case SyntaxKind.InterfaceDeclaration;
                     }
                 case SyntaxKind.InterfaceDeclaration:
-                case SyntaxKind.ExtensionDeclaration:
+                case SyntaxKind.ExtensionBlockDeclaration:
                     {
                         var t = (TypeDeclarationSyntax)node;
                         foreach (var decl in t.Members)

src/Compilers/CSharp/Portable/Binder/BinderFactory.BinderFactoryVisitor.cs

@@ -815,7 +815,7 @@ public override Binder VisitInterfaceDeclaration(InterfaceDeclarationSyntax node
             public override Binder VisitRecordDeclaration(RecordDeclarationSyntax node)
                 => VisitTypeDeclarationCore(node);
 
-            public override Binder VisitExtensionDeclaration(ExtensionDeclarationSyntax node)
+            public override Binder VisitExtensionBlockDeclaration(ExtensionBlockDeclarationSyntax node)
                 => VisitTypeDeclarationCore(node);
 
             public sealed override Binder VisitNamespaceDeclaration(NamespaceDeclarationSyntax parent)
@@ -1248,7 +1248,7 @@ private Binder GetParameterNameAttributeValueBinder(MemberDeclarationSyntax memb
 
                     return new WithParametersBinder(method.Parameters, nextBinder);
                 }
-                else if (memberSyntax is ExtensionDeclarationSyntax extensionDeclaration)
+                else if (memberSyntax is ExtensionBlockDeclarationSyntax extensionDeclaration)
                 {
                     Binder outerBinder = VisitCore(memberSyntax);
                     SourceNamedTypeSymbol type = ((NamespaceOrTypeSymbol)outerBinder.ContainingMemberOrLambda).GetSourceTypeMember((TypeDeclarationSyntax)memberSyntax);

src/Compilers/CSharp/Portable/Compilation/SyntaxTreeSemanticModel.cs

@@ -1381,7 +1381,7 @@ private NamedTypeSymbol GetDeclaredType(BaseTypeDeclarationSyntax declarationSyn
         {
             Debug.Assert(declarationSyntax != null);
 
-            if (declarationSyntax is ExtensionDeclarationSyntax extensionDeclaration)
+            if (declarationSyntax is ExtensionBlockDeclarationSyntax extensionDeclaration)
             {
                 return GetDeclaredExtension(extensionDeclaration);
             }
@@ -1390,7 +1390,7 @@ private NamedTypeSymbol GetDeclaredType(BaseTypeDeclarationSyntax declarationSyn
             return GetDeclaredNamedType(declarationSyntax, name);
         }
 
-        private NamedTypeSymbol GetDeclaredExtension(ExtensionDeclarationSyntax extensionDeclaration)
+        private NamedTypeSymbol GetDeclaredExtension(ExtensionBlockDeclarationSyntax extensionDeclaration)
         {
             Debug.Assert(extensionDeclaration != null);
 
@@ -2033,7 +2033,7 @@ private ParameterSymbol GetExtensionParameterSymbol(
         {
             Debug.Assert(parameter != null);
 
-            if (parameter.Parent is not ParameterListSyntax { Parent: ExtensionDeclarationSyntax extensionDecl })
+            if (parameter.Parent is not ParameterListSyntax { Parent: ExtensionBlockDeclarationSyntax extensionDecl })
             {
                 return null;
             }

src/Compilers/CSharp/Portable/Declarations/DeclarationKind.cs

@@ -43,7 +43,7 @@ internal static DeclarationKind ToDeclarationKind(this SyntaxKind kind)
                 case SyntaxKind.DelegateDeclaration: return DeclarationKind.Delegate;
                 case SyntaxKind.RecordDeclaration: return DeclarationKind.Record;
                 case SyntaxKind.RecordStructDeclaration: return DeclarationKind.RecordStruct;
-                case SyntaxKind.ExtensionDeclaration: return DeclarationKind.Extension;
+                case SyntaxKind.ExtensionBlockDeclaration: return DeclarationKind.Extension;
                 default:
                     throw ExceptionUtilities.UnexpectedValue(kind);
             }

src/Compilers/CSharp/Portable/Declarations/DeclarationTreeBuilder.cs

@@ -681,7 +681,7 @@ public override SingleNamespaceOrTypeDeclaration VisitRecordDeclaration(RecordDe
             return VisitTypeDeclaration(node, declarationKind);
         }
 
-        public override SingleNamespaceOrTypeDeclaration VisitExtensionDeclaration(ExtensionDeclarationSyntax node)
+        public override SingleNamespaceOrTypeDeclaration VisitExtensionBlockDeclaration(ExtensionBlockDeclarationSyntax node)
         {
             return VisitTypeDeclaration(node, DeclarationKind.Extension);
         }
@@ -944,7 +944,7 @@ private BoxedMemberNames GetNonTypeMemberNames(
                     anyMethodHadExtensionSyntax = true;
                 }
 
-                if (!anyExtensionDeclarationSyntax && member.Kind == SyntaxKind.ExtensionDeclaration)
+                if (!anyExtensionDeclarationSyntax && member.Kind == SyntaxKind.ExtensionBlockDeclaration)
                 {
                     anyExtensionDeclarationSyntax = true;
                 }
@@ -1107,7 +1107,7 @@ private static bool CheckMemberForAttributes(Syntax.InternalSyntax.CSharpSyntaxN
                 case SyntaxKind.EnumDeclaration:
                 case SyntaxKind.RecordDeclaration:
                 case SyntaxKind.RecordStructDeclaration:
-                case SyntaxKind.ExtensionDeclaration:
+                case SyntaxKind.ExtensionBlockDeclaration:
                     return (((Syntax.InternalSyntax.BaseTypeDeclarationSyntax)member).AttributeLists).Any();
 
                 case SyntaxKind.DelegateDeclaration:

src/Compilers/CSharp/Portable/Declarations/MergedTypeDeclaration.cs

@@ -78,7 +78,7 @@ public ImmutableArray<SyntaxList<AttributeListSyntax>> GetAttributeDeclarations(
                     case SyntaxKind.InterfaceDeclaration:
                     case SyntaxKind.RecordDeclaration:
                     case SyntaxKind.RecordStructDeclaration:
-                    case SyntaxKind.ExtensionDeclaration:
+                    case SyntaxKind.ExtensionBlockDeclaration:
                         attributesSyntaxList = ((TypeDeclarationSyntax)typeDecl).AttributeLists;
                         break;
 

src/Compilers/CSharp/Portable/Declarations/SingleTypeDeclaration.cs

@@ -69,7 +69,7 @@ internal enum TypeDeclarationFlags : ushort
             HasPrimaryConstructor = 1 << 11,
 
             /// <summary>
-            /// Set when <see cref="Syntax.ExtensionDeclarationSyntax"/> is present.
+            /// Set when <see cref="Syntax.ExtensionBlockDeclarationSyntax"/> is present.
             /// </summary>            
             AnyExtensionDeclarationSyntax = 1 << 12,
         }