Use indexes and ranges

davidwengier · davidwengier · commit 5f6d8e564f91 · 2020-11-05T17:15:31.000+11:00
diff --git a/src/EditorFeatures/Core.Cocoa/Snippets/SnippetFunctions/AbstractSnippetFunctionGenerateSwitchCases.cs b/src/EditorFeatures/Core.Cocoa/Snippets/SnippetFunctions/AbstractSnippetFunctionGenerateSwitchCases.cs
@@ -24,8 +24,8 @@ public AbstractSnippetFunctionGenerateSwitchCases(AbstractSnippetExpansionClient
             : base(snippetExpansionClient, subjectBuffer)
         {
             this.CaseGenerationLocationField = caseGenerationLocationField;
-            this.SwitchExpressionField = (switchExpressionField.Length >= 2 && switchExpressionField[0] == '$' && switchExpressionField[switchExpressionField.Length - 1] == '$')
-                ? switchExpressionField.Substring(1, switchExpressionField.Length - 2) : switchExpressionField;
+            this.SwitchExpressionField = (switchExpressionField.Length >= 2 && switchExpressionField[0] == '$' && switchExpressionField[^1] == '$')
+                ? switchExpressionField[1..^1] : switchExpressionField;
         }
 
         protected abstract bool TryGetEnumTypeSymbol(CancellationToken cancellationToken, [NotNullWhen(returnValue: true)] out ITypeSymbol? typeSymbol);

Original file line number	Diff line number	Diff line change
`@@ -24,8 +24,8 @@ public AbstractSnippetFunctionGenerateSwitchCases(AbstractSnippetExpansionClient`
`24`	`24`	`: base(snippetExpansionClient, subjectBuffer)`
`25`	`25`	`{`
`26`	`26`	`this.CaseGenerationLocationField = caseGenerationLocationField;`
`27`		`- this.SwitchExpressionField = (switchExpressionField.Length >= 2 && switchExpressionField[0] == '$' && switchExpressionField[switchExpressionField.Length - 1] == '$')`
`28`		`- ? switchExpressionField.Substring(1, switchExpressionField.Length - 2) : switchExpressionField;`
	`27`	`+ this.SwitchExpressionField = (switchExpressionField.Length >= 2 && switchExpressionField[0] == '$' && switchExpressionField[^1] == '$')`
	`28`	`+ ? switchExpressionField[1..^1] : switchExpressionField;`
`29`	`29`	`}`
`30`	`30`
`31`	`31`	`protected abstract bool TryGetEnumTypeSymbol(CancellationToken cancellationToken, [NotNullWhen(returnValue: true)] out ITypeSymbol? typeSymbol);`