-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Improve compiler error recovery for null coalesce assignment operator #80907
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Improve compiler error recovery for null coalesce assignment operator #80907
Conversation
|
Done with review pass (commit 1), tests were not looked at. It looks like the change affects scenarios that fall outside of the stated goal of this PR. I suggest making adjustments to affect only error scenarios with target typed |
|
This PR is based on the following semantics of
This semantics is independent on what shape the right-hand side is. Therefore, limiting this recovery to only |
I do not think this is accurate. #Closed |
|
Done with review pass (commit 2), tests were not looked at. Some of the previously made comments still look relevant. Also, an alternative way to suppress cascading diagnostics was suggested. #Closed |
|
@DoctorKrolic It looks like PR validation is failing #Closed |
src/EditorFeatures/Test2/IntelliSense/CSharpCompletionCommandHandlerTests.vb
Outdated
Show resolved
Hide resolved
AlekseyTs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (commit 10)
|
@dotnet/roslyn-compiler For a second review on a community PR |
Redo of #74218
Related to #73894