Fix RCS1077 (#1023)

Author: josefpihrt

ChangeLog.md

@@ -14,8 +14,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - [CLI] Add nullable reference type modifier when creating a list of symbols (`list-symbols` command) ([#1013](https://github.com/josefpihrt/roslynator/pull/1013)).
 - Add/remove blank line after file scoped namespace declaration ([RCS0060](https://github.com/JosefPihrt/Roslynator/blob/main/docs/analyzers/RCS0060.md)) ([#1014](https://github.com/josefpihrt/roslynator/pull/1014)).
 - Do not remove overriding member in record ([RCS1132](https://github.com/JosefPihrt/Roslynator/blob/main/docs/analyzers/RCS1132.md)) ([#1015](https://github.com/josefpihrt/roslynator/pull/1015)).
-- Do not remove parameterless empty constructor in a struct with field initializers ([RCS1074](https://github.com/JosefPihrt/Roslynator/blob/main/docs/analyzers/RCS1074.md)) ([#1020](https://github.com/josefpihrt/roslynator/pull/1020)).
-- Do not suggest to use generic event handler ([RCS1159](https://github.com/JosefPihrt/Roslynator/blob/main/docs/analyzers/RCS1159.md)) ([#1019](https://github.com/josefpihrt/roslynator/pull/1019)).
+- Do not remove parameterless empty constructor in a struct with field initializers ([RCS1074](https://github.com/JosefPihrt/Roslynator/blob/main/docs/analyzers/RCS1074.md)) ([#1021](https://github.com/josefpihrt/roslynator/pull/1021)).
+- Do not suggest to use generic event handler ([RCS1159](https://github.com/JosefPihrt/Roslynator/blob/main/docs/analyzers/RCS1159.md)) ([#1022](https://github.com/josefpihrt/roslynator/pull/1022)).
+- Fix ([RCS1077](https://github.com/JosefPihrt/Roslynator/blob/main/docs/analyzers/RCS1077.md)) ([#1023](https://github.com/josefpihrt/roslynator/pull/1023)).
 
 ## [4.2.0] - 2022-11-27
 

src/Analyzers/CSharp/Analysis/OptimizeLinqMethodCallAnalysis.cs

@@ -454,6 +454,9 @@ public static void AnalyzeOfType(
         if (typeSymbol?.IsErrorType() != false)
             return;
 
+        if (!typeSymbol.IsValueType)
+            return;
+
         ITypeSymbol typeSymbol2 = semanticModel.GetTypeSymbol(invocationInfo.Expression, cancellationToken);
 
         cancellationToken.ThrowIfCancellationRequested();

src/Tests/Analyzers.Tests/RCS1077OptimizeLinqMethodCallTests.cs

@@ -389,38 +389,6 @@ void M()
 ", source, expected);
     }
 
-    [Fact, Trait(Traits.Analyzer, DiagnosticIdentifiers.OptimizeLinqMethodCall)]
-    public async Task Test_OptimizeOfType_ReferenceType()
-    {
-        await VerifyDiagnosticAndFixAsync(@"
-using System.Collections.Generic;
-using System.Linq;
-
-class C
-{
-    void M()
-    {
-        var items = new List<C>();
-
-        var q = items.[|OfType<C>()|];
-    }
-}
-", @"
-using System.Collections.Generic;
-using System.Linq;
-
-class C
-{
-    void M()
-    {
-        var items = new List<C>();
-
-        var q = items.Where(f => f != null);
-    }
-}
-");
-    }
-
     [Fact, Trait(Traits.Analyzer, DiagnosticIdentifiers.OptimizeLinqMethodCall)]
     public async Task Test_OptimizeOfType_ValueType()
     {