JIT: fix assert in assertion prop (#106146)

AndyAyersMS · pull[bot] · commit 14064278620d · 2024-10-09T14:11:02.000Z
`optAssertionPropGlobal_RelOp` had branch where it was expecting both op2 and op1 to be locals, but only had verified that op2 was. Add an extra check. Fixes #105670
diff --git a/src/coreclr/jit/assertionprop.cpp b/src/coreclr/jit/assertionprop.cpp
@@ -4409,7 +4409,7 @@ GenTree* Compiler::optAssertionPropGlobal_RelOp(ASSERT_VALARG_TP assertions, Gen
         }
     }
     // If the assertion involves "op2" and "op1" is also a local var, then just morph the tree.
-    else if (op2->gtOper == GT_LCL_VAR)
+    else if (op1->OperIs(GT_LCL_VAR) && op2->OperIs(GT_LCL_VAR))
     {
 #ifdef DEBUG
         if (verbose)

Original file line number	Diff line number	Diff line change
`@@ -4409,7 +4409,7 @@ GenTree* Compiler::optAssertionPropGlobal_RelOp(ASSERT_VALARG_TP assertions, Gen`
`4409`	`4409`	`}`
`4410`	`4410`	`}`
`4411`	`4411`	`// If the assertion involves "op2" and "op1" is also a local var, then just morph the tree.`
`4412`		`- else if (op2->gtOper == GT_LCL_VAR)`
	`4412`	`+ else if (op1->OperIs(GT_LCL_VAR) && op2->OperIs(GT_LCL_VAR))`
`4413`	`4413`	`{`
`4414`	`4414`	`#ifdef DEBUG`
`4415`	`4415`	`if (verbose)`