Skip to content

Commit 3a6a06b

Browse files
[Json] Remove unnecessary Debug.Asserts (#116833)
* [Json] Remove unnecessary Debug.Asserts * tests
1 parent 05105f1 commit 3a6a06b

File tree

4 files changed

+16
-2
lines changed

4 files changed

+16
-2
lines changed

src/libraries/System.Text.Json/src/System/Text/Json/Serialization/Converters/Node/JsonArrayConverter.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,6 @@ public override void Write(Utf8JsonWriter writer, JsonArray? value, JsonSerializ
3131
case JsonTokenType.Null:
3232
return null;
3333
default:
34-
Debug.Assert(false);
3534
throw ThrowHelper.GetInvalidOperationException_ExpectedArray(reader.TokenType);
3635
}
3736
}

src/libraries/System.Text.Json/src/System/Text/Json/Serialization/Converters/Node/JsonObjectConverter.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,6 @@ public override void Write(Utf8JsonWriter writer, JsonObject? value, JsonSeriali
6969
case JsonTokenType.Null:
7070
return null;
7171
default:
72-
Debug.Assert(false);
7372
throw ThrowHelper.GetInvalidOperationException_ExpectedObject(reader.TokenType);
7473
}
7574
}

src/libraries/System.Text.Json/tests/System.Text.Json.Tests/JsonNode/JsonArrayTests.cs

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -889,5 +889,13 @@ public static void RemoveRange_FreshlyDeserialized()
889889

890890
static JsonArray PrepareData() => JsonSerializer.Deserialize<JsonArray>("[1,2,3,4,5]");
891891
}
892+
893+
[Theory]
894+
[InlineData("42")]
895+
[InlineData("{}")]
896+
public static void Deserialize_WrongType(string json)
897+
{
898+
Assert.Throws<JsonException>(() => JsonSerializer.Deserialize<JsonArray>(json));
899+
}
892900
}
893901
}

src/libraries/System.Text.Json/tests/System.Text.Json.Tests/JsonNode/JsonObjectTests.cs

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1718,5 +1718,13 @@ public static void JsonObject_NestedDuplicatePropertyCaseInsensitiveThrows()
17181718
() => JsonSerializer.Deserialize<JsonNode>(jsonPayload, options),
17191719
"An item with the same key has already been added.");
17201720
}
1721+
1722+
[Theory]
1723+
[InlineData("42")]
1724+
[InlineData("[]")]
1725+
public static void Deserialize_WrongType(string json)
1726+
{
1727+
Assert.Throws<JsonException>(() => JsonSerializer.Deserialize<JsonObject>(json));
1728+
}
17211729
}
17221730
}

0 commit comments

Comments
 (0)