Remove assert from Http3Connection.SendAsync (#74348) (#74484)

rzikm · web-flow · commit 5736b6e60aaa · 2022-08-24T08:41:29.000-07:00
diff --git a/src/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/Http3Connection.cs b/src/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/Http3Connection.cs
@@ -240,7 +240,7 @@ public async Task<HttpResponseMessage> SendAsync(HttpRequestMessage request, lon
             catch (QuicException ex) when (ex.QuicError == QuicError.OperationAborted)
             {
                 // This will happen if we aborted _connection somewhere and we have pending OpenOutboundStreamAsync call.
-                Debug.Assert(_abortException is not null);
+                // note that _abortException may be null if we closed the connection in response to a GOAWAY frame
                 throw new HttpRequestException(SR.net_http_client_execution_error, _abortException, RequestRetryType.RetryOnConnectionFailure);
             }
             finally

Original file line number	Diff line number	Diff line change
`@@ -240,7 +240,7 @@ public async Task<HttpResponseMessage> SendAsync(HttpRequestMessage request, lon`
`240`	`240`	`catch (QuicException ex) when (ex.QuicError == QuicError.OperationAborted)`
`241`	`241`	`{`
`242`	`242`	`// This will happen if we aborted _connection somewhere and we have pending OpenOutboundStreamAsync call.`
`243`		`- Debug.Assert(_abortException is not null);`
	`243`	`+ // note that _abortException may be null if we closed the connection in response to a GOAWAY frame`
`244`	`244`	`throw new HttpRequestException(SR.net_http_client_execution_error, _abortException, RequestRetryType.RetryOnConnectionFailure);`
`245`	`245`	`}`
`246`	`246`	`finally`