Skip to content

Commit 5e38aec

Browse files
With build -subset help output "macro" subset components (#64578)
Remove `clr.spmi` from default list; it's already there due to `clr.native`.
1 parent ccca2d4 commit 5e38aec

File tree

1 file changed

+10
-10
lines changed

1 file changed

+10
-10
lines changed

eng/Subsets.props

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@
3737
<DefaultSubsets Condition="('$(DotNetBuildFromSource)' == 'true' and '$(PrimaryRuntimeFlavor)' != 'Mono') or ('$(TargetOS)' == 'windows' and '$(TargetArchitecture)' != 'x86' and '$(TargetArchitecture)' != 'x64')">clr+libs+host+packs</DefaultSubsets>
3838
</PropertyGroup>
3939

40-
<!-- Init _subset here in to allow RuntimeFlavor to be set as early as possible -->
40+
<!-- Init _subset here to allow RuntimeFlavor to be set as early as possible -->
4141
<PropertyGroup>
4242
<_subset Condition="'$(Subset)' != ''">+$(Subset.ToLowerInvariant())+</_subset>
4343
<_subset Condition="'$(Subset)' == ''">+$(DefaultSubsets)+</_subset>
@@ -58,7 +58,7 @@
5858
</PropertyGroup>
5959

6060
<PropertyGroup>
61-
<DefaultCoreClrSubsets>clr.native+linuxdac+clr.corelib+clr.tools+clr.nativecorelib+clr.packages+clr.nativeaotlibs+clr.spmi</DefaultCoreClrSubsets>
61+
<DefaultCoreClrSubsets>clr.native+linuxdac+clr.corelib+clr.tools+clr.nativecorelib+clr.packages+clr.nativeaotlibs</DefaultCoreClrSubsets>
6262
<!-- Even on platforms that do not support the CoreCLR runtime, we still want to build ilasm/ildasm. -->
6363
<DefaultCoreClrSubsets Condition="'$(PrimaryRuntimeFlavor)' != 'CoreCLR'">clr.iltools+clr.packages</DefaultCoreClrSubsets>
6464

@@ -101,11 +101,11 @@
101101

102102
<ItemGroup>
103103
<!-- CoreClr -->
104-
<SubsetName Include="Clr" Description="The CoreCLR runtime, LinuxDac, CoreLib (+ native), tools and packages." />
104+
<SubsetName Include="Clr" Description="The full CoreCLR runtime. Equivalent to: $(DefaultCoreClrSubsets)" />
105105
<SubsetName Include="Clr.NativePrereqs" Description="Managed tools that support building the native components of the runtime (such as DacTableGen)." />
106-
<SubsetName Include="Clr.ILTools" Description="The CoreCLR IL tools." />
107-
<SubsetName Include="Clr.Runtime" Description="The CoreCLR .NET runtime." />
108-
<SubsetName Include="Clr.Native" Description="All CoreCLR native non-test components, including the runtime, jits, and other native tools." />
106+
<SubsetName Include="Clr.ILTools" Description="The CoreCLR IL tools (ilasm/ildasm)." />
107+
<SubsetName Include="Clr.Runtime" Description="The CoreCLR .NET runtime. Includes clr.jit, clr.iltools, clr.hosts." />
108+
<SubsetName Include="Clr.Native" Description="All CoreCLR native non-test components, including the runtime, jits, and other native tools. Includes clr.hosts, clr.runtime, clr.jit, clr.alljits, clr.paltests, clr.iltools, clr.nativeaotruntime, clr.spmi." />
109109
<SubsetName Include="Clr.NativeAotLibs" Description="The CoreCLR native AOT CoreLib and other low level class libraries." />
110110
<SubsetName Include="Clr.NativeAotRuntime" Description="The stripped-down CoreCLR native AOT runtime." />
111111
<SubsetName Include="Clr.PalTests" OnDemand="true" Description="The CoreCLR PAL tests." />
@@ -124,7 +124,7 @@
124124
Description="Packaging of cross OS DAC. Requires all assets needed to be present at a folder specified by $(CrossDacArtifactsDir). See 'Microsoft.CrossOsDiag.Private.CoreCLR.proj' for details." />
125125

126126
<!-- Mono -->
127-
<SubsetName Include="Mono" Description="The Mono runtime and CoreLib." />
127+
<SubsetName Include="Mono" Description="The Mono runtime and CoreLib. Equivalent to: $(DefaultMonoSubsets)" />
128128
<SubsetName Include="Mono.Runtime" Description="The Mono .NET runtime." />
129129
<SubsetName Include="Mono.AotCross" Description="The cross-compiler runtime for Mono AOT." />
130130
<SubsetName Include="Mono.CoreLib" Description="The managed System.Private.CoreLib library for Mono." />
@@ -134,14 +134,14 @@
134134
<SubsetName Include="Mono.Workloads" OnDemand="true" Description="Builds the installers and the insertion metadata for Blazor workloads." />
135135

136136
<!-- Host -->
137-
<SubsetName Include="Host" Description="The .NET hosts, packages, hosting libraries, and tests." />
137+
<SubsetName Include="Host" Description="The .NET hosts, packages, hosting libraries, and tests. Equivalent to: $(DefaultHostSubsets)" />
138138
<SubsetName Include="Host.Native" Description="The .NET hosts." />
139139
<SubsetName Include="Host.Pkg" Description="The .NET host packages." />
140140
<SubsetName Include="Host.Tools" Description="The .NET hosting libraries." />
141141
<SubsetName Include="Host.Tests" Description="The .NET hosting tests." />
142142

143143
<!-- Libs -->
144-
<SubsetName Include="Libs" Description="The libraries native part, refs and source assemblies, test infra and packages, but NOT the tests (use Libs.Tests to request those explicitly)" />
144+
<SubsetName Include="Libs" Description="The libraries native part, refs and source assemblies, test infra and packages, but NOT the tests (use Libs.Tests to request those explicitly). Equivalent to: $(DefaultLibrariesSubsets)" />
145145
<SubsetName Include="Libs.Native" Description="The native libraries used in the shared framework." />
146146
<SubsetName Include="Libs.Ref" Description="The managed reference libraries." />
147147
<SubsetName Include="Libs.Src" Description="The managed implementation libraries." />
@@ -150,7 +150,7 @@
150150
<SubsetName Include="Libs.Tests" OnDemand="true" Description="The test projects. Note that building this doesn't execute tests: you must also pass the '-test' argument." />
151151

152152
<!-- Packs -->
153-
<SubsetName Include="Packs" Description="Builds the shared framework packs, archives, bundles, installers, and the framework pack tests." />
153+
<SubsetName Include="Packs" Description="Builds the shared framework packs, archives, bundles, installers, and the framework pack tests. Equivalent to: $(DefaultPacksSubsets)" />
154154
<SubsetName Include="Packs.Product" Description="Builds the shared framework packs, archives, bundles, and installers." />
155155
<SubsetName Include="Packs.Installers" Description="Builds the shared framework bundles and installers." />
156156
<SubsetName Include="Packs.Tests" Description="The framework pack tests." />

0 commit comments

Comments
 (0)