Address review comments

Author: roji

src/libraries/System.Transactions.Local/src/System/Transactions/DtcProxyShim/DTCInterfaces/ITransactionResourceAsync.cs

@@ -24,7 +24,7 @@ internal interface ITransactionResourceAsync
     /// </summary>
     /// <param name="fRetaining">Always false.</param>
     /// <param name="grfRM">Values from <see cref="OletxXactRm" />.</param>
-    /// <param name="fWantMoniker">Always false.</param> // TODO
+    /// <param name="fWantMoniker">Always false.</param>
     /// <param name="fSinglePhase">If true, it indicates that the RM is the only resource manager enlisted on the transaction.</param>
     void PrepareRequest(
         [MarshalAs(UnmanagedType.Bool)] bool fRetaining,

src/libraries/System.Transactions.Local/src/System/Transactions/DtcProxyShim/DtcProxyShimFactory.cs

@@ -135,7 +135,7 @@ public void BeginTransaction(
         out Guid transactionIdentifier,
         out TransactionShim transactionShim)
     {
-        var options = GetCachedOptions();
+        ITransactionOptions options = GetCachedOptions();
 
         try
         {
@@ -197,7 +197,7 @@ public void ReceiveTransaction(
         out OletxTransactionIsolationLevel isolationLevel,
         out TransactionShim transactionShim)
     {
-        var receiver = GetCachedReceiver();
+        ITransactionReceiver receiver = GetCachedReceiver();
 
         try
         {
@@ -250,7 +250,7 @@ public void GetNotification(
 
         Monitor.Enter(_notificationLock);
 
-        var entryRemoved = _notifications.TryDequeue(out NotificationShimBase? notification);
+        bool entryRemoved = _notifications.TryDequeue(out NotificationShimBase? notification);
         if (entryRemoved)
         {
             managedIdentifier = notification!.EnlistmentIdentifier;

src/libraries/System.Transactions.Local/src/System/Transactions/DtcProxyShim/EnlistmentNotifyShim.cs

@@ -33,7 +33,7 @@ internal void SetIgnoreSpuriousProxyNotifications()
 
     public void PrepareRequest(bool fRetaining, OletxXactRm grfRM, bool fWantMoniker, bool fSinglePhase)
     {
-        var pEnlistmentAsync = Interlocked.Exchange(ref EnlistmentAsync, null);
+        ITransactionEnlistmentAsync? pEnlistmentAsync = Interlocked.Exchange(ref EnlistmentAsync, null);
 
         if (pEnlistmentAsync is null)
         {

src/libraries/System.Transactions.Local/src/System/Transactions/DtcProxyShim/Guids.cs

@@ -6,7 +6,6 @@
 
 namespace System.Transactions.DtcProxyShim;
 
-// TODO: Is this the right to manage these COM IIDs?
 internal static class Guids
 {
     internal const string IID_ITransactionDispenser = "3A6AD9E1-23B9-11cf-AD60-00AA00A74CCD";

src/libraries/System.Transactions.Local/src/System/Transactions/DtcProxyShim/OletxHelper.cs

@@ -34,7 +34,7 @@ internal static void Retry(Action action)
     {
         int nRetries = MaxRetryCount;
 
-        while (nRetries > 0)
+        while (true)
         {
             try
             {
@@ -43,8 +43,12 @@ internal static void Retry(Action action)
             }
             catch (COMException e) when (e.ErrorCode == XACT_E_ALREADYINPROGRESS)
             {
+                if (--nRetries == 0)
+                {
+                    throw;
+                }
+
                 Thread.Sleep(RetryInterval);
-                nRetries--;
             }
         }
     }

src/libraries/System.Transactions.Local/src/System/Transactions/DtcProxyShim/ResourceManagerShim.cs

@@ -25,7 +25,7 @@ public void Enlist(
         var pEnlistmentNotifyShim = new EnlistmentNotifyShim(_shimFactory, managedIdentifier);
         var pEnlistmentShim = new EnlistmentShim(pEnlistmentNotifyShim);
 
-        var transaction = transactionShim.Transaction;
+        ITransaction transaction = transactionShim.Transaction;
         ResourceManager!.Enlist(transaction, pEnlistmentNotifyShim, out Guid txUow, out OletxTransactionIsolationLevel isoLevel, out ITransactionEnlistmentAsync pEnlistmentAsync);
 
         pEnlistmentNotifyShim.EnlistmentAsync = pEnlistmentAsync;

src/libraries/System.Transactions.Local/src/System/Transactions/DtcProxyShim/TransactionShim.cs

@@ -62,7 +62,7 @@ public void GetITransactionNative(out IDtcTransaction transactionNative)
 
     public unsafe byte[] GetPropagationToken()
     {
-        var transmitter = _shimFactory.GetCachedTransmitter(Transaction);
+        ITransactionTransmitter transmitter = _shimFactory.GetCachedTransmitter(Transaction);
 
         try
         {

src/libraries/System.Transactions.Local/src/System/Transactions/DtcProxyShim/VoterShim.cs

@@ -16,7 +16,7 @@ internal VoterBallotShim(DtcProxyShimFactory shimFactory, VoterNotifyShim notify
 
     public void Vote(bool voteYes)
     {
-        var voteHr = OletxHelper.S_OK;
+        int voteHr = OletxHelper.S_OK;
 
         if (!voteYes)
         {

src/libraries/System.Transactions.Local/src/System/Transactions/NonWindowsUnsupported.cs

@@ -197,7 +197,3 @@ internal static Exception NotSupported()
             => new PlatformNotSupportedException(SR.DistributedNotSupported);
     }
 }
-
-namespace System.Transactions.Diagnostics
-{
-}

src/libraries/System.Transactions.Local/src/System/Transactions/Oletx/OletxDependentTransaction.cs

@@ -43,7 +43,7 @@ public void Complete()
 
         Debug.Assert(Disposed == 0, "OletxTransction object is disposed");
 
-        int localCompleted = Interlocked.CompareExchange(ref _completed, 1, 0);
+        int localCompleted = Interlocked.Exchange(ref _completed, 1);
         if (localCompleted == 1)
         {
             throw TransactionException.CreateTransactionCompletedException(DistributedTxId);