[wasm] Enable tests blocked by IL2105 (#57457)

lewing · web-flow · commit 82f7144f7913 · 2021-08-17T16:28:09.000-05:00
* Disable ReflectionCachesUpdateHandler_CachesCleared with aggressive trimming

* Enable more tests stopped by 2105

* Create tests.mobile.targets

Suppress IL2025

* Remove comment enabling trim warnings

* Mark more active issues
diff --git a/eng/testing/tests.mobile.targets b/eng/testing/tests.mobile.targets
@@ -13,8 +13,7 @@
     <PublishTrimmed>true</PublishTrimmed>
     <!-- Suppress linker warnings as these are tests -->
     <SuppressTrimAnalysisWarnings>true</SuppressTrimAnalysisWarnings>
-    <!-- Can be removed when SDK update picks up https://github.com/dotnet/sdk/pull/18655. -->
-    <NoWarn>$(NoWarn);IL2111</NoWarn>
+    <NoWarn>$(NoWarn);IL2111;IL2105;IL2025</NoWarn>
     <!-- https://github.com/dotnet/sdk/issues/18581 tracks needing to set 2 properties to disable warnings. -->
     <EnableTrimAnalyzer>false</EnableTrimAnalyzer>
 
diff --git a/src/libraries/System.ComponentModel.TypeConverter/tests/ReflectionCachesUpdateHandlerTests.cs b/src/libraries/System.ComponentModel.TypeConverter/tests/ReflectionCachesUpdateHandlerTests.cs
@@ -11,6 +11,7 @@ namespace System.ComponentModel.Tests
     public class ReflectionCachesUpdateHandlerTests
     {
         [Fact]
+        [ActiveIssue("https://github.com/dotnet/runtime/issues/57456", typeof(PlatformDetection), nameof(PlatformDetection.IsBuiltWithAggressiveTrimming), nameof(PlatformDetection.IsBrowser))]
         public void ReflectionCachesUpdateHandler_CachesCleared()
         {
             AttributeCollection ac1 = TypeDescriptor.GetAttributes(typeof(ReflectionCachesUpdateHandlerTests));
diff --git a/src/libraries/System.ObjectModel/tests/ObservableCollection/ObservableCollection_ConstructorAndPropertyTests.cs b/src/libraries/System.ObjectModel/tests/ObservableCollection/ObservableCollection_ConstructorAndPropertyTests.cs
@@ -118,6 +118,7 @@ public static void IsReadOnlyTest()
         }
 
         [Fact]
+        [ActiveIssue("https://github.com/dotnet/runtime/issues/57588", typeof(PlatformDetection), nameof(PlatformDetection.IsBuiltWithAggressiveTrimming), nameof(PlatformDetection.IsBrowser))]
         public static void DebuggerAttributeTests()
         {
             ObservableCollection<int> col = new ObservableCollection<int>(new[] {1, 2, 3, 4});
@@ -129,6 +130,7 @@ public static void DebuggerAttributeTests()
         }
 
         [Fact]
+        [ActiveIssue("https://github.com/dotnet/runtime/issues/57588", typeof(PlatformDetection), nameof(PlatformDetection.IsBuiltWithAggressiveTrimming), nameof(PlatformDetection.IsBrowser))]
         public static void DebuggerAttribute_NullCollection_ThrowsArgumentNullException()
         {
             TargetInvocationException ex = Assert.Throws<TargetInvocationException>(() => DebuggerAttributes.ValidateDebuggerTypeProxyProperties(typeof(ObservableCollection<int>), null));
diff --git a/src/libraries/System.ObjectModel/tests/ObservableCollection/ObservableCollection_Serialization.cs b/src/libraries/System.ObjectModel/tests/ObservableCollection/ObservableCollection_Serialization.cs
@@ -27,6 +27,7 @@ public void SerializeDeserialize_Roundtrips(ObservableCollection<int> c)
         }
 
         [Fact]
+        [ActiveIssue("https://github.com/dotnet/runtime/issues/57588", typeof(PlatformDetection), nameof(PlatformDetection.IsBuiltWithAggressiveTrimming), nameof(PlatformDetection.IsBrowser))]
         public void OnDeserialized_MonitorNotInitialized_ExpectSuccess()
         {
             var observableCollection = new ObservableCollection<int>();
diff --git a/src/libraries/System.ObjectModel/tests/ReadOnlyDictionary/ReadOnlyDictionaryTests.cs b/src/libraries/System.ObjectModel/tests/ReadOnlyDictionary/ReadOnlyDictionaryTests.cs
@@ -224,6 +224,7 @@ public static void CannotModifyDictionaryTests_Negative()
         }
 
         [Fact]
+        [ActiveIssue("https://github.com/dotnet/runtime/issues/57588", typeof(PlatformDetection), nameof(PlatformDetection.IsBuiltWithAggressiveTrimming), nameof(PlatformDetection.IsBrowser))]
         public static void DebuggerAttributeTests()
         {
             ReadOnlyDictionary<int, int> dict = new ReadOnlyDictionary<int, int>(new Dictionary<int, int>{{1, 2}, {2, 4}, {3, 6}});
@@ -247,6 +248,7 @@ public static void DebuggerAttributeTests()
         }
 
         [Fact]
+        [ActiveIssue("https://github.com/dotnet/runtime/issues/57588", typeof(PlatformDetection), nameof(PlatformDetection.IsBuiltWithAggressiveTrimming), nameof(PlatformDetection.IsBrowser))]
         public static void DebuggerAttribute_NullDictionary_ThrowsArgumentNullException()
         {
             TargetInvocationException ex = Assert.Throws<TargetInvocationException>(() =>   DebuggerAttributes.ValidateDebuggerTypeProxyProperties(typeof(ReadOnlyDictionary<int, int>), null));
@@ -255,6 +257,7 @@ public static void DebuggerAttribute_NullDictionary_ThrowsArgumentNullException(
         }
 
         [Fact]
+        [ActiveIssue("https://github.com/dotnet/runtime/issues/57588", typeof(PlatformDetection), nameof(PlatformDetection.IsBuiltWithAggressiveTrimming), nameof(PlatformDetection.IsBrowser))]
         public static void DebuggerAttribute_NullDictionaryKeys_ThrowsArgumentNullException()
         {
             TargetInvocationException ex = Assert.Throws<TargetInvocationException>(() => DebuggerAttributes.ValidateDebuggerTypeProxyProperties(typeof(ReadOnlyDictionary<int, int>.KeyCollection), new Type[] { typeof(int) }, null));
diff --git a/src/libraries/System.ObjectModel/tests/ReadOnlyObservableCollection/ReadOnlyObservableCollectionTests.cs b/src/libraries/System.ObjectModel/tests/ReadOnlyObservableCollection/ReadOnlyObservableCollectionTests.cs
@@ -197,6 +197,7 @@ public static void CannotModifyDictionaryTests_Negative()
         }
 
         [Fact]
+        [ActiveIssue("https://github.com/dotnet/runtime/issues/57588", typeof(PlatformDetection), nameof(PlatformDetection.IsBuiltWithAggressiveTrimming), nameof(PlatformDetection.IsBrowser))]
         public static void DebuggerAttribute_Tests()
         {
             ReadOnlyObservableCollection<int> col = new ReadOnlyObservableCollection<int>(new ObservableCollection<int>(new[] {1, 2, 3, 4}));
@@ -208,6 +209,7 @@ public static void DebuggerAttribute_Tests()
         }
 
         [Fact]
+        [ActiveIssue("https://github.com/dotnet/runtime/issues/57588", typeof(PlatformDetection), nameof(PlatformDetection.IsBuiltWithAggressiveTrimming), nameof(PlatformDetection.IsBrowser))]
         public static void DebuggerAttribute_NullCollection_ThrowsArgumentNullException()
         {
             TargetInvocationException ex = Assert.Throws<TargetInvocationException>(() => DebuggerAttributes.ValidateDebuggerTypeProxyProperties(typeof(ReadOnlyObservableCollection<int>), null));
diff --git a/src/libraries/tests.proj b/src/libraries/tests.proj
@@ -242,11 +242,6 @@
     <ProjectExclusions Include="$(MSBuildThisFileDirectory)System.Diagnostics.DiagnosticSource\tests\System.Diagnostics.DiagnosticSource.Tests.csproj" />
     <ProjectExclusions Include="$(MSBuildThisFileDirectory)System.Diagnostics.Tracing/tests/System.Diagnostics.Tracing.Tests.csproj" />
 
-    <!-- Issue: https://github.com/dotnet/runtime/issues/51602 -->
-    <ProjectExclusions Include="$(MSBuildThisFileDirectory)System.ComponentModel.Primitives\tests\System.ComponentModel.Primitives.Tests.csproj" />
-    <ProjectExclusions Include="$(MSBuildThisFileDirectory)System.ObjectModel\tests\System.ObjectModel.Tests.csproj" />
-    <ProjectExclusions Include="$(MSBuildThisFileDirectory)System.ComponentModel.TypeConverter/tests/System.ComponentModel.TypeConverter.Tests.csproj" />
-
     <!-- Issue: https://github.com/dotnet/runtime/issues/51708 -->
     <ProjectExclusions Include="$(MSBuildThisFileDirectory)System.Linq.Expressions\tests\System.Linq.Expressions.Tests.csproj" />
 

Original file line number	Diff line number	Diff line change
`@@ -11,6 +11,7 @@ namespace System.ComponentModel.Tests`
`11`	`11`	`public class ReflectionCachesUpdateHandlerTests`
`12`	`12`	`{`
`13`	`13`	`[Fact]`
	`14`	`+ [ActiveIssue("https://github.com/dotnet/runtime/issues/57456", typeof(PlatformDetection), nameof(PlatformDetection.IsBuiltWithAggressiveTrimming), nameof(PlatformDetection.IsBrowser))]`
`14`	`15`	`public void ReflectionCachesUpdateHandler_CachesCleared()`
`15`	`16`	`{`
`16`	`17`	`AttributeCollection ac1 = TypeDescriptor.GetAttributes(typeof(ReflectionCachesUpdateHandlerTests));`
Original file line number	Diff line number	Diff line change
`@@ -118,6 +118,7 @@ public static void IsReadOnlyTest()`
`118`	`118`	`}`
`119`	`119`
`120`	`120`	`[Fact]`
	`121`	`+ [ActiveIssue("https://github.com/dotnet/runtime/issues/57588", typeof(PlatformDetection), nameof(PlatformDetection.IsBuiltWithAggressiveTrimming), nameof(PlatformDetection.IsBrowser))]`
`121`	`122`	`public static void DebuggerAttributeTests()`
`122`	`123`	`{`
`123`	`124`	`ObservableCollection<int> col = new ObservableCollection<int>(new[] {1, 2, 3, 4});`
`@@ -129,6 +130,7 @@ public static void DebuggerAttributeTests()`
`129`	`130`	`}`
`130`	`131`
`131`	`132`	`[Fact]`
	`133`	`+ [ActiveIssue("https://github.com/dotnet/runtime/issues/57588", typeof(PlatformDetection), nameof(PlatformDetection.IsBuiltWithAggressiveTrimming), nameof(PlatformDetection.IsBrowser))]`
`132`	`134`	`public static void DebuggerAttribute_NullCollection_ThrowsArgumentNullException()`
`133`	`135`	`{`
`134`	`136`	`TargetInvocationException ex = Assert.Throws<TargetInvocationException>(() => DebuggerAttributes.ValidateDebuggerTypeProxyProperties(typeof(ObservableCollection<int>), null));`
Original file line number	Diff line number	Diff line change
`@@ -27,6 +27,7 @@ public void SerializeDeserialize_Roundtrips(ObservableCollection<int> c)`
`27`	`27`	`}`
`28`	`28`
`29`	`29`	`[Fact]`
	`30`	`+ [ActiveIssue("https://github.com/dotnet/runtime/issues/57588", typeof(PlatformDetection), nameof(PlatformDetection.IsBuiltWithAggressiveTrimming), nameof(PlatformDetection.IsBrowser))]`
`30`	`31`	`public void OnDeserialized_MonitorNotInitialized_ExpectSuccess()`
`31`	`32`	`{`
`32`	`33`	`var observableCollection = new ObservableCollection<int>();`
Original file line number	Diff line number	Diff line change
`@@ -224,6 +224,7 @@ public static void CannotModifyDictionaryTests_Negative()`
`224`	`224`	`}`
`225`	`225`
`226`	`226`	`[Fact]`
	`227`	`+ [ActiveIssue("https://github.com/dotnet/runtime/issues/57588", typeof(PlatformDetection), nameof(PlatformDetection.IsBuiltWithAggressiveTrimming), nameof(PlatformDetection.IsBrowser))]`
`227`	`228`	`public static void DebuggerAttributeTests()`
`228`	`229`	`{`
`229`	`230`	`ReadOnlyDictionary<int, int> dict = new ReadOnlyDictionary<int, int>(new Dictionary<int, int>{{1, 2}, {2, 4}, {3, 6}});`
`@@ -247,6 +248,7 @@ public static void DebuggerAttributeTests()`
`247`	`248`	`}`
`248`	`249`
`249`	`250`	`[Fact]`
	`251`	`+ [ActiveIssue("https://github.com/dotnet/runtime/issues/57588", typeof(PlatformDetection), nameof(PlatformDetection.IsBuiltWithAggressiveTrimming), nameof(PlatformDetection.IsBrowser))]`
`250`	`252`	`public static void DebuggerAttribute_NullDictionary_ThrowsArgumentNullException()`
`251`	`253`	`{`
`252`	`254`	`TargetInvocationException ex = Assert.Throws<TargetInvocationException>(() => DebuggerAttributes.ValidateDebuggerTypeProxyProperties(typeof(ReadOnlyDictionary<int, int>), null));`
`@@ -255,6 +257,7 @@ public static void DebuggerAttribute_NullDictionary_ThrowsArgumentNullException(`
`255`	`257`	`}`
`256`	`258`
`257`	`259`	`[Fact]`
	`260`	`+ [ActiveIssue("https://github.com/dotnet/runtime/issues/57588", typeof(PlatformDetection), nameof(PlatformDetection.IsBuiltWithAggressiveTrimming), nameof(PlatformDetection.IsBrowser))]`
`258`	`261`	`public static void DebuggerAttribute_NullDictionaryKeys_ThrowsArgumentNullException()`
`259`	`262`	`{`
`260`	`263`	`TargetInvocationException ex = Assert.Throws<TargetInvocationException>(() => DebuggerAttributes.ValidateDebuggerTypeProxyProperties(typeof(ReadOnlyDictionary<int, int>.KeyCollection), new Type[] { typeof(int) }, null));`
Original file line number	Diff line number	Diff line change
`@@ -197,6 +197,7 @@ public static void CannotModifyDictionaryTests_Negative()`
`197`	`197`	`}`
`198`	`198`
`199`	`199`	`[Fact]`
	`200`	`+ [ActiveIssue("https://github.com/dotnet/runtime/issues/57588", typeof(PlatformDetection), nameof(PlatformDetection.IsBuiltWithAggressiveTrimming), nameof(PlatformDetection.IsBrowser))]`
`200`	`201`	`public static void DebuggerAttribute_Tests()`
`201`	`202`	`{`
`202`	`203`	`ReadOnlyObservableCollection<int> col = new ReadOnlyObservableCollection<int>(new ObservableCollection<int>(new[] {1, 2, 3, 4}));`
`@@ -208,6 +209,7 @@ public static void DebuggerAttribute_Tests()`
`208`	`209`	`}`
`209`	`210`
`210`	`211`	`[Fact]`
	`212`	`+ [ActiveIssue("https://github.com/dotnet/runtime/issues/57588", typeof(PlatformDetection), nameof(PlatformDetection.IsBuiltWithAggressiveTrimming), nameof(PlatformDetection.IsBrowser))]`
`211`	`213`	`public static void DebuggerAttribute_NullCollection_ThrowsArgumentNullException()`
`212`	`214`	`{`
`213`	`215`	`TargetInvocationException ex = Assert.Throws<TargetInvocationException>(() => DebuggerAttributes.ValidateDebuggerTypeProxyProperties(typeof(ReadOnlyObservableCollection<int>), null));`