Fix xunit analyzers to run on library test projects

We don't want most analyzers running over our test code currently (some rules could be enabled with varying degrees of effort), but we do want the xunit analyzers running, and they haven't been.  Fix that by creating a new ruleset specific to library tests, and switching over to use it when building library test projects.

Author: stephentoub

eng/CodeAnalysis.ruleset

@@ -225,7 +225,8 @@
     <CheckForOverflowUnderflow>false</CheckForOverflowUnderflow>
     <GenFacadesIgnoreBuildAndRevisionMismatch>true</GenFacadesIgnoreBuildAndRevisionMismatch>
     <!-- Disable analyzers for tests and unsupported projects -->
-    <RunAnalyzers Condition="'$(IsSourceProject)' != 'true' or '$(MSBuildProjectExtension)' == '.ilproj'">false</RunAnalyzers>
+    <RunAnalyzers Condition="'$(IsTestProject)' != 'true' and '$(IsSourceProject)' != 'true'">false</RunAnalyzers>
+    <CodeAnalysisRuleset Condition="'$(IsTestProject)' == 'true'">$(RepositoryEngineeringDir)CodeAnalysis.test.ruleset</CodeAnalysisRuleset>
   </PropertyGroup>
 
   <!-- Set up common paths -->

eng/CodeAnalysis.test.ruleset

@@ -845,7 +845,7 @@ public void CanBindByteArrayWhenValueIsNull()
             var config = configurationBuilder.Build();
 
             var options = config.Get<ByteArrayOptions>();
-            Assert.Equal(null, options.MyByteArray);
+            Assert.Null(options.MyByteArray);
         }
 
         [Fact]

src/libraries/Directory.Build.props

@@ -265,7 +265,8 @@ public void ScopeDispose_PreventsServiceResolution()
             Assert.NotNull(provider.CreateScope());
         }
 
-        [Theory(Skip = "https://github.com/dotnet/runtime/issues/42160 - We don't support value task services currently")]
+        [ActiveIssue("https://github.com/dotnet/runtime/issues/42160")] // We don't support value task services currently
+        [Theory]
         [InlineData(ServiceLifetime.Transient)]
         [InlineData(ServiceLifetime.Scoped)]
         [InlineData(ServiceLifetime.Singleton)]

src/libraries/Microsoft.Extensions.Configuration.Binder/tests/ConfigurationBinderTests.cs

@@ -7,6 +7,8 @@ namespace System.Security.Cryptography.Csp.Tests
 {
     public static class CspParametersTests
     {
+        public static bool ManualTestsEnabled => !string.IsNullOrEmpty(Environment.GetEnvironmentVariable("MANUAL_TESTS"));
+
         const int PROV_RSA_FULL = 1;
         const int PROV_RSA_AES = 24;
 
@@ -45,7 +47,7 @@ public static void KeyPassword_SetGet()
             }
         }
 
-        [Theory(Skip = "Manual test - requires Smart Card - read instructions")]
+        [ConditionalTheory(nameof(ManualTestsEnabled))] // requires Smart Card - read instructions
         [InlineData(true)]
         [InlineData(false)]
         public static void KeyPassword_SmartCard_Manual_Test(bool correctPassword)

src/libraries/Microsoft.Extensions.DependencyInjection/tests/DI.Tests/ServiceProviderContainerTests.cs

@@ -817,9 +817,11 @@ static void PerformFloatingPointSerialization(string testString)
         [InlineData("NaNa")]
         [InlineData("Infinitya")]
         [InlineData("-Infinitya")]
+#pragma warning disable xUnit1025 // Theory method 'FloatingPointConstants_Fail' on test class 'NumberHandlingTests' has InlineData duplicate(s)
         [InlineData("\u006EaN")] // "naN"
         [InlineData("\u0020Inf\u0069ni\u0074y")] // " Infinity"
         [InlineData("\u002BInf\u0069nity")] // "+Infinity"
+#pragma warning restore xUnit1025
         public static void FloatingPointConstants_Fail(string testString)
         {
             string testStringAsJson = $@"""{testString}""";